bug#5270: [PATCH] * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) Insert thumbnails before file names of marked files in the dired buffer.

[Thierry Volpiatto <thierry.volpiatto@gmail.com>]

Juri Linkov <juri@jurta.org> writes:

>>> Thierry, could you please send the latest version of your patch here
>>> to 5270@debbugs.gnu.org?  It seems a good change to install to Emacs.
>>
>> changeset:   108790:edb0d0e61eb8
>> tag:         qtip
>> tag:         patch-r108790
>> tag:         tip
>> tag:         qbase
>> user:        Thierry Volpiatto <thierry.volpiatto@gmail.com>
>> date:        Mon May 24 21:40:52 2010 +0200
>> summary:     * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs)
>> Insert thumbnails before file names of marked files in the dired buffer.
>
> Thanks.  I think your patch should be committed now with two small changes:
>
> 1. To make it compatible with other Dired commands, use the interactive
> spec (interactive "P") instead of (interactive "p").
> And also remove the line `(when (eq arg 1) (setq arg nil))' because
> `dired-map-over-marks' already takes care of the prefix argument.
Agree, that's better.

> 2. Create a new function `image-dired-dired-toggle-marked-thumbs'
> from your changes and re-bind it to "\C-t\C-t" in dired.el
> because this is a better name for changed functionality.
> The current function `image-dired-dired-insert-marked-thumbs'
> could be obsoleted later.
Yes we already talk about using "toggle" as name and i completely forget
that, so yes it is better to rename to
`image-dired-dired-toggle-marked-thumbs'.
I think also the old function can safely be removed.

> I tried your patch with these small changes, and it is much better
> than the current `image-dired-dired-insert-marked-thumbs'.
Thanks, feel free also to write docstring in better english if something
is incorrect.(E.g Explaining better how to use (+/-)prefix arg maybe).

-- 
Thierry Volpiatto
Gpg key: http://pgp.mit.edu/