* bug#8134: (Some special files were saved without asking)
@ 2011-02-28 2:09 jidanni
2011-03-05 11:33 ` David Engster
2011-03-05 12:20 ` jidanni
0 siblings, 2 replies; 6+ messages in thread
From: jidanni @ 2011-02-28 2:09 UTC (permalink / raw)
To: 8134
Encountered new message "(Some special files were saved without asking)".
Well at least in C-h e mention what they were.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#8134: (Some special files were saved without asking)
2011-02-28 2:09 bug#8134: (Some special files were saved without asking) jidanni
@ 2011-03-05 11:33 ` David Engster
2011-03-05 11:50 ` Andreas Schwab
2011-03-05 19:38 ` Chong Yidong
2011-03-05 12:20 ` jidanni
1 sibling, 2 replies; 6+ messages in thread
From: David Engster @ 2011-03-05 11:33 UTC (permalink / raw)
To: 8134; +Cc: jidanni
'jidanni' writes:
> Encountered new message "(Some special files were saved without asking)".
> Well at least in C-h e mention what they were.
I agree.
That you're suddenly seeing this message is due to a change in Gnus,
which now saves the .newsrc-dribble file without asking when you invoke
stuff like 'compile' and other functions which call `save-some-buffers'.
I'm proposing the following change (against trunk):
--- lisp/files.el 2011-03-05 08:48:52 +0000
+++ lisp/files.el 2011-03-05 11:03:02 +0000
@@ -4616,7 +4616,7 @@
;; That way the following code won't ask about them.
(with-current-buffer buffer
(when (and buffer-save-without-query (buffer-modified-p))
- (setq some-automatic t)
+ (setq some-automatic (append some-automatic (list (buffer-name))))
(save-buffer))))
;; Ask about those buffers that merit it,
;; and record the number thus saved.
@@ -4663,7 +4663,9 @@
(setq abbrevs-done t)))
(or queried (> files-done 0) abbrevs-done
(message (if some-automatic
- "(Some special files were saved without asking)"
+ (concat
+ "(The following special buffers were saved without asking: "
+ (mapconcat 'identity some-automatic " ") ")")
"(No files need saving)"))))))
\f
(defun not-modified (&optional arg)
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#8134: (Some special files were saved without asking)
2011-03-05 11:33 ` David Engster
@ 2011-03-05 11:50 ` Andreas Schwab
2011-03-05 19:38 ` Chong Yidong
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2011-03-05 11:50 UTC (permalink / raw)
To: David Engster; +Cc: 8134, jidanni
David Engster <deng@randomsample.de> writes:
> --- lisp/files.el 2011-03-05 08:48:52 +0000
> +++ lisp/files.el 2011-03-05 11:03:02 +0000
> @@ -4616,7 +4616,7 @@
> ;; That way the following code won't ask about them.
> (with-current-buffer buffer
> (when (and buffer-save-without-query (buffer-modified-p))
> - (setq some-automatic t)
> + (setq some-automatic (append some-automatic (list (buffer-name))))
(setq some-automatic (cons (buffer-name) some-automatic))
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#8134: (Some special files were saved without asking)
2011-03-05 11:33 ` David Engster
2011-03-05 11:50 ` Andreas Schwab
@ 2011-03-05 19:38 ` Chong Yidong
1 sibling, 0 replies; 6+ messages in thread
From: Chong Yidong @ 2011-03-05 19:38 UTC (permalink / raw)
To: David Engster; +Cc: 8134, jidanni
David Engster <deng@randomsample.de> writes:
>> Encountered new message "(Some special files were saved without asking)".
>> Well at least in C-h e mention what they were.
>
> I agree.
>
> That you're suddenly seeing this message is due to a change in Gnus,
> which now saves the .newsrc-dribble file without asking when you invoke
> stuff like 'compile' and other functions which call `save-some-buffers'.
>
> I'm proposing the following change (against trunk):
Committed, with some tweaks. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#8134: (Some special files were saved without asking)
2011-02-28 2:09 bug#8134: (Some special files were saved without asking) jidanni
2011-03-05 11:33 ` David Engster
@ 2011-03-05 12:20 ` jidanni
2011-03-05 13:03 ` David Engster
1 sibling, 1 reply; 6+ messages in thread
From: jidanni @ 2011-03-05 12:20 UTC (permalink / raw)
To: schwab; +Cc: 8134, deng
Also I bet C-x C-x not asking if one wants to save gnus properly first, is related.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#8134: (Some special files were saved without asking)
2011-03-05 12:20 ` jidanni
@ 2011-03-05 13:03 ` David Engster
0 siblings, 0 replies; 6+ messages in thread
From: David Engster @ 2011-03-05 13:03 UTC (permalink / raw)
To: jidanni; +Cc: 8134, schwab
'jidanni' writes:
> Also I bet C-x C-x not asking if one wants to save gnus properly first, is related.
You mean C-x C-c.
Yes, it's the same issue, but that was a kludge anyway. Gnus didn't say
"Hey, I'm still running, you sure you want to exit Emacs?". Instead it
just happened to have a changed file open and asked if you wanted to
save .newsrc-dribble.
-David
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-05 19:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-28 2:09 bug#8134: (Some special files were saved without asking) jidanni
2011-03-05 11:33 ` David Engster
2011-03-05 11:50 ` Andreas Schwab
2011-03-05 19:38 ` Chong Yidong
2011-03-05 12:20 ` jidanni
2011-03-05 13:03 ` David Engster
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).