From: Chong Yidong <cyd@stupidchicken.com>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: Dave Abrahams <dave@boostpro.com>, 8891@debbugs.gnu.org
Subject: bug#8891: 23.3; save-buffer messages about writing files that may not be written
Date: Sun, 03 Jul 2011 22:35:11 -0400 [thread overview]
Message-ID: <87hb724vts.fsf@stupidchicken.com> (raw)
In-Reply-To: <m339incdhq.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 03 Jul 2011 22:31:45 +0200")
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> Yes... until `save-buffer' calls `basic-save-buffer' which invokes
>> `write-file-functions', one of which decides to override the notion of
>> "modified-ness" when it ascertains that the contents have not actually
>> changed. So modp tells the truth at the time it's checked, but IMO it's
>> checked too early.
>
> Right. So perhaps `basic-save-buffer-2' is the right place to output
> the message? I've grepped through the .el files, and there doesn't seem
> to be any other callers other than the straight line down from
> `save-buffer'.
>
> Opinions, anybody?
I don't think it's worth changing.
next prev parent reply other threads:[~2011-07-04 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 16:50 bug#8891: 23.3; save-buffer messages about writing files that may not be written Dave Abrahams
2011-07-03 16:15 ` Lars Magne Ingebrigtsen
2011-07-03 20:26 ` Dave Abrahams
2011-07-03 20:31 ` Lars Magne Ingebrigtsen
2011-07-03 20:51 ` Dave Abrahams
2011-07-04 2:35 ` Chong Yidong [this message]
2011-07-04 12:19 ` Lars Magne Ingebrigtsen
2011-07-04 17:41 ` Chong Yidong
2011-07-04 20:36 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb724vts.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=8891@debbugs.gnu.org \
--cc=dave@boostpro.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).