unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: "Jan D." <jan.h.d@swipnet.se>
Cc: 9402@debbugs.gnu.org
Subject: bug#9402: list-colors-display
Date: Tue, 30 Aug 2011 12:10:51 +0300	[thread overview]
Message-ID: <87hb4zp8mc.fsf@mail.jurta.org> (raw)
In-Reply-To: <4E5C77CE.3000203@swipnet.se> (Jan D.'s message of "Tue, 30 Aug 2011 07:40:30 +0200")

> That is on purpose.  Say a user customizes a face to use
> gtk_selection_fg_color and saves it.  He then starts an Emacs compiled
> without Gtk+.  What color shall Emacs use then?

Exactly the same problem exists for all other conditional
face customizations.

What if a user customizes a face on X for min-colors 88 and starts Emacs on
a tty with 8 colors?  Or customizes a face to "color-255" on xterm-256color
and starts Emacs on X?  Or customizes a face for light background and
starts Emacs on dark background?  Or customizes a face for bold and starts
Emacs where bold is not supported?  And so on.

Of course, graceful degradation to some closer colors could help,
but the result would not be what the user has customized.

To avoid these problems, customize-face should retain the conditional
part of the face definition when saving the modified face.

So e.g. after customizing `region' to some other colors:

    (((class color) (min-colors 88) (background light) (type gtk))
     :foreground "white"
     :background "black")

And after restoring the original default colors the condition
will remain intact in `custom-set-faces':

    (((class color) (min-colors 88) (background light) (type gtk))
     :foreground "gtk_selection_fg_color"
     :background "gtk_selection_bg_color")





  reply	other threads:[~2011-08-30  9:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 19:27 bug#9402: list-colors-display Juri Linkov
2011-08-29 20:10 ` Eli Zaretskii
2011-08-29 21:17   ` Juri Linkov
2011-08-30  2:54     ` Eli Zaretskii
2011-08-30  5:40     ` Jan D.
2011-08-30  9:10       ` Juri Linkov [this message]
2011-08-30 11:41         ` Eli Zaretskii
2011-08-30 14:15           ` Andreas Schwab
2011-08-30 17:57             ` Eli Zaretskii
2011-08-30  7:44   ` Eli Zaretskii
2011-08-30 17:46     ` Eli Zaretskii
2011-08-31  9:35       ` Juri Linkov
2011-08-31 10:57         ` Eli Zaretskii
2011-08-31 16:17           ` Chong Yidong
2011-08-31 19:02             ` Jan Djärv
2011-09-01  2:12               ` Chong Yidong
2011-08-31 16:27           ` Juri Linkov
2011-08-31 17:40             ` Eli Zaretskii
2011-08-31 18:35               ` Juri Linkov
2011-08-31 19:22                 ` Jan Djärv
2011-08-31 20:14                   ` Eli Zaretskii
2011-08-31 20:28                     ` Juri Linkov
2011-09-01  2:54                       ` Eli Zaretskii
2011-08-31 21:07                     ` Jan Djärv
2011-09-01  2:56                       ` Eli Zaretskii
2011-09-01  2:15                     ` Chong Yidong
2011-09-01  3:07                       ` Eli Zaretskii
2011-08-31 19:17             ` Jan Djärv
2011-08-31 19:11           ` Jan Djärv
2011-08-31 20:00             ` Eli Zaretskii
2011-08-31 20:10               ` Juri Linkov
2011-09-01  2:50                 ` Eli Zaretskii
2011-09-01  8:36                   ` Juri Linkov
2011-09-01 10:06                     ` Eli Zaretskii
2011-08-31 21:06               ` Jan Djärv
2011-08-31 19:09         ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hb4zp8mc.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=9402@debbugs.gnu.org \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).