From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?J=C3=A9r=C3=A9my?= Compostella Newsgroups: gmane.emacs.bugs Subject: bug#10598: 24.0.92; run dired-do-async-shell-command on multiple files individually Date: Wed, 25 Jan 2012 23:48:51 +0100 Message-ID: <87hazjtn3g.fsf@Apollo.jerryland.fr> References: <87liow9jdf.fsf@niu.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1327531794 5147 80.91.229.12 (25 Jan 2012 22:49:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 25 Jan 2012 22:49:54 +0000 (UTC) To: 10598@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 25 23:49:50 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RqBf4-0006wp-Av for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2012 23:49:50 +0100 Original-Received: from localhost ([::1]:47878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqBf3-0005rB-Rq for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2012 17:49:49 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:44847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqBep-0005qP-Kg for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 17:49:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqBeo-0006zP-GT for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 17:49:35 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqBeo-0006zK-EW for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 17:49:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RqBfG-0001UI-AR for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 17:50:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87liow9jdf.fsf@niu.edu> Resent-From: =?UTF-8?Q?J=C3=A9r=C3=A9my?= Compostella Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2012 22:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10598 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10598-submit@debbugs.gnu.org id=B10598.13275317765671 (code B ref 10598); Wed, 25 Jan 2012 22:50:02 +0000 Original-Received: (at 10598) by debbugs.gnu.org; 25 Jan 2012 22:49:36 +0000 Original-Received: from localhost ([127.0.0.1]:44064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqBep-0001TN-Ru for submit@debbugs.gnu.org; Wed, 25 Jan 2012 17:49:36 -0500 Original-Received: from mail-we0-f172.google.com ([74.125.82.172]:43221) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqBeN-0001SK-Rb for 10598@debbugs.gnu.org; Wed, 25 Jan 2012 17:49:08 -0500 Original-Received: by werm10 with SMTP id m10so310501wer.3 for <10598@debbugs.gnu.org>; Wed, 25 Jan 2012 14:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=iRkBgEzS4Cl3yLCEEyq88vCWF6w/uRFLWCnlOGxP4Fg=; b=YVIM3uoCpEZcs1+Vo/Zl3ElW6ZZnvblr/bJC+RWgBqjmjtNByyPk5g1L+ATBQ/qXsK D9dCGW+Atgsd1JouO3IIU0Ms6deGrc6yPrxb5WYkzGff6GA7PCWv/lTfQgzlPiLO+9km /2rCgSf3LZYUROaIp8I3YorBEZZrlkdGg+5kw= Original-Received: by 10.180.103.97 with SMTP id fv1mr31646440wib.17.1327531713720; Wed, 25 Jan 2012 14:48:33 -0800 (PST) Original-Received: from Apollo.jerryland.fr ([85.69.251.50]) by mx.google.com with ESMTPS id di5sm6270422wib.3.2012.01.25.14.48.32 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 Jan 2012 14:48:33 -0800 (PST) X-Mailman-Approved-At: Wed, 25 Jan 2012 17:49:35 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Wed, 25 Jan 2012 17:49:47 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56010 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, This bug was really annoying me tonight so I wrote the attached patch which fix it by translating `gv foo.ps&;gv bar.ps&' to `gv foo.ps&gv bar.ps&'. I do agree it should be better to provide a way to choice between the sequential or parallel solution but I have no idea how to implement it in a clean fashion for now. Anyway, the current behavior looks buggy and I propose to merge the attached patch in a first time in order to have a acceptable behavior that is far better than an error. Best regards, J=C3=A9r=C3=A9my --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-dired-do-async-shell-command-on-multiple-files-i.patch Content-Description: Fix dired-do-async-shell-command on multiple files individually (bug#10598) patch >From aefc85c364f6e51676ffc9dc44deb9a4d43a128c Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Wed, 25 Jan 2012 23:38:54 +0100 Subject: [PATCH] Fix dired-do-async-shell-command on multiple files individually (bug#10598) The `dired-shell-stuff-it' should not insert the ";" shell command separator when called with a command argument ending with the "&" character. Signed-off-by: Jeremy Compostella --- lisp/dired-aux.el | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 2d05be3..74f0de9 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -659,7 +659,8 @@ can be produced by `dired-get-marked-files', for example." retval)) (lambda (x) (concat command dired-mark-separator x))))) (if on-each - (mapconcat stuff-it (mapcar 'shell-quote-argument file-list) ";") + (mapconcat stuff-it (mapcar 'shell-quote-argument file-list) + (if (string-match "[ \t]*&[ \t]*\\'" command) "" ";")) (let ((files (mapconcat 'shell-quote-argument file-list dired-mark-separator))) (if (> (length file-list) 1) -- 1.7.2.5 --=-=-=--