From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief Date: Wed, 22 Feb 2012 14:01:42 +0800 Message-ID: <87hayjl83d.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1329890580 3778 80.91.229.3 (22 Feb 2012 06:03:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 22 Feb 2012 06:03:00 +0000 (UTC) Cc: 10743@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 22 07:02:57 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S05I0-0003b7-72 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Feb 2012 07:02:56 +0100 Original-Received: from localhost ([::1]:52897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S05Hz-0005Rj-G6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Feb 2012 01:02:55 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:45235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S05Hr-0005RV-Qp for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2012 01:02:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S05Hm-000237-RQ for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2012 01:02:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S05Hm-000233-Mq for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2012 01:02:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S05K2-0007XO-0w for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2012 01:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2012 06:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10743 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10743-submit@debbugs.gnu.org id=B10743.132989066928930 (code B ref 10743); Wed, 22 Feb 2012 06:05:01 +0000 Original-Received: (at 10743) by debbugs.gnu.org; 22 Feb 2012 06:04:29 +0000 Original-Received: from localhost ([127.0.0.1]:49839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S05JR-0007WT-AJ for submit@debbugs.gnu.org; Wed, 22 Feb 2012 01:04:29 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:58885 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S05JE-0007Vy-As for 10743@debbugs.gnu.org; Wed, 22 Feb 2012 01:04:23 -0500 Original-Received: from [155.69.16.15] (port=57160 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S05Gv-0001tL-Ra; Wed, 22 Feb 2012 01:01:50 -0500 In-Reply-To: (YAMAMOTO Mitsuharu's message of "Tue, 07 Feb 2012 09:48:18 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57088 Archived-At: YAMAMOTO Mitsuharu writes: > The current code in x_draw_image_relief (in xterm.c) applies XINT to > Vtool_bar_button_margin without INTEGERP: > > 2326 extra = s->face->id == TOOL_BAR_FACE_ID > 2327 ? XINT (Vtool_bar_button_margin) : 0; > > Other than an integer, a cons of integers is also a valid value for > Vtool_bar_button_margin. Thanks. Fixed in trunk.