From: Chong Yidong <cyd@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 10743@debbugs.gnu.org
Subject: bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief
Date: Wed, 22 Feb 2012 14:01:42 +0800 [thread overview]
Message-ID: <87hayjl83d.fsf@gnu.org> (raw)
In-Reply-To: <wlehu7zcx9.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Tue, 07 Feb 2012 09:48:18 +0900")
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> The current code in x_draw_image_relief (in xterm.c) applies XINT to
> Vtool_bar_button_margin without INTEGERP:
>
> 2326 extra = s->face->id == TOOL_BAR_FACE_ID
> 2327 ? XINT (Vtool_bar_button_margin) : 0;
>
> Other than an integer, a cons of integers is also a valid value for
> Vtool_bar_button_margin.
Thanks. Fixed in trunk.
prev parent reply other threads:[~2012-02-22 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 0:48 bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief YAMAMOTO Mitsuharu
2012-02-22 6:01 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hayjl83d.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=10743@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).