From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 24 Feb 2012 21:33:26 +0100 Message-ID: <87haygx97t.fsf@gmx.de> References: <87mx9su32g.fsf@web.de> <871uqz651u.fsf@gmx.de> <87pqd89lh4.fsf@gmail.com> <87mx8b3nvb.fsf@gmail.com> <87pqd6wnvv.fsf@gmail.com> <87d395y1w0.fsf@gmail.com> <87zkc8x04p.fsf@gmail.com> <87vcmwwvk7.fsf@gmail.com> <834nugtwqf.fsf@gnu.org> <87r4xkwhky.fsf@gmail.com> <83vcmws3bs.fsf@gnu.org> <87ehtkwaiz.fsf@gmail.com> <87wr7cgsm3.fsf@gmx.de> <8762eww77b.fsf@gmail.com> <83pqd4roav.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330115677 3707 80.91.229.3 (24 Feb 2012 20:34:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Feb 2012 20:34:37 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Thierry Volpiatto To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 24 21:34:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S11qa-0001Bt-Jq for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 21:34:32 +0100 Original-Received: from localhost ([::1]:35172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11qZ-0000Y3-Q6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 15:34:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11qW-0000Xx-I9 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:34:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S11qV-0005HX-Ek for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:34:28 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11qU-0005HT-Vy for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:34:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S11sz-0002nm-SA for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2012 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.133011578010717 (code B ref 10489); Fri, 24 Feb 2012 20:37:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 24 Feb 2012 20:36:20 +0000 Original-Received: from localhost ([127.0.0.1]:54583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S11sJ-0002mn-7Z for submit@debbugs.gnu.org; Fri, 24 Feb 2012 15:36:20 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:48202) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1S11sG-0002ma-DS for 10489@debbugs.gnu.org; Fri, 24 Feb 2012 15:36:17 -0500 Original-Received: (qmail invoked by alias); 24 Feb 2012 20:33:34 -0000 Original-Received: from p57BB94C0.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.148.192] by mail.gmx.net (mp016) with SMTP; 24 Feb 2012 21:33:34 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/P1oAzFcnPvgMBp9mDxj+XpcoqH09xRiS8asBagW eaoOU8M/sO2tCd In-Reply-To: <83pqd4roav.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Feb 2012 22:04:08 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57196 Archived-At: Eli Zaretskii writes: >> From: Thierry Volpiatto >> Cc: Eli Zaretskii , 10489@debbugs.gnu.org >> Date: Fri, 24 Feb 2012 17:02:16 +0100 >> >> (defun files-equal-p (file1 file2) >> "Return non-nil if FILE1 and FILE2 name the same file." >> (let ((handler (or (find-file-name-handler file1 'files-equal-p) >> (find-file-name-handler file2 'files-equal-p)))) >> (if handler >> (funcall handler 'files-equal-p file1 file2) > > If FILE1 and FILE2 have different 'files-equal-p handlers, which one > of them, if any, should be invoked here? The one for FILE1. > IOW, shouldn't we invoke a file handler only if it can handle _both_ > files? Also, if each file has a different handler, doesn't that in > itself already mean the files are not equal? We shouldn't add too much to file name handler optimization here. The handler will know what to do. Likely, there won't be different handlers. It's always `tramp-file-name-handler', which calls the respective sub-handlers. Best regards, Michael.