From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Date: Thu, 19 Dec 2013 01:22:58 +0200 Organization: JURTA Message-ID: <87haa5agml.fsf@mail.jurta.org> References: <87vbz5zcxv.fsf@mail.jurta.org> <87mwkgay9s.fsf@mail.jurta.org> <877gbi94p9.fsf@mail.jurta.org> <87y53s9rfq.fsf@mail.jurta.org> <8761qoa653.fsf@mail.jurta.org> <87ob4fz2vn.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387409535 17419 80.91.229.3 (18 Dec 2013 23:32:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Dec 2013 23:32:15 +0000 (UTC) Cc: 16035@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 19 00:32:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VtQbA-0005WF-JH for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2013 00:32:16 +0100 Original-Received: from localhost ([::1]:41295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtQbA-0007dC-3b for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Dec 2013 18:32:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtQb2-0007c7-Ar for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2013 18:32:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtQaw-0008EA-C4 for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2013 18:32:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtQaw-0008E5-8L for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2013 18:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VtQav-0003me-K6 for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2013 18:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2013 23:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16035 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16035-submit@debbugs.gnu.org id=B16035.138740949314499 (code B ref 16035); Wed, 18 Dec 2013 23:32:01 +0000 Original-Received: (at 16035) by debbugs.gnu.org; 18 Dec 2013 23:31:33 +0000 Original-Received: from localhost ([127.0.0.1]:57847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtQaS-0003lm-Gy for submit@debbugs.gnu.org; Wed, 18 Dec 2013 18:31:32 -0500 Original-Received: from [69.163.184.122] (port=33202 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtQaP-0003ld-I2 for 16035@debbugs.gnu.org; Wed, 18 Dec 2013 18:31:30 -0500 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 38A1E301656F60; Wed, 18 Dec 2013 15:31:27 -0800 (PST) In-Reply-To: (Anders Lindgren's message of "Wed, 18 Dec 2013 09:02:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82197 Archived-At: > In other words, it appears to be working correctly! Glad to hear this is working correctly. Meanwhile, I found another problem: typing in Isearch while in the Gnus Summary buffer exits Isearch and runs `gnus-summary-prev-page' because is bound explicitly in Gnus. But in other buffers, in Isearch runs `isearch-delete-char'. So it requires an explicit binding in `isearch-mode-map': === modified file 'lisp/isearch.el' --- lisp/isearch.el 2013-12-16 20:32:15 +0000 +++ lisp/isearch.el 2013-12-18 23:12:31 +0000 @@ -446,6 +476,7 @@ (defvar isearch-mode-map (define-key map "\M-\C-s" 'isearch-repeat-forward) (define-key map "\M-\C-r" 'isearch-repeat-backward) (define-key map "\177" 'isearch-delete-char) + (define-key map [backspace] 'isearch-delete-char) (define-key map "\C-g" 'isearch-abort) BTW, this also reminded that preferable key bindings could be advertised with `advertised-binding', so I'm going to install also this change too: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2013-12-16 20:32:15 +0000 +++ lisp/isearch.el 2013-12-18 23:12:31 +0000 @@ -500,6 +536,15 @@ (defvar isearch-mode-map (define-key map "\M-r" 'isearch-toggle-regexp) (define-key map "\M-e" 'isearch-edit-string) + (put 'isearch-toggle-case-fold :advertised-binding "\M-sc") + (put 'isearch-toggle-regexp :advertised-binding "\M-sr") + (put 'isearch-edit-string :advertised-binding "\M-se") + + (define-key map "\M-se" 'isearch-edit-string) (define-key map "\M-sc" 'isearch-toggle-case-fold) (define-key map "\M-si" 'isearch-toggle-invisible) (define-key map "\M-sr" 'isearch-toggle-regexp)