unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Pål Grønås Drange" <paal.drange@gmail.com>, 20070@debbugs.gnu.org
Subject: bug#20070: 24.3; have commands such as downcase-region act on a rectangle region
Date: Sun, 15 Mar 2015 22:34:02 +0200	[thread overview]
Message-ID: <87h9tmov9h.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvmw3fo8hf.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Sat, 14 Mar 2015 12:31:08 -0400")

> Indeed, same problem as kill-region, to which I had to add a `region'
> argument (which basically says "we're called interactively so use
> whatever is the region rather than BEG and END").

Then maybe support for the rectangular region should be introduced
to every command by adding a new argument `region' with a list of pairs
((BEG1 . END1) (BEG2 . END2) ...) and keeping the existing arguments
BEG and END unchanged?

> Obviously, there will be many more commands that need to be adjusted to
> the extended notion of "region" which can now be composed of various extents.
> I'm not sure we need/want a new "R", because I think all cases of "r"
> are currently broken when the region is non contiguous (i.e. they all
> need to use "the new system").
>
> One way to handle it generically, is to change call-interactively such
> that when the argument is "r", the command is called once for each
> "extent".  Obviously, this won't work correctly for all cases, tho.

Also this won't work for commands that use region-beginning/region-end
in the interactive spec (like query-replace for bug#13178/bug#19829).

So while fixing the commands one by one, after fixing every command
it needs to be marked as "supporting the rectangular region".  If the
command used region-beginning and region-end, this means changing them to
e.g. plural region-beginnings and region-ends.

> Another option is to make "r" behave along the lines of your "R" (tho
> I much prefer a list of pairs than a pair of lists, so one of the two
> args would end up "useless").

Yes, the worst part of this feature is that commands should keep
two existing arguments BEG and END, and either add a new meaning to them,
(while supporting their current values as numbers for backward-compatibility),
or add a new optional argument.





  reply	other threads:[~2015-03-15 20:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  1:06 bug#20070: 24.3; have commands such as downcase-region act on a rectangle region Pål Grønås Drange
2015-03-11 20:28 ` Stefan Monnier
2015-03-12 19:23   ` Juri Linkov
2015-03-14 16:31     ` Stefan Monnier
2015-03-15 20:34       ` Juri Linkov [this message]
2015-03-15 20:41         ` Eli Zaretskii
2015-03-16 11:49           ` Nicolas Richard
2015-03-16 13:14           ` Stefan Monnier
2015-03-16 20:55           ` Juri Linkov
2015-03-16 22:07             ` Stefan Monnier
2015-03-16 13:19         ` Stefan Monnier
2015-03-16 20:58           ` Juri Linkov
2015-03-16 22:08             ` Stefan Monnier
2015-03-17 19:38               ` Juri Linkov
2015-03-25  0:37                 ` Stefan Monnier
2015-03-25 21:42                   ` Juri Linkov
2015-03-17  7:10             ` Eli Zaretskii
2015-06-30 20:44   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9tmov9h.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=20070@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=paal.drange@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).