From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#20590: mouse-highlight does not do as documented Date: Sat, 16 May 2015 22:06:02 +0200 Message-ID: <87h9rc479x.fsf@gnu.org> References: <83mw14fhjt.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1431806844 10222 80.91.229.3 (16 May 2015 20:07:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 May 2015 20:07:24 +0000 (UTC) Cc: 20590@debbugs.gnu.org, Samuel Wales To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 16 22:07:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YtiMZ-0006H5-Hy for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 May 2015 22:07:11 +0200 Original-Received: from localhost ([::1]:35429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtiMY-0002Cj-TA for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 May 2015 16:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtiMU-0002Ce-QR for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 16:07:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtiMQ-00009O-P3 for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 16:07:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtiMQ-00008C-Lc for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 16:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YtiMQ-0005Ez-2M for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 16:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 May 2015 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20590 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20590-submit@debbugs.gnu.org id=B20590.143180677420082 (code B ref 20590); Sat, 16 May 2015 20:07:01 +0000 Original-Received: (at 20590) by debbugs.gnu.org; 16 May 2015 20:06:14 +0000 Original-Received: from localhost ([127.0.0.1]:47505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtiLd-0005Dq-E9 for submit@debbugs.gnu.org; Sat, 16 May 2015 16:06:13 -0400 Original-Received: from smtprelay-h31.telenor.se ([213.150.131.4]:54511) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtiLb-0005Db-HA for 20590@debbugs.gnu.org; Sat, 16 May 2015 16:06:12 -0400 Original-Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id 82657D803 for <20590@debbugs.gnu.org>; Sat, 16 May 2015 22:06:05 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.228.195.118] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2A9BwBSoldVPHbD5FVcgxCBJQ2GTMVyAoEdPRABAQEBAQEBBgEBAQFBP4QiAQEBAQIBJy8jEAsUAQwlDwEEDQsBDAoaE4gXAwoMAdFaDYUKAQEBAQEFAQEBAR6LOoJNgjgHhC0FnAqRZ4Z6gi0cgVQ8MYJGAQEB X-IPAS-Result: A2A9BwBSoldVPHbD5FVcgxCBJQ2GTMVyAoEdPRABAQEBAQEBBgEBAQFBP4QiAQEBAQIBJy8jEAsUAQwlDwEEDQsBDAoaE4gXAwoMAdFaDYUKAQEBAQEFAQEBAR6LOoJNgjgHhC0FnAqRZ4Z6gi0cgVQ8MYJGAQEB X-IronPort-AV: E=Sophos;i="5.13,442,1427752800"; d="scan'208";a="228707063" Original-Received: from c-76c3e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.195.118]) by ipb2.telenor.se with ESMTP; 16 May 2015 22:06:05 +0200 Original-Received: by muon.localdomain (Postfix, from userid 1000) id 1B0DC484217; Sat, 16 May 2015 22:06:02 +0200 (CEST) Mail-Copies-To: never In-Reply-To: <83mw14fhjt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 May 2015 22:28:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102891 Archived-At: Eli Zaretskii writes: >> Date: Sat, 16 May 2015 11:09:33 -0700 >> From: Samuel Wales >> >> mouse-highlight does not do as documented, which seems to be a bug. >> >> i confirmed with emacs -Q. i did not find a similar bug report. >> >> === >> >> "If the value is an integer, highlighting is only shown >> after moving the mouse, while keyboard input turns off the >> highlight even when the mouse is over the clickable text." >> >> in my usage, highlighting shows when mouse has not moved. >> it also shows when there is keyboard input. > > I cannot reproduce this. You didn't show a precise recipe you used, > so here's mine: > > . emacs -Q > . C-h v mouse-highlight RET > . move the mouse pointer above the hyper-link labeled "C source code" > and observe the highlight > . type some character -- the highlight stays on > . M-x set-variable RET mouse-highlight RET 1 RET > . type some character -- the highlight goes off > . move the mouse pointer a bit -- the highlight goes on > > So the highlight behaves as documented for me. > > For the record, I tried both Emacs 24.4, which is what you seem to > have, and the latest development sources. The problem was introduced by commit 742516e02048d3bbfba4e6e13dd19afa097bbd3b Author: Dmitry Antipov Date: Wed Sep 11 12:56:33 2013 +0400 Ifdef away frame tool bar code when it is not really used. ... The bug does not exist on Windows. I think this should fix it: diff --git a/src/xterm.c b/src/xterm.c index d9032fa..0537491 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -7056,17 +7056,18 @@ handle_one_xevent (struct x_display_info *dpyinfo, f = any; -#if ! defined (USE_GTK) /* If mouse-highlight is an integer, input clears out mouse highlighting. */ if (!hlinfo->mouse_face_hidden && INTEGERP (Vmouse_highlight) +#if ! defined (USE_GTK) && (f == 0 - || !EQ (f->tool_bar_window, hlinfo->mouse_face_window))) + || !EQ (f->tool_bar_window, hlinfo->mouse_face_window)) +#endif + ) { clear_mouse_face (hlinfo); hlinfo->mouse_face_hidden = true; } -#endif #if defined USE_MOTIF && defined USE_TOOLKIT_SCROLL_BARS if (f == 0)