From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jens Lechtenboerger Newsgroups: gmane.emacs.bugs Subject: bug#18718: Encrypted messages expose Bcc identities Date: Sun, 27 Dec 2015 21:09:17 +0100 Message-ID: <87h9j37ixe.fsf@informationelle-selbstbestimmung-im-internet.de> References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> <87h9j3eoif.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1451247022 20133 80.91.229.3 (27 Dec 2015 20:10:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 20:10:22 +0000 (UTC) Cc: 18718@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 27 21:10:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDHdq-0003u3-Qy for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 21:10:10 +0100 Original-Received: from localhost ([::1]:42601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDHdp-00016L-Ur for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 15:10:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDHdl-00015H-Fi for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 15:10:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDHdi-0006xM-8H for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 15:10:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDHdi-0006x5-4f for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 15:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDHdi-00043h-1B; Sun, 27 Dec 2015 15:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jens Lechtenboerger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 27 Dec 2015 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18718 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: security Original-Received: via spool by 18718-submit@debbugs.gnu.org id=B18718.145124696815556 (code B ref 18718); Sun, 27 Dec 2015 20:10:01 +0000 Original-Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 20:09:28 +0000 Original-Received: from localhost ([127.0.0.1]:44832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHdA-00042q-HA for submit@debbugs.gnu.org; Sun, 27 Dec 2015 15:09:28 -0500 Original-Received: from mx1.mailbox.org ([80.241.60.212]:50181) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHd8-00042c-NY for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 15:09:27 -0500 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 9239042218; Sun, 27 Dec 2015 21:09:20 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id VyJi6dGYaFKP; Sun, 27 Dec 2015 21:09:19 +0100 (CET) OpenPGP: id=0xA142FD84; url=http://www.informationelle-selbstbestimmung-im-internet.de/A142FD84.asc In-Reply-To: <87h9j3eoif.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 27 Dec 2015 19:26:48 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110837 Archived-At: --=-=-= Content-Type: text/plain On 2015-12-27, at 19:26, Lars Ingebrigtsen wrote: > Jens Lechtenboerger writes: > >> A patch is attached. The new function mml-secure-bcc-is-safe does >> nothing on its own but can be added to message-send-hook or called >> from message-send and friends. > > I've applied the patch, but there were bugs. It referred to an unbound > variable called "hdr", which I've changed to bcc. Please look over the > resulting code. You are right. I tested against the wrong load-path. Sorry. > Also, I get these warnings: > > In end of data: > gnus/mml-sec.el:429:1:Warning: the following functions are not known to be > defined: mail-strip-quoted-names, message-fetch-field, gnus-subsetp Indeed. Actually, when should I use require, when autoload? In particular, for gnus-util both variants are used in different files, and I fail to see a pattern. As mml-sec just uses autoloads, the attached patch adds more of them to avoid the warnings. Best wishes Jens --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-More-autoloads-to-avoid-compile-warnings.patch >From 1f54b417fd487880f794cfff2eecceb87a07d4d8 Mon Sep 17 00:00:00 2001 From: Jens Lechtenboerger Date: Sun, 27 Dec 2015 20:40:15 +0100 Subject: [PATCH 2/2] More autoloads to avoid compile warnings --- lisp/gnus/mml-sec.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index dbae280..d7702d7 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -25,10 +25,13 @@ (eval-when-compile (require 'cl)) +(autoload 'gnus-subsetp "gnus-util") +(autoload 'mail-strip-quoted-names "mail-utils") (autoload 'mml2015-sign "mml2015") (autoload 'mml2015-encrypt "mml2015") (autoload 'mml1991-sign "mml1991") (autoload 'mml1991-encrypt "mml1991") +(autoload 'message-fetch-field "message") (autoload 'message-goto-body "message") (autoload 'mml-insert-tag "mml") (autoload 'mml-smime-sign "mml-smime") -- 1.9.1 --=-=-=--