From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 23967@debbugs.gnu.org
Subject: bug#23967: 25.1.50; Slow compilation of ns-win.el
Date: Sat, 16 Jul 2016 13:03:17 -0400 [thread overview]
Message-ID: <87h9bpecru.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83vb065bhd.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jul 2016 09:43:42 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: npostavs@users.sourceforge.net
>> Cc: 23967@debbugs.gnu.org, larsi@gnus.org
>> Date: Fri, 15 Jul 2016 22:46:12 -0400
>>
>> I finished writing the tests. It does pass with
>> http://www.unicode.org/Public/5.2.0/ucd/NormalizationTest.txt as was
>> claimed in the ucs-normalize.el file (except that some of the rule 2
>> tests fail with that version, but that's only because version 5.2.0 has
>> less code points listed in Part 1).
>>
>> Here are the patches, first adds the test (I elided the content of
>> NormalizationTest.txt to save space), second is the optimization (same
>> as before, except I dropped the change from mapc to dolist, because some
>> benchmark-runs showed me that mapc is significantly faster when not
>> compiled).
>
> Thanks. Please push this to master, and please also mention
> NormalizationTest.txt in admin/notes/unicode, as one more file that
> needs to be imported from each new Unicode standard, followed by
> running this particular test, to verify compliance.
Pushed as e333157, eed3b46.
next prev parent reply other threads:[~2016-07-16 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 12:19 bug#23967: 25.1.50; Slow compilation of ns-win.el Lars Ingebrigtsen
2016-07-13 14:55 ` Eli Zaretskii
2016-07-13 21:15 ` Noam Postavsky
2016-07-14 14:54 ` Eli Zaretskii
2016-07-15 3:22 ` npostavs
2016-07-15 7:21 ` Eli Zaretskii
2016-07-16 2:46 ` npostavs
2016-07-16 6:43 ` Eli Zaretskii
2016-07-16 17:03 ` npostavs [this message]
2016-07-16 17:20 ` Lars Ingebrigtsen
2016-07-17 16:20 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9bpecru.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=23967@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).