From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: nljlistbox2@gmail.com (N. Jackson) Newsgroups: gmane.emacs.bugs Subject: bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out Date: Thu, 21 Jul 2016 04:52:42 -0300 Message-ID: <87h9bj2zsl.fsf_-_@moondust.awandering> References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1469087614 16859 80.91.229.3 (21 Jul 2016 07:53:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 07:53:34 +0000 (UTC) Cc: 23917@debbugs.gnu.org, Robert Pluim , Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 21 09:53:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQ8nK-0007BR-1Z for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 09:53:22 +0200 Original-Received: from localhost ([::1]:38796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ8nI-0000Fk-SZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 03:53:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ8nA-0000Dd-6S for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 03:53:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ8n8-0001zE-1u for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 03:53:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ8n0-0001yj-Pz; Thu, 21 Jul 2016 03:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQ8n0-0005Ur-Bp; Thu, 21 Jul 2016 03:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: nljlistbox2@gmail.com (N. Jackson) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Thu, 21 Jul 2016 07:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146908757121113 (code B ref 23917); Thu, 21 Jul 2016 07:53:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 21 Jul 2016 07:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:59257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ8mp-0005US-CC for submit@debbugs.gnu.org; Thu, 21 Jul 2016 03:52:51 -0400 Original-Received: from mail-io0-f194.google.com ([209.85.223.194]:34420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ8mo-0005UG-00 for 23917@debbugs.gnu.org; Thu, 21 Jul 2016 03:52:50 -0400 Original-Received: by mail-io0-f194.google.com with SMTP id g86so4955909ioj.1 for <23917@debbugs.gnu.org>; Thu, 21 Jul 2016 00:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=0NMYrpcWpSUHeyHqDuOaRNhvJOwuAKOwUWZRqcSeh9k=; b=H+IQjr4K/jYG7zJb18iTDfEMHArgTi/aEIZFQZ42pFC9rMSUeMk0Gl/Dl1aHE+QMPF O+PZO3tm/z9LKI98iE/kD2TMI4oxBi1xPomt82x8gyHA1D674Q3+H4L/WPJ/j15hy6yO dmtLAXqSHQJu117JtBOOgO8KQb4GIWJsCRwSMAIUFDT/Ll58bFrCzYiKkgcCMSzkUJkI 4omdC+LoG973atCNJ35hjOcdeAOESur9/NCgHZm+ptq3mBEfNCwJCZOEj67xFbLs5DBs z0XX2Y4duDDTsnZnaVVJz5NqxiRAmZpgGe08eLthvy6o2Uii80+BLfs/bLTDeY/kAqUN JwHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0NMYrpcWpSUHeyHqDuOaRNhvJOwuAKOwUWZRqcSeh9k=; b=X8vWpjhVa0+AFc6tgLPGafOSqMebBJR1tUDmqt9HpWaDL5xnBnj7MpODvOM7rb0QAg oatKR7qPH0Vz6HJIabwhMD/Bvd/fWtFD2bA+jZ2WVs9LgezFqfWUCscGBY6t1zKunq+h IpV6UnBgjEFHe+o4hLvR8tSs4yUsNLmmVqpsXyhm2MdLoA6iUwhtBFK1JWcHtxmf+GS1 Y5WPzr3+Pm3RKZB5UTC4nZmW6PIRVF3i9Lc8KmveZrY9DuojcesYYLUBK9gG0jbmawDL YrfnR+LGni0x7tqOUj5pYXN4ptxDdN7tTmCoSCw0kvnjPZG7oTij/IrN5GeBAg4hJyZR 2Q2Q== X-Gm-Message-State: ALyK8tLKAd3RUnbLO0EhTEXwkErBGiZGjkijfXfGGIAbv2iwARFNvEgZFtQ27jOHzxPNiw== X-Received: by 10.107.201.138 with SMTP id z132mr49676115iof.156.1469087564270; Thu, 21 Jul 2016 00:52:44 -0700 (PDT) Original-Received: from moondust.nodomain.none (blk-138-64-179.eastlink.ca. [24.138.64.179]) by smtp.gmail.com with ESMTPSA id o15sm1149681ith.2.2016.07.21.00.52.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jul 2016 00:52:43 -0700 (PDT) In-Reply-To: <83lh0y24y6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Jul 2016 21:09:53 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121363 Archived-At: At 21:09 +0300 on Monday 2016-07-18, Eli Zaretskii wrote: > My suggestion to fix this is below. I ask for opinions on (1) whether > this looks like TRT, (2) whether it is safe enough for emacs-25, and > (3) whether someone has better ideas. If someone thinks I've > misunderstood the issue, don't hesitate to explain why, because > frankly it feels very strange to find bugs that seem to have existed > since 1990. > > diff --git a/lisp/subr.el b/lisp/subr.el > index e9e19d3..1bb1cb3 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -3466,7 +3466,7 @@ save-match-data > ;; if you need to recompile all the Lisp files using interpreted code. > (declare (indent 0) (debug t)) > (list 'let > - '((save-match-data-internal (match-data))) > + '((save-match-data-internal (match-data 'integers))) > (list 'unwind-protect > (cons 'progn body) > ;; It is safe to free (evaporate) markers immediately here, FWIW on my system applying this patch does not resolve the org-capture issue. I'm testing with org-20160718 from GNU Elpa and latest Emacs 25 branch from the git (Repository revision: 4157159a37b43712440da91a45a6d5f71= eb96e8a). With these versions of Org and Emacs and your patch applied, with a recipe similar to that posted by Robert Pluim on 2016-07-18, specifically src/emacs -Q M-: (custom-set-variables '(package-selected-packages (quote (org-2016071= 8)))) RET M-x package-initialize RET C-x C-f ; find file. C-S-backspace ; kill-whole-line. ~/.notes RET ; Open the file expected by default capture template. M-x org-mode RET ; put the buffer into Org Mode. M-x org-capture RET t ; Run the default "Task" capture template bound to = the t key. I get the error:=20 org-capture: Capture template =E2=80=98t=E2=80=99: Match data clobbered b= y buffer modification hooks . I also get a similar error with your patch and my full configuration loaded and using my own capture templates: org-capture: Capture abort: (error Match data clobbered by buffer modific= ation hooks) . The results above are same as I get if I do not apply your patch. [On the other hand, with the same version of Org as above and Emacs from the 25.0.95 tarball, I do not see these error.]