From: jca@wxcvbn.org (Jérémie Courrèges-Anglas)
To: 24082@debbugs.gnu.org
Subject: bug#24082: 25.1; vc-dir for CVS repositories list all files as if from toplevel directory
Date: Sat, 08 Oct 2016 17:13:27 +0200 [thread overview]
Message-ID: <87h98mzxew.fsf@ritchie.wxcvbn.org> (raw)
In-Reply-To: <0ad0b9e3-b4d6-b162-05fe-8800a0bb8aff@yandex.ru> (Dmitry Gutov's message of "Sat, 8 Oct 2016 03:38:14 +0300")
[-- Attachment #1: Type: text/plain, Size: 3149 bytes --]
Dmitry Gutov <dgutov@yandex.ru> writes:
> Hi!
Hi,
> On 07.10.2016 17:45, Jérémie Courrèges-Anglas wrote:
>>
>> I see this regression using 25.1 (tarball) and emacs-26.0.50 (git).
>>
>> Reverting
>>
>> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/vc-cvs.el?id=fa7f79e8234c60ae425f7c3cf1b9486765a7111e
>>
>> fixes the problem here.
>
> I wonder how that could be possible: reverting it gives me a characterp
> error. But if you mean just replacing `files' with `dir', that seems to
> work, at the cost of possible performance overhead with larger
> repositories.
Oops, sorry. Yes indeed, I only replaced `files' with `dir'.
> Could you try the more complex patch that has been posted here? You can
> view it at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24082#15.
>
> In particular, I'd like to know whether it fixes this bug for you,
It does.
> and
> whether it works well with all CVS repositories you work with.
Works fine, there are some differences.
With just `files' replaced with `dir':
--8<--
VC backend : CVS
Working dir: /usr/ports/editors/
Repository : /cvs
Module : ports/editors
./
emacs/
edited emacs/Makefile
edited emacs/distinfo
emacs/patches/
edited emacs/patches/patch-Makefile_in
edited emacs/patches/patch-configure
removed emacs/patches/patch-src_unexelf_c
emacs/pkg/
edited emacs/pkg/PFRAG.no-no_x11
edited emacs/pkg/PLIST
-->8--
With the patch in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24082#15:
--8<--
VC backend : CVS
Working dir: /usr/ports/editors/
Repository : /cvs
Module : ports/editors
./
unregistered .//emacs-wip
emacs/
edited .//emacs/Makefile
edited .//emacs/distinfo
emacs/patches/
edited .//emacs/patches/patch-Makefile_in
edited .//emacs/patches/patch-configure
unregistered .//emacs/patches/patch-lisp_vc_vc-cvs_el
unregistered .//emacs/patches/patch-lisp_vc_vc_el
removed .//emacs/patches/patch-src_unexelf_c
emacs/pkg/
edited .//emacs/pkg/PFRAG.no-no_x11
edited .//emacs/pkg/PLIST
-->8--
So the patched version shows unregistered files and directories, which
is good, but has formatting artifacts (`.//' above). Also, pressing `='
on `.//emacs-wip', I get the following in *Messages*:
...
Traversing directory /usr/ports/editors/...done
Finding changes in /usr/ports/editors/emacs-wip...
vc-find-backend-function: Cannot open load file: No such file or directory, vc-nil
even though the directory contains a CVS dir, and cvs(1) works fine in
it. I don't think it's a big problem though.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-10-08 15:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 20:02 bug#24082: 25.1; vc-dir for CVS repositories list all files as if from toplevel directory Göktuğ Kayaalp
2016-07-30 0:35 ` bug#24082: vc-dir changes working directory (git backend) Steve Revilak
2016-10-06 23:32 ` Dmitry Gutov
2016-08-28 20:17 ` bug#24082: [PATCH] Use ‘cvs update’ instead ‘cvs status’ for CVS *vc-dir* buffers Göktuğ Kayaalp
2016-10-06 23:25 ` Dmitry Gutov
2016-10-07 19:29 ` Göktuğ Kayaalp
2016-10-08 1:01 ` Dmitry Gutov
2016-10-08 1:04 ` Dmitry Gutov
2016-10-12 0:59 ` Dan Nicolaescu
2016-10-13 18:10 ` Göktuğ Kayaalp
2016-10-22 1:34 ` Dan Nicolaescu
2016-10-05 18:31 ` bug#24082: Update Göktuğ Kayaalp
2016-10-05 18:33 ` Eli Zaretskii
2016-10-07 14:45 ` bug#24082: 25.1; vc-dir for CVS repositories list all files as if from toplevel directory Jérémie Courrèges-Anglas
2016-10-08 0:38 ` Dmitry Gutov
2016-10-08 15:13 ` Jérémie Courrèges-Anglas [this message]
2016-10-08 20:06 ` Dmitry Gutov
2016-10-09 12:18 ` Göktuğ Kayaalp
2016-10-10 23:55 ` Dmitry Gutov
2016-10-11 2:09 ` Göktuğ Kayaalp
2016-10-11 7:51 ` Andreas Schwab
2016-10-11 8:51 ` Dmitry Gutov
2016-10-11 15:48 ` Göktuğ Kayaalp
2016-10-10 16:41 ` Jérémie Courrèges-Anglas
2016-10-13 18:47 ` Göktuğ Kayaalp
2016-10-14 20:33 ` Jérémie Courrèges-Anglas
2016-10-15 12:36 ` Dmitry Gutov
2016-10-15 13:20 ` Göktuğ Kayaalp
2016-10-15 14:06 ` Jérémie Courrèges-Anglas
2016-10-15 17:26 ` Göktuğ Kayaalp
2016-10-15 21:36 ` Dmitry Gutov
2016-10-16 0:03 ` Göktuğ Kayaalp
2016-10-16 12:38 ` Jérémie Courrèges-Anglas
2016-10-16 14:07 ` Dmitry Gutov
2016-10-16 14:23 ` Eli Zaretskii
2016-10-16 15:58 ` Dmitry Gutov
2016-10-16 17:58 ` Eli Zaretskii
2016-10-18 0:04 ` Dmitry Gutov
2016-10-18 17:35 ` Göktuğ Kayaalp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h98mzxew.fsf@ritchie.wxcvbn.org \
--to=jca@wxcvbn.org \
--cc=24082@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).