* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers @ 2016-11-05 10:04 Tino Calancha 2016-11-05 10:17 ` Eli Zaretskii 2016-11-22 6:30 ` Tino Calancha 0 siblings, 2 replies; 12+ messages in thread From: Tino Calancha @ 2016-11-05 10:04 UTC (permalink / raw) To: 24880 I miss in this package a command to unmark all buffers bound to 'U'. How about the following? ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; From 1b7ff2820bd9e342a9f27c645fe961c06afaefc8 Mon Sep 17 00:00:00 2001 From: Tino Calancha <tino.calancha@gmail.com> Date: Sat, 5 Nov 2016 18:58:33 +0900 Subject: [PATCH] buff-menu: Command to unmark all buffers * lisp/emacs-lisp/tabulated-list.el (tabulated-list-header-overlay-p): New predicate; return non-nil if tabulated-list has a fake header. * lisp/buff-menu.el (Buffer-menu-unmark-all): New command; cancel all requested operations on buffers. Bind it to 'U'. --- lisp/buff-menu.el | 13 +++++++++++++ lisp/emacs-lisp/tabulated-list.el | 6 ++++++ 2 files changed, 19 insertions(+) diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..e920382 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -121,6 +121,7 @@ Buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "U" 'Buffer-menu-unmark-all) (define-key map "m" 'Buffer-menu-mark) (define-key map "t" 'Buffer-menu-visit-tags-table) (define-key map "%" 'Buffer-menu-toggle-read-only) @@ -356,6 +357,18 @@ Buffer-menu-unmark (Buffer-menu--unmark) (forward-line (if backup -1 1))) +(defun Buffer-menu-unmark-all () + "Cancel all requested operations on buffers." + (interactive) + (save-excursion + (goto-char (point-min)) + (when (tabulated-list-header-overlay-p) + (forward-line)) + (while (not (eobp)) + (unless (string= "." (aref (tabulated-list-get-entry) 0)) + (tabulated-list-set-col 0 " " t)) + (forward-line)))) + (defun Buffer-menu-backup-unmark () "Move up and cancel all requested operations on buffer on line above." (interactive) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 00b029d..2757feb 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -257,6 +257,12 @@ tabulated-list-print-fake-header (make-overlay (point-min) (point)))) (overlay-put tabulated-list--header-overlay 'face 'underline)))) +(defsubst tabulated-list-header-overlay-p (&optional pos) + "Return non-nil if there is a fake header. +Optional arg POS is a buffer position where to look for a fake header; +defaults to `point-min'." + (overlays-at (or pos (point-min)))) + (defun tabulated-list-revert (&rest ignored) "The `revert-buffer-function' for `tabulated-list-mode'. It runs `tabulated-list-revert-hook', then calls `tabulated-list-print'." -- 2.10.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-05 built on calancha-pc Repository revision: f95bf3cd1f55cf8f99b88c7318c21c967b11dfd1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-05 10:04 bug#24880: 26.0.50; buff-menu: Command to unmark all buffers Tino Calancha @ 2016-11-05 10:17 ` Eli Zaretskii 2016-11-06 12:21 ` Tino Calancha 2016-11-22 6:30 ` Tino Calancha 1 sibling, 1 reply; 12+ messages in thread From: Eli Zaretskii @ 2016-11-05 10:17 UTC (permalink / raw) To: Tino Calancha; +Cc: 24880 > From: Tino Calancha <tino.calancha@gmail.com> > Date: Sat, 05 Nov 2016 19:04:15 +0900 > > I miss in this package a command to unmark all buffers bound to 'U'. > How about the following? No objections from me, but please add suitable changes to NEWS and the user manual. Also, wrt this: > * lisp/buff-menu.el (Buffer-menu-unmark-all): > New command; cancel all requested operations on buffers. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I'd suggest to say "remove all flags from all the lines" instead, as it describes better what is being done. Thanks. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-05 10:17 ` Eli Zaretskii @ 2016-11-06 12:21 ` Tino Calancha 2016-11-06 17:22 ` Drew Adams 2016-11-07 18:38 ` Eli Zaretskii 0 siblings, 2 replies; 12+ messages in thread From: Tino Calancha @ 2016-11-06 12:21 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 24880, Tino Calancha Eli Zaretskii <eliz@gnu.org> writes: >> From: Tino Calancha <tino.calancha@gmail.com> >> Date: Sat, 05 Nov 2016 19:04:15 +0900 >> >> I miss in this package a command to unmark all buffers bound to 'U'. >> How about the following? > > No objections from me, but please add suitable changes to NEWS and the > user manual. > > Also, wrt this: > >> * lisp/buff-menu.el (Buffer-menu-unmark-all): >> New command; cancel all requested operations on buffers. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > I'd suggest to say "remove all flags from all the lines" instead, as > it describes better what is being done. Done. Thank you! I realized that `bs.el' and `ebuff-menu.el' can also benefit for a command unmarking all; so i have included them in the patch. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; From a84c5962f1300c8d858087ebf8fe356beb7586fb Mon Sep 17 00:00:00 2001 From: Tino Calancha <tino.calancha@gmail.com> Date: Sun, 6 Nov 2016 21:18:17 +0900 Subject: [PATCH] buff-menu: Add command to unmark all buffers Bind 'U' in buff-menu, bs and electric-buff-menu to commands to unmark all buffers (Bug#24880). * lisp/emacs-lisp/tabulated-list.el (tabulated-list-header-overlay-p): New predicate; return non-nil if tabulated-list has a fake header. * lisp/buff-menu.el (Buffer-menu-unmark-all): New command; remove all flags from all the lines. Bind it to 'U'. (Buffer-menu-mode-map): Update menus. (Buffer-menu-mode): Update mode doc. * lisp/bs.el (bs-unmark-all, bs-unmark-previous): New commands. (bs-mode-map): Bind them to 'U' and '<backspace>' respectively. (bs-mode): Update mode doc. * lisp/ebuff-menu.el (electric-buffer-menu-mode-map): Bind Buffer-menu-unmark-all to 'U'. (electric-buffer-list): Update mode doc. * doc/emacs/buffers.texi (Several Buffers): Mention Buffer-menu-unmark-all. ; * etc/NEWS: Add an entry per each new feature. --- doc/emacs/buffers.texi | 6 ++++++ etc/NEWS | 16 ++++++++++++++++ lisp/bs.el | 33 +++++++++++++++++++++++++++++++++ lisp/buff-menu.el | 17 +++++++++++++++++ lisp/ebuff-menu.el | 2 ++ lisp/emacs-lisp/tabulated-list.el | 6 ++++++ 6 files changed, 80 insertions(+) diff --git a/doc/emacs/buffers.texi b/doc/emacs/buffers.texi index 2eb837f..beb23df 100644 --- a/doc/emacs/buffers.texi +++ b/doc/emacs/buffers.texi @@ -413,6 +413,12 @@ Several Buffers (@code{Buffer-menu-backup-unmark}). @end table +@item U +@findex Buffer-menu-unmark-all +@kindex U @r{(Buffer Menu)} +Remove all flags from all the lines +(@code{Buffer-menu-unmark-all}). + @noindent The commands for adding or removing flags, @kbd{d}, @kbd{C-d}, @kbd{s} and @kbd{u}, all accept a numeric argument as a repeat count. diff --git a/etc/NEWS b/etc/NEWS index 4bf5332..6c9bca0 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -259,6 +259,22 @@ the file's actual content before prompting the user. \f * Changes in Specialized Modes and Packages in Emacs 26.1 +** Electric-Buffer-menu + +--- +*** Key 'U' is bound to 'Buffer-menu-unmark-all'. + +** bs + +--- +*** Two new commands 'bs-unmark-all', bound to 'U', and +'bs-unmark-previous', bound to <backspace>. + +** Buffer-menu + +--- +*** A new command 'Buffer-menu-unmark-all'; bound to 'U'. + ** Ibuffer --- diff --git a/lisp/bs.el b/lisp/bs.el index 8351169..f5f4436 100644 --- a/lisp/bs.el +++ b/lisp/bs.el @@ -491,6 +491,8 @@ bs-mode-map (define-key map "t" 'bs-visit-tags-table) (define-key map "m" 'bs-mark-current) (define-key map "u" 'bs-unmark-current) + (define-key map "U" 'bs-unmark-all) + (define-key map "\177" 'bs-unmark-previous) (define-key map ">" 'scroll-right) (define-key map "<" 'scroll-left) (define-key map "?" 'bs-help) @@ -635,6 +637,8 @@ bs-mode \\[bs-clear-modified] -- clear modified-flag on that buffer. \\[bs-mark-current] -- mark current line's buffer to be displayed. \\[bs-unmark-current] -- unmark current line's buffer to be displayed. +\\[bs-unmark-all] -- unmark all buffer lines. +\\[bs-unmark-previous] -- unmark previous line's buffer to be displayed. \\[bs-show-sorted] -- display buffer list sorted by next sort aspect. \\[bs-set-configuration-and-refresh] -- ask user for a configuration and \ apply selected configuration. @@ -882,6 +886,35 @@ bs-unmark-current (lambda (buf) (setq bs--marked-buffers (delq buf bs--marked-buffers))))) +(defun bs-unmark-previous (count) + "Unmark previous COUNT buffers. +Move cursor vertically up COUNT lines." + (interactive "p") + (when (natnump count) + (setq count (- count))) + (forward-line count) + (save-excursion + (bs-unmark-current (- count)))) + +(defun bs-unmark-all () + "Unmark all buffers." + (interactive) + (let ((marked (string-to-char bs-string-marked)) + (current (string-to-char bs-string-current)) + (marked-cur (string-to-char bs-string-current-marked)) + (unmarked (string-to-char bs-string-show-normally)) + (inhibit-read-only t)) + (save-excursion + (goto-char (point-min)) + (forward-line 2) + (while (not (eobp)) + (if (eq (char-after) marked) + (subst-char-in-region (point) (1+ (point)) marked unmarked) + (when (eq (char-after) marked-cur) + (subst-char-in-region (point) (1+ (point)) marked-cur current))) + (forward-line 1)) + (setq bs--marked-buffers nil)))) + (defun bs--show-config-message (what) "Show message indicating the new showing status WHAT. WHAT is a value of nil, `never', or `always'." diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..87aab71 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -121,6 +121,7 @@ Buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "U" 'Buffer-menu-unmark-all) (define-key map "m" 'Buffer-menu-mark) (define-key map "t" 'Buffer-menu-visit-tags-table) (define-key map "%" 'Buffer-menu-toggle-read-only) @@ -197,6 +198,9 @@ Buffer-menu-mode-map (bindings--define-key menu-map [umk] '(menu-item "Unmark" Buffer-menu-unmark :help "Cancel all requested operations on buffer on this line and move down")) + (bindings--define-key menu-map [umka] + '(menu-item "Unmark all" Buffer-menu-unmark-all + :help "Cancel all requested operations on buffers")) (bindings--define-key menu-map [mk] '(menu-item "Mark" Buffer-menu-mark :help "Mark buffer on this line for being displayed by v command")) @@ -239,6 +243,7 @@ Buffer-menu-mode \\[Buffer-menu-execute] Delete or save marked buffers. \\[Buffer-menu-unmark] Remove all marks from current line. With prefix argument, also move up one line. +\\[Buffer-menu-unmark-all] Remove all marks from all lines. \\[Buffer-menu-backup-unmark] Back up a line and remove marks. \\[Buffer-menu-toggle-read-only] Toggle read-only status of buffer on this line. \\[revert-buffer] Update the list of buffers. @@ -356,6 +361,18 @@ Buffer-menu-unmark (Buffer-menu--unmark) (forward-line (if backup -1 1))) +(defun Buffer-menu-unmark-all () + "Cancel all requested operations on buffers." + (interactive) + (save-excursion + (goto-char (point-min)) + (when (tabulated-list-header-overlay-p) + (forward-line)) + (while (not (eobp)) + (unless (string= "." (aref (tabulated-list-get-entry) 0)) + (tabulated-list-set-col 0 " " t)) + (forward-line)))) + (defun Buffer-menu-backup-unmark () "Move up and cancel all requested operations on buffer on line above." (interactive) diff --git a/lisp/ebuff-menu.el b/lisp/ebuff-menu.el index 5536f94..3b8e12d 100644 --- a/lisp/ebuff-menu.el +++ b/lisp/ebuff-menu.el @@ -55,6 +55,7 @@ electric-buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "U" 'Buffer-menu-unmark-all) (let ((i ?0)) (while (<= i ?9) (define-key map (char-to-string i) 'digit-argument) @@ -114,6 +115,7 @@ electric-buffer-list \\[Buffer-menu-save] -- mark that buffer to be saved. \\[Buffer-menu-delete] or \\[Buffer-menu-delete-backwards] -- mark that buffer to be deleted. \\[Buffer-menu-unmark] -- remove all kinds of marks from current line. +\\[Buffer-menu-unmark-all] -- remove all kinds of marks from all lines. \\[Electric-buffer-menu-mode-view-buffer] -- view buffer, returning when done. \\[Buffer-menu-backup-unmark] -- back up a line and remove marks." (interactive "P") diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 00b029d..2757feb 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -257,6 +257,12 @@ tabulated-list-print-fake-header (make-overlay (point-min) (point)))) (overlay-put tabulated-list--header-overlay 'face 'underline)))) +(defsubst tabulated-list-header-overlay-p (&optional pos) + "Return non-nil if there is a fake header. +Optional arg POS is a buffer position where to look for a fake header; +defaults to `point-min'." + (overlays-at (or pos (point-min)))) + (defun tabulated-list-revert (&rest ignored) "The `revert-buffer-function' for `tabulated-list-mode'. It runs `tabulated-list-revert-hook', then calls `tabulated-list-print'." -- 2.10.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-05 built on calancha-pc Repository revision: 3424c27abb7c8ea64c32eaf54cf53fc58323e5ce ^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-06 12:21 ` Tino Calancha @ 2016-11-06 17:22 ` Drew Adams 2016-11-14 10:29 ` Tino Calancha 2016-11-07 18:38 ` Eli Zaretskii 1 sibling, 1 reply; 12+ messages in thread From: Drew Adams @ 2016-11-06 17:22 UTC (permalink / raw) To: Tino Calancha, Eli Zaretskii; +Cc: 24880 It would be far better, IMHO, to take the approach used by Dired for this. In Dired, `M-DEL' (or `* ?') unmarks a specific mark (e.g. D). Or if it is followed directly by `RET', it unmarks all marks. This is relevant and useful behavior for all contexts, such as `*Buffer List*' (aka Buffer Menu), that let you mark things in more than one way. Users should be able to use `M-DEL' to selectively remove any one of the marks (D, S, >,...) _or_ all marks together (via `M-DEL RET'). The same approach should be taken for other, similar buffers that list objects that can be marked in more than one way, whether the objects be buffers (e.g. Ibuffer), packages, files, bookmarks, or whatever else. Besides giving users much more control, this provides a consistent UI. Users will then use `M-DEL RET' as the standard way to completely unmark an object. This is the approach I took with Bookmark+, for instance. It takes a tiny bit more work to implement, but the result is far more useful for users. (Just one opinion.) ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-06 17:22 ` Drew Adams @ 2016-11-14 10:29 ` Tino Calancha 2016-11-15 16:03 ` Eli Zaretskii 0 siblings, 1 reply; 12+ messages in thread From: Tino Calancha @ 2016-11-14 10:29 UTC (permalink / raw) To: Drew Adams; +Cc: 24880, Tino Calancha On Sun, 6 Nov 2016, Drew Adams wrote: > It would be far better, IMHO, to take the approach used by > Dired for this. > > In Dired, `M-DEL' (or `* ?') unmarks a specific mark (e.g. D). > Or if it is followed directly by `RET', it unmarks all marks. > > This is relevant and useful behavior for all contexts, such > as `*Buffer List*' (aka Buffer Menu), that let you mark > things in more than one way. > > Users should be able to use `M-DEL' to selectively remove > any one of the marks (D, S, >,...) _or_ all marks together > (via `M-DEL RET'). > > The same approach should be taken for other, similar > buffers that list objects that can be marked in more than > one way, whether the objects be buffers (e.g. Ibuffer), > packages, files, bookmarks, or whatever else. > > Besides giving users much more control, this provides a > consistent UI. Users will then use `M-DEL RET' as the > standard way to completely unmark an object. > > This is the approach I took with Bookmark+, for instance. > It takes a tiny bit more work to implement, but the result > is far more useful for users. Thank you. I totally agree with your suggestion. I have added a command `Buffer-menu-unmark-all-buffers' which remove a specific flag. I bind it to `M-DEL'. That is for buff-menu.el and ebuff-menu.el. In bs.el i haven't added such command because this file does support just one flag: if you push 'd' it doesn't flag for deletion, it just delete the buffer at point. This is the amended patch: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; From 7a4d4bdfc8a31ff9e4607081cea294c4aa101839 Mon Sep 17 00:00:00 2001 From: Tino Calancha <tino.calancha@gmail.com> Date: Mon, 14 Nov 2016 19:11:40 +0900 Subject: [PATCH] buff-menu: Add command to unmark all buffers Bind 'U' in buff-menu, bs and electric-buff-menu to commands to unmark all buffers (Bug#24880). * lisp/emacs-lisp/tabulated-list.el (tabulated-list-header-overlay-p): New predicate; return non-nil if tabulated-list has a fake header. * lisp/buff-menu.el (Buffer-menu-unmark-all-buffers): New command; remove all flags that use a particular mark from all the lines. Bind it to 'M-DEL'. (Buffer-menu-unmark-all): New command; remove all flags from all the lines. Bind it to 'U'. (Buffer-menu-marker-char, Buffer-menu-del-char): New variables. (Buffer-menu-delete, Buffer-menu-mark): Use them. (Buffer-menu-mode-map): Update menus. (Buffer-menu-mode): Update mode doc. * lisp/bs.el (bs-unmark-all, bs-unmark-previous): New commands. (bs-mode-map): Bind them to 'U' and '<backspace>' respectively. (bs-mode): Update mode doc. * lisp/ebuff-menu.el (electric-buffer-menu-mode-map): Bind Buffer-menu-unmark-all to 'U' and Buffer-menu-unmark-all-buffers to 'M-DEL'. (electric-buffer-list): Update mode doc. * doc/emacs/buffers.texi (Several Buffers): Mention Buffer-menu-unmark-all and Buffer-menu-unmark-all-buffers. ; * etc/NEWS: Add an entry per each new feature. --- doc/emacs/buffers.texi | 12 +++++++++++ etc/NEWS | 18 +++++++++++++++++ lisp/bs.el | 33 ++++++++++++++++++++++++++++++ lisp/buff-menu.el | 42 ++++++++++++++++++++++++++++++++++++--- lisp/ebuff-menu.el | 3 +++ lisp/emacs-lisp/tabulated-list.el | 6 ++++++ 6 files changed, 111 insertions(+), 3 deletions(-) diff --git a/doc/emacs/buffers.texi b/doc/emacs/buffers.texi index 2eb837f..561289a 100644 --- a/doc/emacs/buffers.texi +++ b/doc/emacs/buffers.texi @@ -411,6 +411,18 @@ Several Buffers @kindex DEL @r{(Buffer Menu)} Move to the previous line and remove all flags on that line (@code{Buffer-menu-backup-unmark}). + +@item M-@key{DEL} @var{markchar} +@findex Buffer-menu-unmark-all-buffers +@kindex M-DEL @r{(Buffer Menu)} +Remove all flags that use the character @var{markchar} from all lines +(@code{Buffer-menu-unmark-all-buffers}). + +@item U +@findex Buffer-menu-unmark-all +@kindex U @r{(Buffer Menu)} +Remove all flags from all the lines +(@code{Buffer-menu-unmark-all}). @end table @noindent diff --git a/etc/NEWS b/etc/NEWS index 03c4990..037dd0d 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -269,6 +269,24 @@ the file's actual content before prompting the user. * Changes in Specialized Modes and Packages in Emacs 26.1 +** Electric-Buffer-menu + ++++ +*** Key 'U' is bound to 'Buffer-menu-unmark-all' and key 'M-DEL' is +bound to 'Buffer-menu-unmark-all-buffers'. + +** bs + +--- +*** Two new commands 'bs-unmark-all', bound to 'U', and +'bs-unmark-previous', bound to <backspace>. + +** Buffer-menu + ++++ +*** Two new commands 'Buffer-menu-unmark-all', bound to 'U' and +'Buffer-menu-unmark-all-buffers', bound to 'M-DEL'. + ** Ibuffer --- diff --git a/lisp/bs.el b/lisp/bs.el index 8351169..f5f4436 100644 --- a/lisp/bs.el +++ b/lisp/bs.el @@ -491,6 +491,8 @@ bs-mode-map (define-key map "t" 'bs-visit-tags-table) (define-key map "m" 'bs-mark-current) (define-key map "u" 'bs-unmark-current) + (define-key map "U" 'bs-unmark-all) + (define-key map "\177" 'bs-unmark-previous) (define-key map ">" 'scroll-right) (define-key map "<" 'scroll-left) (define-key map "?" 'bs-help) @@ -635,6 +637,8 @@ bs-mode \\[bs-clear-modified] -- clear modified-flag on that buffer. \\[bs-mark-current] -- mark current line's buffer to be displayed. \\[bs-unmark-current] -- unmark current line's buffer to be displayed. +\\[bs-unmark-all] -- unmark all buffer lines. +\\[bs-unmark-previous] -- unmark previous line's buffer to be displayed. \\[bs-show-sorted] -- display buffer list sorted by next sort aspect. \\[bs-set-configuration-and-refresh] -- ask user for a configuration and \ apply selected configuration. @@ -882,6 +886,35 @@ bs-unmark-current (lambda (buf) (setq bs--marked-buffers (delq buf bs--marked-buffers))))) +(defun bs-unmark-previous (count) + "Unmark previous COUNT buffers. +Move cursor vertically up COUNT lines." + (interactive "p") + (when (natnump count) + (setq count (- count))) + (forward-line count) + (save-excursion + (bs-unmark-current (- count)))) + +(defun bs-unmark-all () + "Unmark all buffers." + (interactive) + (let ((marked (string-to-char bs-string-marked)) + (current (string-to-char bs-string-current)) + (marked-cur (string-to-char bs-string-current-marked)) + (unmarked (string-to-char bs-string-show-normally)) + (inhibit-read-only t)) + (save-excursion + (goto-char (point-min)) + (forward-line 2) + (while (not (eobp)) + (if (eq (char-after) marked) + (subst-char-in-region (point) (1+ (point)) marked unmarked) + (when (eq (char-after) marked-cur) + (subst-char-in-region (point) (1+ (point)) marked-cur current))) + (forward-line 1)) + (setq bs--marked-buffers nil)))) + (defun bs--show-config-message (what) "Show message indicating the new showing status WHAT. WHAT is a value of nil, `never', or `always'." diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..42fd032 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -37,6 +37,12 @@ Buffer-menu :group 'tools :group 'convenience) +(defvar Buffer-menu-marker-char ?> + "The mark character for marked buffers.") + +(defvar Buffer-menu-del-char ?D + "Character used to flag buffers for deletion.") + (defcustom Buffer-menu-use-header-line t "If non-nil, use the header line to display Buffer Menu column titles." :type 'boolean @@ -121,6 +127,8 @@ Buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "\M-\C-?" 'Buffer-menu-unmark-all-buffers) + (define-key map "U" 'Buffer-menu-unmark-all) (define-key map "m" 'Buffer-menu-mark) (define-key map "t" 'Buffer-menu-visit-tags-table) (define-key map "%" 'Buffer-menu-toggle-read-only) @@ -197,6 +205,12 @@ Buffer-menu-mode-map (bindings--define-key menu-map [umk] '(menu-item "Unmark" Buffer-menu-unmark :help "Cancel all requested operations on buffer on this line and move down")) + (bindings--define-key menu-map [umkab] + '(menu-item "Unmark all buffers with mark" Buffer-menu-unmark-all-buffers + :help "Cancel a requested operation on buffers")) + (bindings--define-key menu-map [umka] + '(menu-item "Unmark all" Buffer-menu-unmark-all + :help "Cancel all requested operations on buffers")) (bindings--define-key menu-map [mk] '(menu-item "Mark" Buffer-menu-mark :help "Mark buffer on this line for being displayed by v command")) @@ -239,6 +253,8 @@ Buffer-menu-mode \\[Buffer-menu-execute] Delete or save marked buffers. \\[Buffer-menu-unmark] Remove all marks from current line. With prefix argument, also move up one line. +\\[Buffer-menu-unmark-all-buffers] Remove a particular mark from all lines. +\\[Buffer-menu-unmark-all] Remove all marks from all lines. \\[Buffer-menu-backup-unmark] Back up a line and remove marks. \\[Buffer-menu-toggle-read-only] Toggle read-only status of buffer on this line. \\[revert-buffer] Update the list of buffers. @@ -346,7 +362,7 @@ Buffer-menu-mark "Mark the Buffer menu entry at point for later display. It will be displayed by the \\<Buffer-menu-mode-map>\\[Buffer-menu-select] command." (interactive) - (tabulated-list-set-col 0 ">" t) + (tabulated-list-set-col 0 (char-to-string Buffer-menu-marker-char) t) (forward-line)) (defun Buffer-menu-unmark (&optional backup) @@ -356,6 +372,26 @@ Buffer-menu-unmark (Buffer-menu--unmark) (forward-line (if backup -1 1))) +(defun Buffer-menu-unmark-all-buffers (mark) + "Cancel a requested operation on all buffers." + (interactive "cRemove marks (RET means all):") + (save-excursion + (goto-char (point-min)) + (when (tabulated-list-header-overlay-p) + (forward-line)) + (while (not (eobp)) + (let ((xmarks (list (aref (tabulated-list-get-entry) 0) + (aref (tabulated-list-get-entry) 2)))) + (when (or (char-equal mark ?\r) + (member (char-to-string mark) xmarks)) + (Buffer-menu--unmark))) + (forward-line)))) + +(defun Buffer-menu-unmark-all () + "Cancel all requested operations on buffers." + (interactive) + (Buffer-menu-unmark-all-buffers ?\r)) + (defun Buffer-menu-backup-unmark () "Move up and cancel all requested operations on buffer on line above." (interactive) @@ -382,12 +418,12 @@ Buffer-menu-delete (setq arg 1)) (while (> arg 0) (when (Buffer-menu-buffer) - (tabulated-list-set-col 0 "D" t)) + (tabulated-list-set-col 0 (char-to-string Buffer-menu-del-char) t)) (forward-line 1) (setq arg (1- arg))) (while (< arg 0) (when (Buffer-menu-buffer) - (tabulated-list-set-col 0 "D" t)) + (tabulated-list-set-col 0 (char-to-string Buffer-menu-del-char) t)) (forward-line -1) (setq arg (1+ arg)))) diff --git a/lisp/ebuff-menu.el b/lisp/ebuff-menu.el index 5536f94..48be32a 100644 --- a/lisp/ebuff-menu.el +++ b/lisp/ebuff-menu.el @@ -55,6 +55,8 @@ electric-buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "\M-\C-?" 'Buffer-menu-unmark-all-buffers) + (define-key map "U" 'Buffer-menu-unmark-all) (let ((i ?0)) (while (<= i ?9) (define-key map (char-to-string i) 'digit-argument) @@ -114,6 +116,7 @@ electric-buffer-list \\[Buffer-menu-save] -- mark that buffer to be saved. \\[Buffer-menu-delete] or \\[Buffer-menu-delete-backwards] -- mark that buffer to be deleted. \\[Buffer-menu-unmark] -- remove all kinds of marks from current line. +\\[Buffer-menu-unmark-all] -- remove all kinds of marks from all lines. \\[Electric-buffer-menu-mode-view-buffer] -- view buffer, returning when done. \\[Buffer-menu-backup-unmark] -- back up a line and remove marks." (interactive "P") diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index cf297f1..9523d5e 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -259,6 +259,12 @@ tabulated-list-print-fake-header (make-overlay (point-min) (point)))) (overlay-put tabulated-list--header-overlay 'face 'underline)))) +(defsubst tabulated-list-header-overlay-p (&optional pos) + "Return non-nil if there is a fake header. +Optional arg POS is a buffer position where to look for a fake header; +defaults to `point-min'." + (overlays-at (or pos (point-min)))) + (defun tabulated-list-revert (&rest ignored) "The `revert-buffer-function' for `tabulated-list-mode'. It runs `tabulated-list-revert-hook', then calls `tabulated-list-print'." -- 2.10.2 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-14 Repository revision: db43613307bb05d0f43d2d5649b5bb2f29876cee ^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-14 10:29 ` Tino Calancha @ 2016-11-15 16:03 ` Eli Zaretskii 2016-11-16 10:09 ` Tino Calancha 0 siblings, 1 reply; 12+ messages in thread From: Eli Zaretskii @ 2016-11-15 16:03 UTC (permalink / raw) To: Tino Calancha; +Cc: 24880 > From: Tino Calancha <tino.calancha@gmail.com> > Date: Mon, 14 Nov 2016 19:29:14 +0900 (JST) > cc: Tino Calancha <tino.calancha@gmail.com>, Eli Zaretskii <eliz@gnu.org>, > 24880@debbugs.gnu.org > > This is the amended patch: Thanks, please see a few comments below. > +@item M-@key{DEL} @var{markchar} Please remove the @var{markchar} part, we don't usually show user input after the keys. > +(defun bs-unmark-previous (count) > + "Unmark previous COUNT buffers. > +Move cursor vertically up COUNT lines." > + (interactive "p") The doc string should describe the effect of the prefix argument in interactive usage. Also, we prefer to say "move point", not "move cursor", since that's what the commands do; cursor movement is then performed by redisplay as the side effect. > + (define-key map "\M-\C-?" 'Buffer-menu-unmark-all-buffers) I'd prefer to use "\M-\177" instead, for consistency with DEL. (Yes, I know that other packages use \C-?, but we must start somewhere.) > + (bindings--define-key menu-map [umkab] > + '(menu-item "Unmark all buffers with mark" Buffer-menu-unmark-all-buffers Labels of menu items which invoke commands that prompt user for input should end in "...", as an indication that user input will be required. Also, "unmark ... with mark" sounds confusing, and is also quite long. How about "Remove marks..."? > + :help "Cancel a requested operation on buffers")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This should say "all buffers", right? > +(defun Buffer-menu-unmark-all-buffers (mark) > + "Cancel a requested operation on all buffers." > + (interactive "cRemove marks (RET means all):") This doc string should mention the argument MARK, and should also tell that the in interactive use the user is prompted for the character. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-15 16:03 ` Eli Zaretskii @ 2016-11-16 10:09 ` Tino Calancha 2016-11-18 10:09 ` Eli Zaretskii 0 siblings, 1 reply; 12+ messages in thread From: Tino Calancha @ 2016-11-16 10:09 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 24880, Tino Calancha On Tue, 15 Nov 2016, Eli Zaretskii wrote: >> This is the amended patch: > > Thanks, please see a few comments below. Thank you. I have implemented your comments. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; From bcc00e4f1da3f9c6bbb484c403fc7a107ccafb8d Mon Sep 17 00:00:00 2001 From: Tino Calancha <tino.calancha@gmail.com> Date: Wed, 16 Nov 2016 19:01:21 +0900 Subject: [PATCH] buff-menu: Add command to unmark all buffers Bind 'U' in buff-menu, bs and electric-buff-menu to commands to unmark all buffers (Bug#24880). * lisp/emacs-lisp/tabulated-list.el (tabulated-list-header-overlay-p): New predicate; return non-nil if tabulated-list has a fake header. * lisp/buff-menu.el (Buffer-menu-unmark-all-buffers): New command; remove all flags that use a particular mark from all the lines. Bind it to 'M-DEL'. (Buffer-menu-unmark-all): New command; remove all flags from all the lines. Bind it to 'U'. (Buffer-menu-marker-char, Buffer-menu-del-char): New variables. (Buffer-menu-delete, Buffer-menu-mark): Use them. (Buffer-menu-mode-map): Update menus. (Buffer-menu-mode): Update mode doc. * lisp/bs.el (bs-unmark-all, bs-unmark-previous): New commands. (bs-mode-map): Bind them to 'U' and '<backspace>' respectively. (bs-mode): Update mode doc. * lisp/ebuff-menu.el (electric-buffer-menu-mode-map): Bind Buffer-menu-unmark-all to 'U' and Buffer-menu-unmark-all-buffers to 'M-DEL'. (electric-buffer-list): Update mode doc. * doc/emacs/buffers.texi (Several Buffers): Mention Buffer-menu-unmark-all and Buffer-menu-unmark-all-buffers. ; * etc/NEWS: Add an entry per each new feature. --- doc/emacs/buffers.texi | 12 +++++++++++ etc/NEWS | 18 ++++++++++++++++ lisp/bs.el | 31 +++++++++++++++++++++++++++ lisp/buff-menu.el | 44 ++++++++++++++++++++++++++++++++++++--- lisp/ebuff-menu.el | 3 +++ lisp/emacs-lisp/tabulated-list.el | 6 ++++++ 6 files changed, 111 insertions(+), 3 deletions(-) diff --git a/doc/emacs/buffers.texi b/doc/emacs/buffers.texi index 2eb837f..c70e583 100644 --- a/doc/emacs/buffers.texi +++ b/doc/emacs/buffers.texi @@ -411,6 +411,18 @@ Several Buffers @kindex DEL @r{(Buffer Menu)} Move to the previous line and remove all flags on that line (@code{Buffer-menu-backup-unmark}). + +@item M-@key{DEL} +@findex Buffer-menu-unmark-all-buffers +@kindex M-DEL @r{(Buffer Menu)} +Remove a particular flag from all lines +(@code{Buffer-menu-unmark-all-buffers}). + +@item U +@findex Buffer-menu-unmark-all +@kindex U @r{(Buffer Menu)} +Remove all flags from all the lines +(@code{Buffer-menu-unmark-all}). @end table @noindent diff --git a/etc/NEWS b/etc/NEWS index 15c264f..4b2af50 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -280,6 +280,24 @@ the file's actual content before prompting the user. * Changes in Specialized Modes and Packages in Emacs 26.1 +** Electric-Buffer-menu + ++++ +*** Key 'U' is bound to 'Buffer-menu-unmark-all' and key 'M-DEL' is +bound to 'Buffer-menu-unmark-all-buffers'. + +** bs + +--- +*** Two new commands 'bs-unmark-all', bound to 'U', and +'bs-unmark-previous', bound to <backspace>. + +** Buffer-menu + ++++ +*** Two new commands 'Buffer-menu-unmark-all', bound to 'U' and +'Buffer-menu-unmark-all-buffers', bound to 'M-DEL'. + ** Ibuffer --- diff --git a/lisp/bs.el b/lisp/bs.el index 8351169..2ee0a5b 100644 --- a/lisp/bs.el +++ b/lisp/bs.el @@ -491,6 +491,8 @@ bs-mode-map (define-key map "t" 'bs-visit-tags-table) (define-key map "m" 'bs-mark-current) (define-key map "u" 'bs-unmark-current) + (define-key map "U" 'bs-unmark-all) + (define-key map "\177" 'bs-unmark-previous) (define-key map ">" 'scroll-right) (define-key map "<" 'scroll-left) (define-key map "?" 'bs-help) @@ -635,6 +637,8 @@ bs-mode \\[bs-clear-modified] -- clear modified-flag on that buffer. \\[bs-mark-current] -- mark current line's buffer to be displayed. \\[bs-unmark-current] -- unmark current line's buffer to be displayed. +\\[bs-unmark-all] -- unmark all buffer lines. +\\[bs-unmark-previous] -- unmark previous line's buffer to be displayed. \\[bs-show-sorted] -- display buffer list sorted by next sort aspect. \\[bs-set-configuration-and-refresh] -- ask user for a configuration and \ apply selected configuration. @@ -882,6 +886,33 @@ bs-unmark-current (lambda (buf) (setq bs--marked-buffers (delq buf bs--marked-buffers))))) +(defun bs-unmark-previous (count) + "Unmark previous COUNT buffers. +Move point vertically up COUNT lines. +When called interactively a numeric prefix argument sets COUNT." + (interactive "p") + (forward-line (- count)) + (save-excursion (bs-unmark-current count))) + +(defun bs-unmark-all () + "Unmark all buffers." + (interactive) + (let ((marked (string-to-char bs-string-marked)) + (current (string-to-char bs-string-current)) + (marked-cur (string-to-char bs-string-current-marked)) + (unmarked (string-to-char bs-string-show-normally)) + (inhibit-read-only t)) + (save-excursion + (goto-char (point-min)) + (forward-line 2) + (while (not (eobp)) + (if (eq (char-after) marked) + (subst-char-in-region (point) (1+ (point)) marked unmarked) + (when (eq (char-after) marked-cur) + (subst-char-in-region (point) (1+ (point)) marked-cur current))) + (forward-line 1)) + (setq bs--marked-buffers nil)))) + (defun bs--show-config-message (what) "Show message indicating the new showing status WHAT. WHAT is a value of nil, `never', or `always'." diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..f34c814 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -37,6 +37,12 @@ Buffer-menu :group 'tools :group 'convenience) +(defvar Buffer-menu-marker-char ?> + "The mark character for marked buffers.") + +(defvar Buffer-menu-del-char ?D + "Character used to flag buffers for deletion.") + (defcustom Buffer-menu-use-header-line t "If non-nil, use the header line to display Buffer Menu column titles." :type 'boolean @@ -121,6 +127,8 @@ Buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "\M-\177" 'Buffer-menu-unmark-all-buffers) + (define-key map "U" 'Buffer-menu-unmark-all) (define-key map "m" 'Buffer-menu-mark) (define-key map "t" 'Buffer-menu-visit-tags-table) (define-key map "%" 'Buffer-menu-toggle-read-only) @@ -197,6 +205,12 @@ Buffer-menu-mode-map (bindings--define-key menu-map [umk] '(menu-item "Unmark" Buffer-menu-unmark :help "Cancel all requested operations on buffer on this line and move down")) + (bindings--define-key menu-map [umkab] + '(menu-item "Remove marks..." Buffer-menu-unmark-all-buffers + :help "Cancel a requested operation on all buffers")) + (bindings--define-key menu-map [umka] + '(menu-item "Unmark all" Buffer-menu-unmark-all + :help "Cancel all requested operations on buffers")) (bindings--define-key menu-map [mk] '(menu-item "Mark" Buffer-menu-mark :help "Mark buffer on this line for being displayed by v command")) @@ -239,6 +253,8 @@ Buffer-menu-mode \\[Buffer-menu-execute] Delete or save marked buffers. \\[Buffer-menu-unmark] Remove all marks from current line. With prefix argument, also move up one line. +\\[Buffer-menu-unmark-all-buffers] Remove a particular mark from all lines. +\\[Buffer-menu-unmark-all] Remove all marks from all lines. \\[Buffer-menu-backup-unmark] Back up a line and remove marks. \\[Buffer-menu-toggle-read-only] Toggle read-only status of buffer on this line. \\[revert-buffer] Update the list of buffers. @@ -346,7 +362,7 @@ Buffer-menu-mark "Mark the Buffer menu entry at point for later display. It will be displayed by the \\<Buffer-menu-mode-map>\\[Buffer-menu-select] command." (interactive) - (tabulated-list-set-col 0 ">" t) + (tabulated-list-set-col 0 (char-to-string Buffer-menu-marker-char) t) (forward-line)) (defun Buffer-menu-unmark (&optional backup) @@ -356,6 +372,28 @@ Buffer-menu-unmark (Buffer-menu--unmark) (forward-line (if backup -1 1))) +(defun Buffer-menu-unmark-all-buffers (mark) + "Cancel a requested operation on all buffers. +MARK is the character to flag the operation on the buffers. +When called interactively prompt for MARK; RET remove all marks." + (interactive "cRemove marks (RET means all):") + (save-excursion + (goto-char (point-min)) + (when (tabulated-list-header-overlay-p) + (forward-line)) + (while (not (eobp)) + (let ((xmarks (list (aref (tabulated-list-get-entry) 0) + (aref (tabulated-list-get-entry) 2)))) + (when (or (char-equal mark ?\r) + (member (char-to-string mark) xmarks)) + (Buffer-menu--unmark))) + (forward-line)))) + +(defun Buffer-menu-unmark-all () + "Cancel all requested operations on buffers." + (interactive) + (Buffer-menu-unmark-all-buffers ?\r)) + (defun Buffer-menu-backup-unmark () "Move up and cancel all requested operations on buffer on line above." (interactive) @@ -382,12 +420,12 @@ Buffer-menu-delete (setq arg 1)) (while (> arg 0) (when (Buffer-menu-buffer) - (tabulated-list-set-col 0 "D" t)) + (tabulated-list-set-col 0 (char-to-string Buffer-menu-del-char) t)) (forward-line 1) (setq arg (1- arg))) (while (< arg 0) (when (Buffer-menu-buffer) - (tabulated-list-set-col 0 "D" t)) + (tabulated-list-set-col 0 (char-to-string Buffer-menu-del-char) t)) (forward-line -1) (setq arg (1+ arg)))) diff --git a/lisp/ebuff-menu.el b/lisp/ebuff-menu.el index 5536f94..74a9dd5 100644 --- a/lisp/ebuff-menu.el +++ b/lisp/ebuff-menu.el @@ -55,6 +55,8 @@ electric-buffer-menu-mode-map (define-key map "\177" 'Buffer-menu-backup-unmark) (define-key map "~" 'Buffer-menu-not-modified) (define-key map "u" 'Buffer-menu-unmark) + (define-key map "\M-\177" 'Buffer-menu-unmark-all-buffers) + (define-key map "U" 'Buffer-menu-unmark-all) (let ((i ?0)) (while (<= i ?9) (define-key map (char-to-string i) 'digit-argument) @@ -114,6 +116,7 @@ electric-buffer-list \\[Buffer-menu-save] -- mark that buffer to be saved. \\[Buffer-menu-delete] or \\[Buffer-menu-delete-backwards] -- mark that buffer to be deleted. \\[Buffer-menu-unmark] -- remove all kinds of marks from current line. +\\[Buffer-menu-unmark-all] -- remove all kinds of marks from all lines. \\[Electric-buffer-menu-mode-view-buffer] -- view buffer, returning when done. \\[Buffer-menu-backup-unmark] -- back up a line and remove marks." (interactive "P") diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index cf297f1..9523d5e 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -259,6 +259,12 @@ tabulated-list-print-fake-header (make-overlay (point-min) (point)))) (overlay-put tabulated-list--header-overlay 'face 'underline)))) +(defsubst tabulated-list-header-overlay-p (&optional pos) + "Return non-nil if there is a fake header. +Optional arg POS is a buffer position where to look for a fake header; +defaults to `point-min'." + (overlays-at (or pos (point-min)))) + (defun tabulated-list-revert (&rest ignored) "The `revert-buffer-function' for `tabulated-list-mode'. It runs `tabulated-list-revert-hook', then calls `tabulated-list-print'." -- 2.10.2 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.3) of 2016-11-16 Repository revision: 36b99556dea23f17d5598bbed366e7201eec9fbb ^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-16 10:09 ` Tino Calancha @ 2016-11-18 10:09 ` Eli Zaretskii 2016-11-18 10:17 ` Tino Calancha 0 siblings, 1 reply; 12+ messages in thread From: Eli Zaretskii @ 2016-11-18 10:09 UTC (permalink / raw) To: Tino Calancha; +Cc: 24880 > From: Tino Calancha <tino.calancha@gmail.com> > Date: Wed, 16 Nov 2016 19:09:19 +0900 (JST) > cc: Tino Calancha <tino.calancha@gmail.com>, > Drew Adams <drew.adams@oracle.com>, 24880@debbugs.gnu.org > > > > On Tue, 15 Nov 2016, Eli Zaretskii wrote: > > >> This is the amended patch: > > > > Thanks, please see a few comments below. > Thank you. I have implemented your comments. Please give this a few more days, and if no further comments are posted, push to master. (Should this be mentioned in NEWS?) Thanks. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-18 10:09 ` Eli Zaretskii @ 2016-11-18 10:17 ` Tino Calancha 2016-11-18 11:05 ` Eli Zaretskii 0 siblings, 1 reply; 12+ messages in thread From: Tino Calancha @ 2016-11-18 10:17 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 24880, Tino Calancha On Fri, 18 Nov 2016, Eli Zaretskii wrote: > Please give this a few more days, and if no further comments are > posted, push to master. OK, thanks. I will wait until next tuesday 15th. > (Should this be mentioned in NEWS?) I can skip the NEWS entries, or reduce their length. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-18 10:17 ` Tino Calancha @ 2016-11-18 11:05 ` Eli Zaretskii 0 siblings, 0 replies; 12+ messages in thread From: Eli Zaretskii @ 2016-11-18 11:05 UTC (permalink / raw) To: Tino Calancha; +Cc: 24880 > From: Tino Calancha <tino.calancha@gmail.com> > Date: Fri, 18 Nov 2016 19:17:48 +0900 (JST) > cc: Tino Calancha <tino.calancha@gmail.com>, drew.adams@oracle.com, > 24880@debbugs.gnu.org > > On Fri, 18 Nov 2016, Eli Zaretskii wrote: > > > Please give this a few more days, and if no further comments are > > posted, push to master. > OK, thanks. I will wait until next tuesday 15th. Thanks. > > (Should this be mentioned in NEWS?) > I can skip the NEWS entries, or reduce their length. Sorry, I somehow managed to miss the fact that the NEWS entries were part of the patch. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-06 12:21 ` Tino Calancha 2016-11-06 17:22 ` Drew Adams @ 2016-11-07 18:38 ` Eli Zaretskii 1 sibling, 0 replies; 12+ messages in thread From: Eli Zaretskii @ 2016-11-07 18:38 UTC (permalink / raw) To: Tino Calancha; +Cc: 24880 > From: Tino Calancha <tino.calancha@gmail.com> > CC: 24880@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com> > Date: Sun, 06 Nov 2016 21:21:29 +0900 > > diff --git a/etc/NEWS b/etc/NEWS > index 4bf5332..6c9bca0 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -259,6 +259,22 @@ the file's actual content before prompting the user. > \f > * Changes in Specialized Modes and Packages in Emacs 26.1 > > +** Electric-Buffer-menu > + > +--- > +*** Key 'U' is bound to 'Buffer-menu-unmark-all'. That "---" should actually be "+++", since you have added the documentation to the manual. Thanks. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24880: 26.0.50; buff-menu: Command to unmark all buffers 2016-11-05 10:04 bug#24880: 26.0.50; buff-menu: Command to unmark all buffers Tino Calancha 2016-11-05 10:17 ` Eli Zaretskii @ 2016-11-22 6:30 ` Tino Calancha 1 sibling, 0 replies; 12+ messages in thread From: Tino Calancha @ 2016-11-22 6:30 UTC (permalink / raw) To: 24880-done Eli Zaretskii <eliz@gnu.org> writes: > Please give this a few more days, and if no further comments are > posted, push to master. Pushed to master branch as commit: 27b754c ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-11-22 6:30 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-05 10:04 bug#24880: 26.0.50; buff-menu: Command to unmark all buffers Tino Calancha 2016-11-05 10:17 ` Eli Zaretskii 2016-11-06 12:21 ` Tino Calancha 2016-11-06 17:22 ` Drew Adams 2016-11-14 10:29 ` Tino Calancha 2016-11-15 16:03 ` Eli Zaretskii 2016-11-16 10:09 ` Tino Calancha 2016-11-18 10:09 ` Eli Zaretskii 2016-11-18 10:17 ` Tino Calancha 2016-11-18 11:05 ` Eli Zaretskii 2016-11-07 18:38 ` Eli Zaretskii 2016-11-22 6:30 ` Tino Calancha
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).