From: Mark Oteiza <mvoteiza@udel.edu>
To: Dima Kogan <dima@secretsauce.net>
Cc: 25105@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>,
Dmitry Gutov <dgutov@yandex.ru>,
npostavs@users.sourceforge.net
Subject: bug#25105: 26.0.50; diff navigation is broken
Date: Thu, 05 Jan 2017 23:43:37 -0500 [thread overview]
Message-ID: <87h95cpzly.fsf@udel.edu> (raw)
In-Reply-To: <87lguovn5f.fsf@secretsauce.net> (Dima Kogan's message of "Thu, 05 Jan 2017 20:16:12 -0800")
Dima Kogan <dima@secretsauce.net> writes:
> Mark Oteiza <mvoteiza@udel.edu> writes:
>> I fail to see how fixing corner cases in diff-apply-hunk has anything
>> to do with diff-{file,hunk}-{next-prev}
>
> The issues being fixed are making anything that operates on hunks more
> consistent, so diff-{file,hunk}-{next-prev} are relevant.
and this entire thread is about the contention over changes specifically
done to diff-{file,hunk}-{next-prev}.
To quote myself: "Fixing C-c C-a to DTRT is great, thanks, but I don't
think the off-by-one navigation changes to "n" and "p" (diff-hunk-next,
diff-hunk-prev) make sense."
https://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00222.html
>> At first glance, it looks like the following patch would restore the
>> previous behavior, however it completely breaks auto refinement.
>>
>> <snip>
>
> If you want to restore the previous behavior, wouldn't a revert be
> better? Or are you trying to restore only a subset of the previous
> behavior?
I did not submit it as a solution to the problem at hand. The fact that
the patch breaks auto-refinement means that I cannot define my own
commands to call (diff-{file-hunk}-{prev-next} ARG nil) and have it
work.
Put another way, your changes make it nigh impossible to get the
previous n,p,{,} back without breaking something.
>> With the number of actual bugs (email/format-patch/pre-diff content,
>> and auto refinement) the initial patch caused, perhaps this is best.
>
> The email/format-patch issue has nothing to do with me; it has been a
> problem for years.
Yes it did, as the second recipe in this bug and 6b6abe0d clearly show.
> The way to "fix" auto-refinement is to invoke
> auto-refinement in a diff-mode-hook, as suggested earlier. The bug
> reporter didn't like that <snip>
Probably because auto-refinement is default behavior that got broken.
> I'm not sure
> where the pre-diff content issue came from. Likely it came up because
> the patch that was in the BTS for years wasn't what ended up being
> merged, so I haven't sufficiently tested it. Lesson learned.
>
> I consider the current behavior a significant improvement in usability,
> but if there's a consensus that it's a step backward, then I'll go back
> to carrying this patch in my local tree. Let me ask the few people I
> know who would be using this code at all to get at least anecdotal
> feedback.
next prev parent reply other threads:[~2017-01-06 4:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 15:13 bug#25105: 26.0.50; diff navigation is broken Mark Oteiza
2016-12-04 15:27 ` npostavs
2016-12-05 15:38 ` Dima Kogan
2016-12-05 15:53 ` Dmitry Gutov
2016-12-05 16:33 ` Dima Kogan
2016-12-05 16:55 ` Mark Oteiza
2016-12-05 17:49 ` Dima Kogan
2016-12-25 6:57 ` Dima Kogan
2016-12-25 13:54 ` Mark Oteiza
2017-01-06 1:14 ` Tino Calancha
2017-01-06 1:20 ` Dima Kogan
2017-01-06 1:27 ` Dima Kogan
2017-01-06 3:06 ` Mark Oteiza
2017-01-06 3:50 ` Tino Calancha
2017-01-06 4:16 ` Dima Kogan
2017-01-06 4:43 ` Mark Oteiza [this message]
2017-01-06 7:55 ` Eli Zaretskii
2017-01-06 8:03 ` Tino Calancha
2017-01-06 14:14 ` Dmitry Gutov
2017-01-07 1:54 ` Tino Calancha
2017-01-07 2:05 ` Mark Oteiza
2017-01-07 9:51 ` Dima Kogan
2017-01-07 11:16 ` Tino Calancha
2017-01-07 22:16 ` Dima Kogan
2017-01-07 22:27 ` Dmitry Gutov
2017-01-06 3:09 ` Mark Oteiza
2017-01-06 4:22 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h95cpzly.fsf@udel.edu \
--to=mvoteiza@udel.edu \
--cc=25105@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=dima@secretsauce.net \
--cc=npostavs@users.sourceforge.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).