From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: David Engster Newsgroups: gmane.emacs.bugs Subject: bug#25556: 26.0.50.1; Requiring uncompiled eieio issues obsoletion warnings Date: Sat, 28 Jan 2017 22:15:20 +0100 Message-ID: <87h94izy1j.fsf@engster.org> References: <878tpw1bml.fsf@engster.org> <83wpdfzmcg.fsf@gnu.org> <87ziibzigh.fsf@engster.org> <87o9yrs1bq.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485638182 14374 195.159.176.226 (28 Jan 2017 21:16:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 21:16:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25556@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 28 22:16:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXaLz-0002eQ-CZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 22:16:11 +0100 Original-Received: from localhost ([::1]:53176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXaM2-0002ST-Qk for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 16:16:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXaLt-0002SL-CY for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 16:16:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXaLq-0002Lj-8W for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 16:16:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXaLq-0002Lf-4W for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 16:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXaLp-0003GX-Mo for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 16:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Engster Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2017 21:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25556 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25556-submit@debbugs.gnu.org id=B25556.148563812412510 (code B ref 25556); Sat, 28 Jan 2017 21:16:01 +0000 Original-Received: (at 25556) by debbugs.gnu.org; 28 Jan 2017 21:15:24 +0000 Original-Received: from localhost ([127.0.0.1]:49454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXaLE-0003Fi-CK for submit@debbugs.gnu.org; Sat, 28 Jan 2017 16:15:24 -0500 Original-Received: from randomsample.de ([5.45.97.173]:40465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXaLD-0003FW-7X for 25556@debbugs.gnu.org; Sat, 28 Jan 2017 16:15:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=kYs8gKxRFZP1CJAMhHIcglYxyfJY0lC0CY+hb14UXC4=; b=sAnPwF9aL2u12J5/oluYRARueUyzRN1t9KoVej3h5TKhsl8ETkX71Jgn7vYZffVxquDhgsEZD5apQUI2kWJXFq1cCWBwstNpaUcGGpRXK7YPb0xIz19ur/leOcc9Nc9P; Original-Received: from ip4d16b353.dynamic.kabel-deutschland.de ([77.22.179.83] helo=isaac) by randomsample.de with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1cXaLB-0000OK-IO; Sat, 28 Jan 2017 22:15:21 +0100 In-Reply-To: <87o9yrs1bq.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 28 Jan 2017 09:31:37 -0500") Mail-Copies-To: never X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128736 Archived-At: 'npostavs' writes: > David Engster writes: > >> Eli Zaretskii writes: >>>> From: David Engster >>>> Date: Fri, 27 Jan 2017 21:38:58 +0100 >>>>=20 >>> >>>> I'm currently trying to fix compiler warnings during the CEDET compile >>>> in Emacs master, but there's one annoying problem I'm unsure how to >>>> fix. Whenever a file does (require 'eieio), and EIEIO is not yet >>>> byte-compiled, those two warnings are issued: >>>>=20 >>>> ../../emacs-lisp/eieio.el: =E2=80=98eieio-object-name-string=E2=80=99 = is an obsolete >>>> generic function (as of 25.1); use =E2=80=98eieio-named=E2=80=99 inste= ad. >>>> ../../emacs-lisp/eieio.el: =E2=80=98destructor=E2=80=99 is an obsolete= generic >>>> function (as of 26.1). >>>>=20 >>>> Since EIEIO is compiled pretty late, one is flooded with these warnings >>>> when compiling Emacs master. The warnings seems to come from the >>>> cl-defgeneric for `eieio-object-name-string' and `destructor'. How can >>>> this be dealt with? >>> >>> Is it possibel to arrange that these files be compiled sooner? We >>> already have some targets for similar purposes in lisp/Makefile. >> >> I'm sure that's possible, but why does the file that declares those >> constructs obsolete *itself* throw these warnings? I was hoping that >> this could be fixed instead. > > I'm not sure about `eieio-object-name-string', but the message about > `destructor' is because cl-defgeneric makes the declaration handling > code run before the function defining code, so the symbol is declared > obsolete before it's defined and the definition itself triggers the > obsolete warning. The patch below moves it around and stops the > `destructor' warning: Thanks for looking into to it, your patch works fine for me. Can this be applied? As for eieio-object-name-string, my guess is that this is caused by declaring it via cl-defgeneric as well as cl-defmethod (the latter even twice: in eieio.el and eieio-base.el). -David