From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#25816: Emacs xwidget GC issue with callback Date: Mon, 20 Feb 2017 19:01:51 +0100 Message-ID: <87h93oeo6o.fsf@linux-m68k.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487613732 11336 195.159.176.226 (20 Feb 2017 18:02:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2017 18:02:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: Ricardo Wurmus , Joakim Verona , 25816@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 20 19:02:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfsHl-0002Lm-Fb for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 19:02:05 +0100 Original-Received: from localhost ([::1]:40232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfsHr-0000zO-87 for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 13:02:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfsHl-0000ui-40 for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 13:02:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfsHi-00064r-2k for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 13:02:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cfsHh-00064m-VT for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 13:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cfsHh-0008Ka-Kg for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 13:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2017 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25816-submit@debbugs.gnu.org id=B25816.148761371832015 (code B ref 25816); Mon, 20 Feb 2017 18:02:01 +0000 Original-Received: (at 25816) by debbugs.gnu.org; 20 Feb 2017 18:01:58 +0000 Original-Received: from localhost ([127.0.0.1]:47741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfsHd-0008KI-4v for submit@debbugs.gnu.org; Mon, 20 Feb 2017 13:01:57 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]:55984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfsHb-0008K8-PT for 25816@debbugs.gnu.org; Mon, 20 Feb 2017 13:01:56 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3vRs014KSGz3hjl1; Mon, 20 Feb 2017 19:01:53 +0100 (CET) Original-Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3vRs010XtLzvkQX; Mon, 20 Feb 2017 19:01:53 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 7OihN0bE7ld6; Mon, 20 Feb 2017 19:01:52 +0100 (CET) X-Auth-Info: 9e4hDWlwDT1pS3NykmmnRUl/ApMPvrmfM/Dc3d3n9dEPXLCIJiUEChBrNr4bdXev Original-Received: from igel.home (ppp-88-217-8-189.dynamic.mnet-online.de [88.217.8.189]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 20 Feb 2017 19:01:52 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 723142C3C39; Mon, 20 Feb 2017 19:01:51 +0100 (CET) X-Yow: Hmmm.. a CRIPPLED ACCOUNTANT with a FALAFEL sandwich is HIT by a TROLLEY-CAR.. In-Reply-To: (Paul Eggert's message of "Mon, 20 Feb 2017 09:10:32 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129580 Archived-At: On Feb 20 2017, Paul Eggert wrote: > @@ -714,8 +717,13 @@ argument procedure FUN.*/) > if (!NILP (fun) && !FUNCTIONP (fun)) > wrong_type_argument (Qinvalid_function, fun); > > - void *callback = (FUNCTIONP (fun)) ? > - &webkit_javascript_finished_cb : NULL; > + GAsyncReadyCallback callback > + = FUNCTIONP (fun) ? webkit_javascript_finished_cb : NULL; > + > + /* FIXME: This hack might lead to disaster if FUN is garbage > + collected before store_xwidget_js_callback_event makes it visible > + to Lisp again. See the FIXME in webkit_javascript_finished_cb. */ > + gpointer callback_arg = (gpointer) (intptr_t) XLI (fun); When --with-wide-int, EMACS_INT may be wider than a pointer, and this discards the type bits. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."