unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: 26961@debbugs.gnu.org
Cc: Andreas Schwab <schwab@suse.de>
Subject: bug#26961: 26.0.50; Possible timming issue in regex-tests.el
Date: Fri, 19 May 2017 12:31:10 +0900	[thread overview]
Message-ID: <87h90hwmip.fsf@calancha-pc> (raw)
In-Reply-To: <83ziea4358.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 May 2017 18:04:51 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Tino Calancha <tino.calancha@gmail.com>
>> Cc: 26961@debbugs.gnu.org, tino.calancha@gmail.com
>> Date: Thu, 18 May 2017 16:00:31 +0900
>> 
>> The problem arise from the recursive call in mark_object:
>> mark_object (ptr->car);
>
> The recursive call cannot be the problem, as GC in general and
> mark_object in particular are by definition recursive.  The problem is
> elsewhere, and to track it down you need to look at the object that
> causes the problem.

Following diff hunk from commit
'Improve unescaped character literal warnings'
(16004397f4)
seems the origin of the problem: those lists with
defsym's in their heads.

diff --git a/src/lread.c b/src/lread.c
--- a/src/lread.c
+++ b/src/lread.c
@@ -963,9 +963,11 @@ load_warn_unescaped_character_literals (Lisp_Object file)
   AUTO_STRING (format,
                "Loading `%s': unescaped character literals %s detected!");
   AUTO_STRING (separator, ", ");
+  AUTO_STRING (inner_format, "`?%c'");
   CALLN (Fmessage,
          format, file,
-         Fmapconcat (Qstring,
+         Fmapconcat (list3 (Qlambda, list1 (Qchar),
+                            list3 (Qformat, inner_format, Qchar)),
                      Fsort (Vlread_unescaped_character_literals, Qlss),
                      separator));
 }

Do you think this code is wrong?





  reply	other threads:[~2017-05-19  3:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 10:19 bug#26961: 26.0.50; Possible timming issue in regex-tests.el Tino Calancha
2017-05-17 13:55 ` Tino Calancha
2017-05-17 16:32   ` Eli Zaretskii
2017-05-18  7:00     ` Tino Calancha
2017-05-18  7:50       ` Andreas Schwab
2017-05-18 15:04       ` Eli Zaretskii
2017-05-19  3:31         ` Tino Calancha [this message]
2017-05-19  7:14           ` Eli Zaretskii
2017-05-19 11:38             ` Tino Calancha
2017-05-20 10:04               ` Eli Zaretskii
2017-05-20 11:20                 ` Tino Calancha
2017-05-20 11:54                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h90hwmip.fsf@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=26961@debbugs.gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).