unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: 29367@debbugs.gnu.org, Richard Stallman <rms@gnu.org>
Subject: bug#29367: 27.0.50; State and doc of `inline'
Date: Tue, 21 Nov 2017 18:27:27 +0100	[thread overview]
Message-ID: <87h8tnsfsw.fsf@web.de> (raw)
In-Reply-To: <a8b52f4a-d1f7-4d5e-a262-38960d195fd6@default> (Drew Adams's message of "Tue, 21 Nov 2017 09:11:44 -0800 (PST)")

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Drew Adams <drew.adams@oracle.com> writes:

> In that case, it would seem to correspond to what, in
> Common Lisp, would be a declaration (`declare').
>
> In Common Lisp, declarations are supposed to be documented, even when
> implementation-specific.  They are something a user provides, so users
> need to know about them.

Glenn has already fixed it like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-emacs-lisp-byte-run.el-inline-Give-it-a-doc.patch --]
[-- Type: text/x-diff, Size: 935 bytes --]

From 8d450453fae4518f79f7f951d8c70e11f887a934 Mon Sep 17 00:00:00 2001
From: Glenn Morris <rgm@gnu.org>
Date: Tue, 21 Nov 2017 08:53:31 -0800
Subject: [PATCH] * lisp/emacs-lisp/byte-run.el (inline): Give it a doc.

---
 lisp/emacs-lisp/byte-run.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el
index abfcdb347a..e4f21c9d6d 100644
--- a/lisp/emacs-lisp/byte-run.el
+++ b/lisp/emacs-lisp/byte-run.el
@@ -286,8 +286,12 @@ defun
 
 \f
 ;; Redefined in byte-opt.el.
-;; This is not documented--it's not clear that we should promote it.
-(fset 'inline 'progn)
+;; This was undocumented and unused for decades.
+(defalias 'inline 'progn
+  "Like `progn', but when compiled inline top-level function calls in body.
+You don't need this.  (See bytecomp.el commentary for more details.)
+
+\(fn BODY...)")
 
 ;;; Interface to inline functions.
 
-- 
2.15.0


[-- Attachment #3: Type: text/plain, Size: 85 bytes --]


Given that it apparently should not be used in new code, I'm ok with it.


Michael.

  reply	other threads:[~2017-11-21 17:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 19:10 bug#29367: 27.0.50; State and doc of `inline' Michael Heerdegen
2017-11-20 21:40 ` Glenn Morris
2017-11-20 22:04   ` Eric Abrahamsen
2017-11-20 22:12   ` Michael Heerdegen
2017-11-21 16:11     ` Richard Stallman
2017-11-21 16:19       ` Drew Adams
2017-11-21 16:22       ` Andreas Schwab
2017-11-21 16:42       ` Michael Heerdegen
2017-11-21 17:11         ` Drew Adams
2017-11-21 17:27           ` Michael Heerdegen [this message]
2017-11-21 18:10           ` Andreas Schwab
2017-11-21 16:58   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8tnsfsw.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=29367@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).