From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#17231: [PATCH] term.el: unreliable directory tracking Date: Mon, 11 Dec 2017 20:37:35 -0500 Message-ID: <87h8swenfk.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513042695 31951 195.159.176.226 (12 Dec 2017 01:38:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Dec 2017 01:38:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 17231@debbugs.gnu.org To: Callum Cameron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 12 02:38:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOZWK-0007vN-7l for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Dec 2017 02:38:08 +0100 Original-Received: from localhost ([::1]:56286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOZWP-0008Pb-US for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Dec 2017 20:38:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOZWI-0008PT-Lq for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 20:38:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOZWE-0004CV-Nf for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 20:38:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOZWE-0004CL-Kl for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 20:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOZWE-000782-5Z for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 20:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2017 01:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17231 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17231-submit@debbugs.gnu.org id=B17231.151304266627375 (code B ref 17231); Tue, 12 Dec 2017 01:38:02 +0000 Original-Received: (at 17231) by debbugs.gnu.org; 12 Dec 2017 01:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:57494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOZVx-00077T-Q9 for submit@debbugs.gnu.org; Mon, 11 Dec 2017 20:37:45 -0500 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:46005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOZVw-00077D-41 for 17231@debbugs.gnu.org; Mon, 11 Dec 2017 20:37:44 -0500 Original-Received: by mail-it0-f42.google.com with SMTP id z6so20680177iti.4 for <17231@debbugs.gnu.org>; Mon, 11 Dec 2017 17:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ivaJebTUlGFiSTl1UWRz28dV+E9JxtONwgl/sTMYIl8=; b=GRk1D7eLAfI0Qkcs0tgqnwY83Ew5ifVgx2GcPvGIEQe/ZwTu0yVCpjcH854qDPQ4t3 HnxH5vI2xdr88pvOHShJZ5LLTK2S/e6izlQIjN2n+qXdUNTyxH50O9Ae4YoloSXY9aeL nmxHmMj3zEclPe0oDFr1q1X6/P8P3BUxm8K+Z1b6cqVS9/PaOQBN6AVoOpiZp8LJoODO rQly70N39WhJFpLlFMOG9beiXKyrikxl3atfpeB7pR/wG/5aIJs3tIglZAxrdmMjqtas Ulhw2NfTKFPg7ITQohTk3M8/kfdaWuch2q7DNFKbzM+qz+tZAcMBTbBAZWgHk2EOMAwB p7Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ivaJebTUlGFiSTl1UWRz28dV+E9JxtONwgl/sTMYIl8=; b=BPch9BugiyO7XRLOm2rUqzurVNHtp8aTAQKD+kM39kAefPizkC4sCjeMDSKtz2qcx1 CU3buHozY755QlpXuZlJRBM1AHmvT89CNqOz4vu9QAlerUpekZPDzG48DbV6o9rRza0y daNS4watdfQ06FXQXIW/JBoZQrGxTZdrXuUiwpySpj6yfEtQEgen7Ijn5NCj7zLAIB88 fAkcsgZp9NNFn6VqKy0iPJNXbKKhmIopl2Tc7e7atIisQ7XPau+tnteqTgv8mb4188iD JKAtVFZXVNUZuX5dgAL1aLNIgy5x0xDk4hRepwpD6Jvk6D+1zLos+Z9ONBr/rL+t59vt GeNA== X-Gm-Message-State: AKGB3mKp/ZhHCDIYDAzWpzQiud0hiRfNjCTpOXVlVqpTzogq4eFbaLSk 2xjEP7wxDnU7hxeZF8e4LgDKaw== X-Google-Smtp-Source: ACJfBovxx31efHVnoW/QxrSjifMhRCl3d1azw9HWwUjPeuVUeKmyc4yzpix1h7MPdIhPzcvadn2oTA== X-Received: by 10.36.25.205 with SMTP id b196mr386912itb.25.1513042658097; Mon, 11 Dec 2017 17:37:38 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o200sm4335115itg.10.2017.12.11.17.37.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 17:37:37 -0800 (PST) In-Reply-To: (Callum Cameron's message of "Wed, 9 Apr 2014 11:12:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140961 Archived-At: So this has been sitting for a while... Callum Cameron writes: > The patch checks to see if there is an incomplete command at the end > of term-emulate-terminal's input string, and, if so, saves it so the > whole command can be processed when the next string arrives. I'm a > Lisp newbie, so I don't know if this is the best way to do it, and it > isn't foolproof - if the command gets split in the 'AnSiT' magic, it > won't get handled. But I've never seen this happen (I've only ever > seen the trailing newline get split off), and I've been using it for a > few weeks without problems, and without any noticeable slowdown. The patch looks okay to me. It's a bit unfortunate that it adds yet another way to store partial strings; I have a patch which fixes things in a more unified way, but my patch rewrites too much to go on the release branch. So I think it would be nice if this patch could go to emacs-26. I presume you don't have copyright assignment (so the patch should be marked as a tiny change)? > + (defvar term-partial-ansi-terminal-message nil "Keep partial ansi > + terminal messages for future processing.") And this newline in the middle of the docstring should be fixed.