unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Callum Cameron <cjcameron7@gmail.com>
Cc: 17231@debbugs.gnu.org
Subject: bug#17231: [PATCH] term.el: unreliable directory tracking
Date: Mon, 11 Dec 2017 20:37:35 -0500	[thread overview]
Message-ID: <87h8swenfk.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CACZmLK89h0xcvSkypEVPGFiaKKjvURDfkdJRXMQLHWD3VSbMAQ@mail.gmail.com> (Callum Cameron's message of "Wed, 9 Apr 2014 11:12:25 +0100")

So this has been sitting for a while...

Callum Cameron <cjcameron7@gmail.com> writes:

> The patch checks to see if there is an incomplete command at the end
> of term-emulate-terminal's input string, and, if so, saves it so the
> whole command can be processed when the next string arrives. I'm a
> Lisp newbie, so I don't know if this is the best way to do it, and it
> isn't foolproof - if the command gets split in the 'AnSiT' magic, it
> won't get handled. But I've never seen this happen (I've only ever
> seen the trailing newline get split off), and I've been using it for a
> few weeks without problems, and without any noticeable slowdown.

The patch looks okay to me.  It's a bit unfortunate that it adds yet
another way to store partial strings; I have a patch which fixes things
in a more unified way, but my patch rewrites too much to go on the
release branch.

So I think it would be nice if this patch could go to emacs-26.  I
presume you don't have copyright assignment (so the patch should be
marked as a tiny change)?

> + (defvar term-partial-ansi-terminal-message nil "Keep partial ansi
> + terminal messages for future processing.")

And this newline in the middle of the docstring should be fixed.





  reply	other threads:[~2017-12-12  1:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 10:12 bug#17231: [PATCH] term.el: unreliable directory tracking Callum Cameron
2017-12-12  1:37 ` Noam Postavsky [this message]
2018-01-19  3:30   ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8swenfk.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=17231@debbugs.gnu.org \
    --cc=cjcameron7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).