unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry
@ 2018-01-19 18:59 Alex Branham
  2018-01-27 15:54 ` bug#30175: Follow-up Alex Branham
  2018-03-20  6:50 ` bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry Eli Zaretskii
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Branham @ 2018-01-19 18:59 UTC (permalink / raw)
  To: 30175

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

This patch activates the mark when running bibtex-mark-entry, making behavior consistent with e.g. mark-paragraph.

Can this make it into Emacs 26 (please)?

Thanks,
Alex

From d069aee2fed5f281f8fba2b0c430624462c94d27 Mon Sep 17 00:00:00 2001
From: Alex Branham <branham@utexas.edu>
Date: Fri, 19 Jan 2018 12:54:00 -0600
Subject: [PATCH] * lisp/textmodes/bibtex.el (bibtex-mark-entry): activate mark

---
 lisp/textmodes/bibtex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index a30e146892..a3f9804358 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -3871,7 +3871,7 @@ bibtex-reposition-window
 (defun bibtex-mark-entry ()
   "Put mark at beginning, point at end of current BibTeX entry."
   (interactive)
-  (push-mark (bibtex-beginning-of-entry))
+  (push-mark (bibtex-beginning-of-entry) :activate t)
   (bibtex-end-of-entry))
 
 (defun bibtex-count-entries (&optional count-string-entries)
-- 
2.16.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-textmodes-bibtex.el-bibtex-mark-entry-activate-.patch --]
[-- Type: text/x-patch, Size: 836 bytes --]

From d069aee2fed5f281f8fba2b0c430624462c94d27 Mon Sep 17 00:00:00 2001
From: Alex Branham <branham@utexas.edu>
Date: Fri, 19 Jan 2018 12:54:00 -0600
Subject: [PATCH] * lisp/textmodes/bibtex.el (bibtex-mark-entry): activate mark

---
 lisp/textmodes/bibtex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index a30e146892..a3f9804358 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -3871,7 +3871,7 @@ bibtex-reposition-window
 (defun bibtex-mark-entry ()
   "Put mark at beginning, point at end of current BibTeX entry."
   (interactive)
-  (push-mark (bibtex-beginning-of-entry))
+  (push-mark (bibtex-beginning-of-entry) :activate t)
   (bibtex-end-of-entry))
 
 (defun bibtex-count-entries (&optional count-string-entries)
-- 
2.16.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#30175: Follow-up
  2018-01-19 18:59 bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry Alex Branham
@ 2018-01-27 15:54 ` Alex Branham
  2018-03-20  6:50 ` bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry Eli Zaretskii
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Branham @ 2018-01-27 15:54 UTC (permalink / raw)
  To: 30175

Hello -

It's been about a week since I sent this patch and I haven't heard anything. Just sending a follow-up so it doesn't get lost in the shuffle.

FWIW I've been using it locally without ill effect.

Thanks again!
Alex





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry
  2018-01-19 18:59 bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry Alex Branham
  2018-01-27 15:54 ` bug#30175: Follow-up Alex Branham
@ 2018-03-20  6:50 ` Eli Zaretskii
  1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2018-03-20  6:50 UTC (permalink / raw)
  To: Alex Branham; +Cc: 30175-done

> From: Alex Branham <alex.branham@gmail.com>
> Date: Fri, 19 Jan 2018 12:59:02 -0600
> 
> This patch activates the mark when running bibtex-mark-entry, making behavior consistent with e.g. mark-paragraph.
> 
> Can this make it into Emacs 26 (please)?

Pushed to the emacs-26 branch.  Thanks.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-20  6:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 18:59 bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry Alex Branham
2018-01-27 15:54 ` bug#30175: Follow-up Alex Branham
2018-03-20  6:50 ` bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).