From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Mon, 12 Feb 2018 23:50:55 +0200 Organization: LINKOV.NET Message-ID: <87h8qlubb4.fsf@mail.linkov.net> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> <83fu692jdu.fsf@gnu.org> <87lgg0sgbz.fsf@mail.linkov.net> <83bmgv1ol3.fsf@gnu.org> <873727xxvf.fsf@linux-m68k.org> <8360731lr9.fsf@gnu.org> <87d11bwfly.fsf@linux-m68k.org> <83y3jzz7hr.fsf@gnu.org> <87vaf3cjbg.fsf@mail.linkov.net> <83bmguyt9w.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1518473357 28105 195.159.176.226 (12 Feb 2018 22:09:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Feb 2018 22:09:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 19045@debbugs.gnu.org, schwab@linux-m68k.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 12 23:09:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elMHc-0006hF-MI for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 23:09:08 +0100 Original-Received: from localhost ([::1]:59576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elMJc-0000EZ-Aa for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 17:11:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elMJT-0000CD-L0 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 17:11:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elMJS-0007UQ-NL for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 17:11:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60485) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elMJS-0007U6-JN for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 17:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elMJS-00047f-7b for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 17:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2018 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151847346015839 (code B ref 19045); Mon, 12 Feb 2018 22:11:02 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 12 Feb 2018 22:11:00 +0000 Original-Received: from localhost ([127.0.0.1]:40149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elMJP-00047P-PU for submit@debbugs.gnu.org; Mon, 12 Feb 2018 17:10:59 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:50153 helo=homiemail-a22.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elMJO-00047H-6k for 19045@debbugs.gnu.org; Mon, 12 Feb 2018 17:10:58 -0500 Original-Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id 6463311406A; Mon, 12 Feb 2018 14:10:57 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-100-74.cust.tele2.ee [91.129.100.74]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPSA id 47413114068; Mon, 12 Feb 2018 14:10:56 -0800 (PST) In-Reply-To: <83bmguyt9w.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Feb 2018 20:09:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143228 Archived-At: >> In the command line of git version 1.9.1 running git log on two files >> (command line copied from *Messages* when vc-command-messages is t) >>=20 >> git --no-pager log --no-color --follow -n 2000 -- vc-dispatcher.el v= c-git.el >>=20 >> fails with the error: >>=20 >> usage: git logs can only follow renames on one pathname at a time >>=20 >> whereas running git on one directory =E2=80=98vc=E2=80=99 >>=20 >> git --no-pager log --no-color --follow -n 2000 -- vc >>=20 >> doesn't fail. Although I can't confirm the correctness of the output = log: >> it seems the option =E2=80=98--follow=E2=80=99 has no effect on direct= ories. > > Even if it's true, it means --follow doesn't do any harm when invoked > on directories, and we shouldn't disallow that. I don't know the reason why disallowing directories was implemented in the first place. Maybe =E2=80=98git log --follow=E2=80=99 failed on d= irectories in some older git versions? Wouldn't it be safer to leave the code that checks for directories and doesn't add =E2=80=98--follow=E2=80=99 fo= r this case?