From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31793: 26.1; (error "Lisp nesting exceeds =?UTF-8?Q?=E2=80=98max-lisp-eval-depth=E2=80=99?=") Date: Wed, 04 Jul 2018 18:38:40 -0400 Message-ID: <87h8lelj7z.fsf@gmail.com> References: <99D8E495-B396-4266-8BF1-BA0B609DEC3D@gnu.org> <87k1qpsdxc.fsf@gmail.com> <87in5wxoat.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530743829 10480 195.159.176.226 (4 Jul 2018 22:37:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jul 2018 22:37:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31793@debbugs.gnu.org, Leo Liu To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 05 00:37:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faqOR-0002WF-Uf for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2018 00:37:00 +0200 Original-Received: from localhost ([::1]:49454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faqQZ-0003eQ-4t for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2018 18:39:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faqQT-0003e8-8G for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faqQQ-0007fX-4v for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faqQQ-0007fL-0e for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1faqQP-0003pC-N6 for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jul 2018 22:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31793 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31793-submit@debbugs.gnu.org id=B31793.153074392914685 (code B ref 31793); Wed, 04 Jul 2018 22:39:01 +0000 Original-Received: (at 31793) by debbugs.gnu.org; 4 Jul 2018 22:38:49 +0000 Original-Received: from localhost ([127.0.0.1]:47062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faqQD-0003om-A3 for submit@debbugs.gnu.org; Wed, 04 Jul 2018 18:38:49 -0400 Original-Received: from mail-it0-f45.google.com ([209.85.214.45]:54212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faqQB-0003oY-V9 for 31793@debbugs.gnu.org; Wed, 04 Jul 2018 18:38:48 -0400 Original-Received: by mail-it0-f45.google.com with SMTP id a195-v6so9465221itd.3 for <31793@debbugs.gnu.org>; Wed, 04 Jul 2018 15:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Hx8kiSPBsOJhtRtnXYAVLSvo/RZCdvy/KveEox+Vji8=; b=t6+5EqmhkUOyLLeD3KYDeYscr5WX/k+iVmPEjrR6CIlFhILFyP7BKA0txnPGQu2YnV Xp2rwa3Pb5lmMA0M0IRoLsUpx9+goCEcXYubNGXLd+BbAyZ6xK7g98x5v0LUQlzU6AWk E8nUASowZxSebYl9g3zBlguIPWvMaPGNL61gt9ZaPNkldcgRhDqtY/UKAiWZYevYwa7m hnZgOIu/lqSibg15ua4CLza8FBoouk8qN8dcVaHswSuHn0TZV9H8W2h38AFusr8QyDPW MMWjfaGo/P+lbNw7Y21kXnq3GzwHgT3AMCp6f1jn8CQbaS3AGQu51t8iS/I2eTbcQOOc sjbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Hx8kiSPBsOJhtRtnXYAVLSvo/RZCdvy/KveEox+Vji8=; b=KpUtFUImdvVHzj3ozV61LEkwQIKkfa+oXspB7hfy3eaLC4mvHIDQlTeRkHCEwsH5Bz 1YYrxG8GHB8LSJH4gewzEBrKMGPpT4+1z1zInxnWO08B31lZ7a0050/IrfO+TYnwhkYR nQtMYsYSozdGo4nWHbBMST944F7rJUC/JiwFzq0YxbY4V1ZsFQcL6rgEZ0H1Zuh+LoyR 8+238BXbbutkfwkuUm8I81RhC0M/xzaRLO+DaMOyheNA4+bqpTZJ4YXEyDf0Fp7m4vh4 P0Az6FVUZyyBzRD6z6oYeDx8aN4Af1H9cnr15H0enz548ySzf5UIxeErFNfHj2i46DQP B/gQ== X-Gm-Message-State: APt69E3OJiyW4opgTzGeEVC1K1makB2dPwa05x7oHYtY3MiQR+W8xqwh IocL2vITZBArv8Yy4XsLhOQ= X-Google-Smtp-Source: AAOMgpd7oRm0FtQN5sWCz9aHnQeVSEZngadUdo1TkJlxN4KIbjPla7dr2juowdWRKHrLVLWQ5y81ZQ== X-Received: by 2002:a24:5004:: with SMTP id m4-v6mr3000450itb.38.1530743922470; Wed, 04 Jul 2018 15:38:42 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k21-v6sm2474518itb.28.2018.07.04.15.38.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Jul 2018 15:38:41 -0700 (PDT) In-Reply-To: <87in5wxoat.fsf@gmail.com> (John Shahid's message of "Tue, 03 Jul 2018 16:43:38 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148208 Archived-At: John Shahid writes: >> That seems to be a result of converting `global-eldoc-mode' to use >> `define-globalized-minor-mode' in 2349f. The recursive call seems to be >> a result of the following sequence of calls: >> >> 1. python-mode is enabled which adds an eldoc-mode-hook >> 2. eldoc-mode is turned on in the buffer triggering python's >> eldoc-mode-hook >> 3. python-mode hook will start an inferior process which in turn trigger >> ,MODE-enable-in-buffers >> 4. ,MODE-enable-in-buffers will go over the list again trying to enable >> eldoc-mode >> >> The problem is in step 4. The eldoc-global-mode buffer list isn't reset >> in step 2. Step 4 will try to enabe the mode for the same buffer and >> start a sequence of calls at 2. I was able to fix this problem by >> setting the buffer-list to nil inside ,MODE-enable-in-buffers. I >> attached a patch below. Looks good to me. I guess there is some risk since we are modifying a macro which affects a lot of modes, but when balanced against the "risk" that we actually fix similar problems in those modes I think this should go to emacs-26. > Added the bug number to the changelog entry and attached a new patch. > >>>From 893e62ee7e3630c981adb3efa39ef409500d7657 Mon Sep 17 00:00:00 2001 > From: John Shahid > Date: Sat, 23 Jun 2018 11:12:44 -0400 > Subject: [PATCH] Avoid turning on the global-minor-mode recursively > (Bug#31793) > > * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Reset > the buffer-list inside ,MODE-enable-in-buffers to avoid enabling the > mode recursively I would drop that comma from the commit message though, it's not really part of the variable name, it's only meaningful in the context of a backquote (and you forgot the period at the end of the sentence).