From: Noam Postavsky <npostavs@gmail.com>
To: Mike Kazantsev <mk.fraggod@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 31901@debbugs.gnu.org
Subject: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1
Date: Mon, 06 Aug 2018 16:36:28 -0400 [thread overview]
Message-ID: <87h8k7xmer.fsf@gmail.com> (raw)
In-Reply-To: <20180722215540.63fc8782@malediction> (Mike Kazantsev's message of "Sun, 22 Jul 2018 21:55:40 +0500")
Mike Kazantsev <mk.fraggod@gmail.com> writes:
> On Sun, 22 Jul 2018 21:42:07 +0500
> Mike Kazantsev <mk.fraggod@gmail.com> wrote:
>
>> == How it works in current emacs-git [8f3bca3ad51]:
>>
>> (make-network-process
>> ...
>> :family 'local
>> :service "/tmp/does-not-exist.sock"
>> :nowait t
>> :sentinel #'unix-socket-test-func)
>>
>> => #<process unix-socket-test>
>> [sentinel never called]
>>
>> (process-live-p socket) => nil
>> (process-status socket) => 'file-missing
>>
>> Note that this is:
>>
>> - Not consistent with what emacs did before this bug.
>
> After sending previous mail, realized that maybe it is consistent with
> emacs 26.0 or similar version before the bug which I've never tested,
> where change was made to behave exactly like that, but then this bug
> changed it again.
I believe the behaviour changed with the introduction of the bug (by the
way, Emacs releases are XX.y where y > 1, so there was never a 26.0
release).
So the situation is not ideal, but I do think that it's acceptable as a
compromise. Shall we backport and close the bug?
next prev parent reply other threads:[~2018-08-06 20:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 5:43 bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Mike Kazantsev
2018-07-01 15:21 ` Noam Postavsky
2018-07-06 8:59 ` Eli Zaretskii
2018-07-14 8:20 ` Eli Zaretskii
2018-07-20 9:16 ` Eli Zaretskii
2018-07-20 10:08 ` Lars Ingebrigtsen
2018-07-20 12:17 ` Eli Zaretskii
2018-07-22 11:40 ` Lars Ingebrigtsen
2018-07-22 14:11 ` Eli Zaretskii
2018-07-22 14:31 ` Lars Ingebrigtsen
2018-07-22 14:54 ` Mike Kazantsev
2018-07-22 15:23 ` Lars Ingebrigtsen
2018-07-22 15:38 ` Mike Kazantsev
2018-07-22 15:56 ` Eli Zaretskii
2018-07-22 16:42 ` Mike Kazantsev
2018-07-22 16:55 ` Mike Kazantsev
2018-08-06 20:36 ` Noam Postavsky [this message]
2018-08-07 15:48 ` Eli Zaretskii
2018-08-08 23:51 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8k7xmer.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31901@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mk.fraggod@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).