From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today Date: Wed, 21 Nov 2018 01:14:12 +0200 Organization: LINKOV.NET Message-ID: <87h8gb5owm.fsf@mail.linkov.net> References: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542755652 13586 195.159.176.226 (20 Nov 2018 23:14:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Nov 2018 23:14:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33446@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 21 00:14:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFDa-0003NN-HF for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 00:14:06 +0100 Original-Received: from localhost ([::1]:36452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPFFh-0001Un-0l for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Nov 2018 18:16:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPFFW-0001U9-Hc for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 18:16:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPFFT-0008G1-DV for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 18:16:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33296) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPFFT-0008Fq-9A for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 18:16:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPFFT-0003s5-2f for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 18:16:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Nov 2018 23:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33446-submit@debbugs.gnu.org id=B33446.154275573614831 (code B ref 33446); Tue, 20 Nov 2018 23:16:03 +0000 Original-Received: (at 33446) by debbugs.gnu.org; 20 Nov 2018 23:15:36 +0000 Original-Received: from localhost ([127.0.0.1]:37553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFF2-0003r9-DC for submit@debbugs.gnu.org; Tue, 20 Nov 2018 18:15:36 -0500 Original-Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:27647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFF1-0003r0-56 for 33446@debbugs.gnu.org; Tue, 20 Nov 2018 18:15:35 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1A989680C30; Tue, 20 Nov 2018 23:15:34 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id DB9C6680C51; Tue, 20 Nov 2018 23:15:33 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 20 Nov 2018 23:15:34 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Broad-Coil: 0b0618776b791ee0_1542755733980_154849828 X-MC-Loop-Signature: 1542755733980:2242352055 X-MC-Ingress-Time: 1542755733979 Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id A2776808BC; Tue, 20 Nov 2018 15:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=fwyHO6dzOlSEjL4rC3dBVtA3FCY=; b= uLCudgd94kdm9Jgt13ARsrClOpa1npY0Nz0xDWONkiUAU86smVpMkbAcTGoDLgTt vVbFWAPB32I5sZZYO50HFk9n3lrh2tR++axRu4ZqAaAy1im9H1rBrB9N8IHZoCey 8TtC+8OrIaQxbSCidlkp1+4RN2lN3rypMCY558Fy9FM= Original-Received: from mail.jurta.org (m91-129-105-252.cust.tele2.ee [91.129.105.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id 3D052808AD; Tue, 20 Nov 2018 15:15:31 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a37 In-Reply-To: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> (Drew Adams's message of "Tue, 20 Nov 2018 13:10:50 -0800 (PST)") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddtiedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrddvhedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrvdehvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgepud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152600 Archived-At: > The proximate cause of the error was likely due to > my calling `isearch-lazy-highlight-update' outside > searching (i.e., nil `isearch-mode'). But I think > there might still be a bug in the Isearch code. isearch-lazy-highlight-update is not intended to be used in a window other than the window where isearch-lazy-highlight-new-loop was called. It has many dependencies on the original window being selected. > The `isearch-lazy-highlight-update' code does this: > > (save-selected-window > (if (and (window-live-p isearch-lazy-highlight-window) > (not (memq (selected-window) > isearch-lazy-highlight-window-group))) > (select-window isearch-lazy-highlight-window)) > > That causes the window in the other frame to be selected. It should select the same window where isearch-lazy-highlight-new-loop was called. > The code then does this: > > (setq window-start (window-group-start)) > (setq window-end (window-group-end)) > > This causes `window-end' to be nil. Should `window-group-*' here > be passed window `isearch-lazy-highlight-window'? isearch-lazy-highlight-window should not be passed here because it's guaranteed to be selected by the code above.