From: Michael Albinus <michael.albinus@gmx.de>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 34196@debbugs.gnu.org
Subject: bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode
Date: Tue, 05 Feb 2019 21:07:19 +0100 [thread overview]
Message-ID: <87h8diov7s.fsf@gmx.de> (raw)
In-Reply-To: <CAHyO48zH6OtZvj_NKwfJ1b9DF_6fZatqfjexYdWgzACZfwfy+w@mail.gmail.com> (Aaron Jensen's message of "Tue, 5 Feb 2019 11:27:06 -0800")
Aaron Jensen <aaronjensen@gmail.com> writes:
>> No, I haven't tried. But auto-revert-notify-add-watch is called after
>> auto-revert-active-p, so it's not sufficient to test it such late.
>
> Not sufficient for what, exactly? Testing it only in
> auto-revert-notify-add-watch prevents the hang for me. The only thing
> it wouldn't prevent is auto-revert-handler getting called, but that
> doesn't seem to have any negative impact as far as I could tell, but I
> could be missing an edge case.
As I said earlier, I've tried to add the test in auto-revert-active-p,
and this wasn't successful; the problem still happened.
And auto-revert-notify-add-watch is called only if auto-revert-active-p
returns non-nil.
> Aaron
Best regards, Michael.
next prev parent reply other threads:[~2019-02-05 20:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 15:36 bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode Aaron Jensen
2019-01-27 14:34 ` Aaron Jensen
2019-01-27 14:52 ` Aaron Jensen
2019-01-27 17:25 ` Michael Albinus
2019-02-04 15:06 ` Michael Albinus
[not found] ` <CAHyO48wRgVX-eNUHQXADEhOh3fHksVggxjKu23-=G_PSZzy-iQ@mail.gmail.com>
2019-02-05 12:51 ` Michael Albinus
2019-02-05 16:43 ` Aaron Jensen
2019-02-05 17:59 ` Michael Albinus
2019-02-05 18:14 ` Aaron Jensen
2019-02-05 19:22 ` Michael Albinus
2019-02-05 19:27 ` Aaron Jensen
2019-02-05 20:07 ` Michael Albinus [this message]
2019-02-05 22:41 ` Aaron Jensen
2019-02-06 8:11 ` Michael Albinus
2019-02-13 19:00 ` bug#34196: Error in auto-revert-buffers: Wrong type argument Alex Branham
2019-02-13 23:09 ` Michael Albinus
2019-02-14 17:05 ` Alex Branham
2019-02-14 20:25 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8diov7s.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=34196@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).