* bug#35688: url-auth prompt is blank when realm is the empty string
@ 2019-05-11 20:38 Thomas Fitzsimmons
2019-05-15 4:15 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Fitzsimmons @ 2019-05-11 20:38 UTC (permalink / raw)
To: 35688
Hi,
When a website returns an empty string for realm, url-get-authentication
prompts:
Username [for ]:
See for example:
(url-retrieve-synchronously "https://outlook.office365.com/EWS/Exchange.asmx")
The attached patch makes the prompt contain the full URL, and applies to
all auth schemes. However, maybe each auth scheme should decide how to
handle a "" realm and to fix this particular case I should just change
url-basic-auth? I'm open to suggestions.
Anyway, I'm filing this bug because I think prompting for a username and
password while not showing the user the requested URL is a usability
problem.
Thomas
diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index 0746cfd96c..f644787cc6 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -478,6 +478,8 @@ url-get-authentication
if one cannot be found in the cache"
(if (not realm)
(setq realm (cdr-safe (assoc "realm" args))))
+ (if (equal realm "")
+ (setq realm nil))
(if (stringp url)
(setq url (url-generic-parse-url url)))
(if (or (null type) (eq type 'any))
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-15 4:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-11 20:38 bug#35688: url-auth prompt is blank when realm is the empty string Thomas Fitzsimmons
2019-05-15 4:15 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).