From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#30626: 26.0.91; Crash when traversing a `stream-of-directory-files' Date: Sun, 26 May 2019 02:32:49 +0200 Message-ID: <87h89iukb2.fsf@web.de> References: <87inaiss6l.fsf@web.de> <6FCF6ACA-4F29-4B6B-BE9D-D7130C6E9495@gnu.org> <87fu5moe4c.fsf@web.de> <877eqyocro.fsf@web.de> <83zi3uz4nb.fsf@gnu.org> <87lgfd52by.fsf@gmail.com> <87bmg91ity.fsf@web.de> <87imv2rcs3.fsf@gmail.com> <87y33ybr1a.fsf@web.de> <877eay30qf.fsf@web.de> <87muja8eh9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187268"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Nicolas Petton , 30626@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 26 02:34:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hUh78-000mZl-Sy for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 May 2019 02:34:15 +0200 Original-Received: from localhost ([127.0.0.1]:48618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUh77-00045T-9J for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 May 2019 20:34:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUh6x-00045M-K7 for bug-gnu-emacs@gnu.org; Sat, 25 May 2019 20:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUh6w-0007zN-K9 for bug-gnu-emacs@gnu.org; Sat, 25 May 2019 20:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUh6w-0007z9-Fa for bug-gnu-emacs@gnu.org; Sat, 25 May 2019 20:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUh6v-0006bW-NL for bug-gnu-emacs@gnu.org; Sat, 25 May 2019 20:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2019 00:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30626-submit@debbugs.gnu.org id=B30626.155883078825311 (code B ref 30626); Sun, 26 May 2019 00:34:01 +0000 Original-Received: (at 30626) by debbugs.gnu.org; 26 May 2019 00:33:08 +0000 Original-Received: from localhost ([127.0.0.1]:49961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUh64-0006aB-Hl for submit@debbugs.gnu.org; Sat, 25 May 2019 20:33:08 -0400 Original-Received: from mout.web.de ([212.227.15.4]:44899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUh62-0006Zh-Hl for 30626@debbugs.gnu.org; Sat, 25 May 2019 20:33:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1558830773; bh=fBwcwLrUXCDmognS3spfb8utWoRRSQI78+6B7uDoQco=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bcmMuKu3Za49Yeb7t9frWawRmC3G8r5Vm9T2z07w/S6uuFZrLWJAkz0M/VC5wj2cg L0dTxCZ5vmOpda1B22L2+n+QDrSR2vtj9/SIENbUDQSikuslSni3JbZfk092hLF+at 1sMrN5oW2Vb5u9F1EYZ1HvRVGmL/J8LT0vjA6XX0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.110.143.34]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MUEsc-1h4oEw3tAo-00R59n; Sun, 26 May 2019 02:32:53 +0200 In-Reply-To: <87muja8eh9.fsf@gmail.com> (Noam Postavsky's message of "Sat, 25 May 2019 16:29:38 -0400") X-Provags-ID: V03:K1:hHd2iUrvoWq16foRCw39CBKt749GK0P/LxxIDb9JbRzXeOjaRC0 rTyVXTsQEVg46psa1ZO2XbiM5ee7lI1gcy0kIFg7URvmjVpczAX2+WjG22Kd0MiBudNEQ43 RQ/Gaxe4IAY1MV5+r5z3HmaJbPF6RYrMG1XnnMS3F9Fc5f4ra6Gh6pg8+gK0Sdmfi4BmZ6r D4a8ajqw9NvYLpstJL06w== X-UI-Out-Filterresults: notjunk:1;V03:K0:c3WSHbCanu0=:8HVVLxpKbmG87vuldxQv/j 3rNikAhemqr45tTnN/kDtVYA05FCelNc7bLf4yGxMauI/1t3TU40TWEDbTPL12VeKnYvTOaPi njUbmzA5NZZwgt8PrDGAcV/t+0IGcjEfRxKI9uU/ezEXUk2ksRZp3Qx2lvhLfZXiRGZlh3Yd7 dyGBGJu8/j+tINCjgPkg+LNfdQcgLbE1x0+7QSLX92Lr5wpb98GqH0dG+JsQI9S3+gXQBEQwI UlgbgNjValUOMSooOVlzw7ucU79eN/stioqwqMd9T7bgqK+5IJnnEogPnU0hjlVEUtancxr/s RS5n/mw4q5aGQGT6SFsJI9HpV1btbeE9lPQ+9hGMka5ZmgDbqkpRvl/e0WbZznqjCptdykAz/ mwxkGsz2LQLkVQCINRhXF9pyv5o8PM9ECUs6uEKr26grZkPuINaeJkrOHR15+K6gAV+ae4CiY XlKvT414N3qlSEFiFD8eZTaxKtKDK8IZmgFzbddtGAd7oZVCmY68R77AoBnL3iGFJo+S+5+7h ujBtdUOtzA45zTxpgTAVGo/eb8lI/IV7R6qYTkwwHZy3JrPBPLgMKLFfYqnELsjUz9EDB7gBm 1YfYOIQuyHwaV9miZn6twl2Yjq/2Gx69Rvcr9ganmeXbryBKCB26uF2tLqUUnDNuF8x8x+Fbd 9C3V368AdzmEVPWvKk85xwb+Mwf5qwhTirIbZWGJ3WqF30hFqvdnpgC6DgQQTjZ1jE6h2mo60 CGdgK3WAfIVUs1NQrklaW041YDGlQBf7J+E+fQNU0DlRdTYBwBg/NsNP9czu7mfQSz+XBPE8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159776 Archived-At: Noam Postavsky writes: > >> > - stream-make should use cons instead of list (or maybe a struct?). > >> > >> I think cons would be ok. Would a struct make things slower? > > A struct might be slower, and cons has the advantage that the print > output is more readable for humans too. E.g., with this code: [...] I see no reason not to switch to cons. Better readable, and less cons garbage than with `list'. Would you like to do this? > >> > - stream-empty should just be a constant. > >> > >> Dunno if there are cases where this would be problematic, but I > >> guess we > >> could do this as well. > > I've done this in the patch below. Passes all the tests, and I can't > see why it would be problematic. Looks good to me. Also passes my tests (which are all my stream.el uses, including el-search.el). > > @Nicolas: Do you want us to care about this or do you want to have a > > look yourself? I don't want to hurry, I just don't want this to be > > forgotten. If you say you have time in four months, it's still ok. > > Not getting any response; I'll wait another week for comments and then > push. Ok, let's do this. Thanks, Michael.