From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: Dmitri Paduchikh <dpaduchikh@gmail.com>,
24573@debbugs.gnu.org, Win Treese <treese@acm.org>
Subject: bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable
Date: Sat, 06 Jul 2019 14:42:35 -0400 [thread overview]
Message-ID: <87h87z3sys.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkm=h+kVXms9M7MxMNcjN3pds0_qaGuUyJ8PA-+7bTAjWhQ@mail.gmail.com> (Stefan Kangas's message of "Tue, 2 Jul 2019 18:22:46 +0200")
tags 24573 fixed
close 24573 27.1
quit
Stefan Kangas <stefan@marxist.se> writes:
>> - (help-args . ,(cdr help-xref-stack-item))
>> + (help-args . ,(mapcar (lambda (a)
>> + (if (bufferp a) (buffer-name a) a))
>> + (cdr help-xref-stack-item)))
> I can confirm this bug, which I've recently stumbled into myself.
>
> I can also confirm that Noam Postavsky's fix works.
Ah right, kind of forgot about this. Now pushed to master.
8d43315cfa 2019-07-06T14:34:47-04:00 "Use buffer's name for help-mode bookmarks (Bug#24573)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8d43315cfa3db295736826272472ec1e394ecb60
prev parent reply other threads:[~2019-07-06 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 14:13 bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable Dmitri Paduchikh
2017-10-28 18:53 ` Win Treese
2017-10-28 19:48 ` Noam Postavsky
2019-07-02 16:22 ` Stefan Kangas
2019-07-06 18:42 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h87z3sys.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=24573@debbugs.gnu.org \
--cc=dpaduchikh@gmail.com \
--cc=stefan@marxist.se \
--cc=treese@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).