unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Gemini Lasswell <gazally@runbox.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	36566@debbugs.gnu.org, Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: bug#36566: 27.0.50; debug is sometimes horribly slow
Date: Wed, 31 Jul 2019 21:05:01 -0400	[thread overview]
Message-ID: <87h871u24i.fsf@gmail.com> (raw)
In-Reply-To: <8736ilaepu.fsf@runbox.com> (Gemini Lasswell's message of "Wed, 31 Jul 2019 17:53:17 -0700")

Gemini Lasswell <gazally@runbox.com> writes:

> The third patch attached below fixes that by adding a macro to
> cl-print.el to wrap the printing of all the simple things with
> let-bindings of print-circle and print-gensym to nil.

> Patch #3 has the advantage of being straightforward logically and not
> breaking anything which doesn't use cl-prin1, but it undoubtedly also
> slows down cl-prin1 in the probably more common case that print-gensym
> and print-circle are both nil.  There are other ways to fix this, such
> as by adding a new entry point in print.c for printing simple strings,
> or by modifying the logic in print_preprocess to not create a hash table
> if the top-level object is a string with no properties.

This last idea sounds like a straightforward win to me, with no obvious
drawbacks.  I mean, no point in allocating a hash table if we can
cheaply detect it will never be used, right?






  reply	other threads:[~2019-08-01  1:05 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  3:09 bug#36566: 27.0.50; debug is sometimes horribly slow Michael Heerdegen
2019-07-10  3:18 ` Drew Adams
2019-07-10 11:20 ` Noam Postavsky
2019-07-10 22:46   ` Michael Heerdegen
2019-07-14  0:02     ` Gemini Lasswell
2019-07-15  2:05       ` Michael Heerdegen
2019-08-01  1:06         ` Gemini Lasswell
2019-08-01  0:53       ` Gemini Lasswell
2019-08-01  1:05         ` Noam Postavsky [this message]
2019-08-05 19:53           ` Gemini Lasswell
2019-08-19  1:30             ` Noam Postavsky
2019-09-06 16:41               ` Gemini Lasswell
2019-09-11  2:54                 ` Noam Postavsky
2019-09-13 21:08                   ` Gemini Lasswell
2019-09-14 13:44                     ` Mauro Aranda
2019-09-14 14:05                       ` Eli Zaretskii
2019-09-14 14:16                         ` Mauro Aranda
2019-09-14 15:47                           ` Eli Zaretskii
2022-04-25 14:41                     ` Lars Ingebrigtsen
2022-04-25 23:23                       ` Michael Heerdegen
2022-04-27  0:37                       ` Gemini Lasswell
2022-04-27  4:42                         ` Michael Heerdegen
2022-04-27 12:28                           ` Lars Ingebrigtsen
2022-04-28 17:56                             ` Gemini Lasswell
2022-05-13 16:01                               ` Lars Ingebrigtsen
2022-05-14  3:57                                 ` Michael Heerdegen
2022-05-14 11:35                                   ` Lars Ingebrigtsen
2022-05-14 13:52                                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-14 15:45                                       ` Lars Ingebrigtsen
2022-05-14 16:05                                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-14 16:18                                           ` Lars Ingebrigtsen
2022-05-14 16:54                                             ` Lars Ingebrigtsen
2022-05-14 18:55                                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-15 12:25                                                 ` Lars Ingebrigtsen
2022-05-15 13:33                                                   ` Lars Ingebrigtsen
2022-05-15 16:13                                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-15 16:25                                                     ` Lars Ingebrigtsen
2022-05-15 16:52                                                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-16  1:00                                                         ` Lars Ingebrigtsen
2022-05-16  1:39                                                           ` Michael Heerdegen
2022-05-16  1:44                                                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-16 12:11                                                             ` Lars Ingebrigtsen
2022-05-15  7:47                                           ` Rudolf Schlatte
2022-05-15 12:28                                             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h871u24i.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=36566@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).