unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17052@debbugs.gnu.org, lekktu@gmail.com
Subject: bug#17052: substitute-command-keys strips text properties
Date: Thu, 15 Aug 2019 15:42:18 -0700	[thread overview]
Message-ID: <87h86iuk39.fsf@mouse.gnus.org> (raw)
In-Reply-To: <83sgq2peb5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Aug 2019 19:46:06 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> Heh, heh:
>> 
>>     (Fsubstitute_command_keys): Don't advertise the fact that
>>     text-properties are dropped, since we think it's a bug that we'll fix
>>     in 24.5.
>> 
>> Should I just put it back in the doc string, or do we still think that
>> we'll fix it?
>
> I don't think it matters (unless you want to fix this right now ;-).

I had a look at that function now and, er, no.  :-)  Perhaps it should
be rewritten in Emacs Lisp?  Then it'd be pretty trivial to fix this
stuff.

> We should document the situation and leave the bug open for the
> possibility that someone would like to work on this.

Document the situation by just putting back into the doc string that it
doesn't copy text properties in some situations?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-08-15 22:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 16:22 bug#17052: substitute-command-keys strips text properties Juanma Barranquero
2019-08-15  0:55 ` Lars Ingebrigtsen
2019-08-15  1:34   ` Glenn Morris
2019-08-15  1:58     ` Lars Ingebrigtsen
2019-08-15 16:46       ` Eli Zaretskii
2019-08-15 22:42         ` Lars Ingebrigtsen [this message]
2019-08-16  6:47           ` Eli Zaretskii
2019-08-16  7:04             ` Lars Ingebrigtsen
2019-08-18 17:08           ` Stefan Kangas
2019-08-18 17:19             ` Eli Zaretskii
2019-08-18 22:43               ` Lars Ingebrigtsen
2019-08-19 15:27                 ` Eli Zaretskii
2019-08-18 17:19             ` Lars Ingebrigtsen
2020-11-17  1:24     ` Stefan Kangas
2020-11-17  1:37 ` bug#17052: substitute-command-keys strips text properties, bug#8911: huh? Drew Adams
2020-11-17  2:34   ` Stefan Kangas
2020-11-17  3:00     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h86iuk39.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=17052@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).