From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32452: 26.1; gnutls_try_handshake maxes out cpu retrying when server is a bit busy Date: Tue, 24 Sep 2019 07:39:08 +0200 Message-ID: <87h85245j7.fsf@gnus.org> References: <87wosqwlu3.fsf@gmail.com> <83d0uiig3j.fsf@gnu.org> <83zhxmgqrh.fsf@gnu.org> <87r2ixx0t6.fsf@gmail.com> <83pnyhh6ta.fsf@gnu.org> <87o9e1w6kf.fsf@gmail.com> <83d0uhgoxw.fsf@gnu.org> <87ftzcwso7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="252410"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32452@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 07:40:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCdYg-0013aA-0U for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 07:40:18 +0200 Original-Received: from localhost ([::1]:40976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCdYe-0001tQ-KL for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 01:40:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55154) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCdYS-0001tF-LO for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 01:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCdYQ-0007Mk-R4 for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 01:40:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56854) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCdYQ-0007MW-E5 for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 01:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCdYQ-0004U7-6n for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 01:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 05:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32452 X-GNU-PR-Package: emacs Original-Received: via spool by 32452-submit@debbugs.gnu.org id=B32452.156930355517179 (code B ref 32452); Tue, 24 Sep 2019 05:40:02 +0000 Original-Received: (at 32452) by debbugs.gnu.org; 24 Sep 2019 05:39:15 +0000 Original-Received: from localhost ([127.0.0.1]:37442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCdXe-0004T1-VG for submit@debbugs.gnu.org; Tue, 24 Sep 2019 01:39:15 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCdXd-0004St-8W for 32452@debbugs.gnu.org; Tue, 24 Sep 2019 01:39:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCdXZ-0001en-6O; Tue, 24 Sep 2019 07:39:11 +0200 In-Reply-To: <87ftzcwso7.fsf@gmail.com> (Noam Postavsky's message of "Fri, 17 Aug 2018 18:10:32 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167067 Archived-At: Noam Postavsky writes: > + enum { MAX_DELAY_NS = 100 * 1000 * 1000 }; // Max 100ms delay. > + struct timespec delay = { 0, 1000 }; > do > { > ret = gnutls_handshake (state); > @@ -558,7 +560,9 @@ gnutls_try_handshake (struct Lisp_Process *proc) > } > while (ret < 0 > && gnutls_error_is_fatal (ret) == 0 > - && ! non_blocking); > + && ! non_blocking > + && (nanosleep (&delay, NULL), > + delay.tv_nsec = min (delay.tv_nsec * 2, MAX_DELAY_NS))); This code has changed somewhat since the proposed patch: while ((ret = gnutls_handshake (state)) < 0) { do ret = gnutls_handshake (state); while (ret == GNUTLS_E_INTERRUPTED); if (0 <= ret || emacs_gnutls_handle_error (state, ret) == 0 || non_blocking) break; maybe_quit (); } But perhaps adding some sleep here would be a good idea, anyway. On the other hand, 100ms seems way too long -- that's a noticeable slow-down in network set-up. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no