unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: ynyaaa@gmail.com
Cc: 26978@debbugs.gnu.org
Subject: bug#26978: 25.2; incomplete display of SVG image
Date: Thu, 26 Sep 2019 17:50:22 +0200	[thread overview]
Message-ID: <87h84zrr9d.fsf@gnus.org> (raw)
In-Reply-To: <87lfubrrvd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 26 Sep 2019 17:37:10 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> So I'm wondering whether there's something we can tell the rsvg library
> to make it find these sub-images, or something. 

This works correctly:

(insert-image (create-image "/tmp/test-svg/sample-png.svg"))

The problem is that when you C-x C-f the image, then this code fails,
sort of::

static bool
svg_load (struct frame *f, struct image *img)
{
  bool success_p = 0;
  Lisp_Object file_name;

  /* If IMG->spec specifies a file name, create a non-file spec from it.  */
  file_name = image_spec_value (img->spec, QCfile, NULL);
  if (STRINGP (file_name))

Because the image is in the buffer already, we don't tell the rsvg
library what the file name is, and so it can't find the sub-images in
question.

Hm...  hang on...  I'm getting spurious results here.  I think
image-mode is supposed to pass the file name into create-image in most
cases...  but I'm getting sporadic failures: Sometimes it works and
sometimes it doesn't.  Can't see any pattern, really.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-09-26 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  4:24 bug#26978: 25.2; incomplete display of SVG image ynyaaa
2017-05-18  4:55 ` Eli Zaretskii
2017-05-18  5:19 ` Eli Zaretskii
2017-05-18 10:02   ` ynyaaa
2017-05-18 15:34     ` Eli Zaretskii
2019-09-26 15:37     ` Lars Ingebrigtsen
2019-09-26 15:50       ` Lars Ingebrigtsen [this message]
2019-09-26 15:53         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h84zrr9d.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=26978@debbugs.gnu.org \
    --cc=ynyaaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).