From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4911: mouse-face property should merge face attributes, not replace Date: Tue, 01 Oct 2019 16:08:02 +0200 Message-ID: <87h84s5zjx.fsf@gnus.org> References: <4AFC026C.4060701@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="215233"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 4911@debbugs.gnu.org To: Dave Aspinall Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 16:09:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFIq2-000toW-H1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 16:09:14 +0200 Original-Received: from localhost ([::1]:42616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIq1-0003rS-5g for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 10:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35639) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIps-0003qL-Ci for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 10:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIpr-0002aT-8X for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 10:09:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIpr-0002aO-5L for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 10:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFIpq-0006Sh-VG for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4911 X-GNU-PR-Package: emacs Original-Received: via spool by 4911-submit@debbugs.gnu.org id=B4911.156993888924754 (code B ref 4911); Tue, 01 Oct 2019 14:09:02 +0000 Original-Received: (at 4911) by debbugs.gnu.org; 1 Oct 2019 14:08:09 +0000 Original-Received: from localhost ([127.0.0.1]:34229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIoz-0006RC-3K for submit@debbugs.gnu.org; Tue, 01 Oct 2019 10:08:09 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:51966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIow-0006R2-PG for 4911@debbugs.gnu.org; Tue, 01 Oct 2019 10:08:07 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFIos-0003ot-Ni; Tue, 01 Oct 2019 16:08:05 +0200 In-Reply-To: <4AFC026C.4060701@googlemail.com> (Dave Aspinall's message of "Thu, 12 Nov 2009 12:41:16 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168008 Archived-At: Dave Aspinall writes: > Perhaps this has been noted already: the low-level behaviour of the > mouse-face property seems ugly: it simply overwrites the face property > for characters under the mouse. For example in Info, blue underlined > links turn black without the underline when the mouse is hovered over > them to give the green background from the highlight face. This feels > unnatural. > > In Proof General (http://proofgeneral.inf.ed.ac.uk) we use the > mouse-face property on programming language text which is heavily > decorated with font-lock. Users complain that when the mouse is over > a region the normal fontification is obliterated. To reproduce: (insert (propertize "hello" 'face 'underline 'mouse-face 'highlight)) and put the mouse pointer over the "hello": The underline goes away. I think it might make sense to merge the properties... but, on the other hand, this may make the text illegible. For instance, this (insert (propertize "hello" 'face '(:foreground "blue") 'mouse-face 'highlight)) would become a blank, blue box if the highlight face didn't define both a foreground colour. So I'm not sure this would work. Any opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no