From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Date: Mon, 14 Oct 2019 20:34:21 -0400 Message-ID: <87h84a6e42.fsf_-_@gmail.com> References: <87h8eq332i.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="162248"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 33959@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 02:35:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKAoG-000g6Z-Iy for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 02:35:32 +0200 Original-Received: from localhost ([::1]:59034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAoF-0008LV-Db for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2019 20:35:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59156) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAnn-0008Ia-FW for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:35:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKAnm-0000HS-HV for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKAnm-0000HL-EF for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKAnm-0001YU-Af for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33959-submit@debbugs.gnu.org id=B33959.15710996725908 (code B ref 33959); Tue, 15 Oct 2019 00:35:02 +0000 Original-Received: (at 33959) by debbugs.gnu.org; 15 Oct 2019 00:34:32 +0000 Original-Received: from localhost ([127.0.0.1]:42454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAnG-0001XA-N0 for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:34:30 -0400 Original-Received: from mail-io1-f46.google.com ([209.85.166.46]:34164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAnF-0001Wu-8g for 33959@debbugs.gnu.org; Mon, 14 Oct 2019 20:34:29 -0400 Original-Received: by mail-io1-f46.google.com with SMTP id q1so42026852ion.1 for <33959@debbugs.gnu.org>; Mon, 14 Oct 2019 17:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CIdXHl6zTUW8Kr5HcChUD/FeZBZu5XaOzxDWh/PHLx0=; b=PqEA/1jqahrdmcAcEtph0uCJ5teWkc9KpLXlnmYGc9dfU2LV7MMaymy62W9NYo7HVd R4oKBMMCMLsTnB3tpLnv8v0JB46T1qKie/HMbLqNP4HN9Dk+oDgoul55GhAqJPbBjg6P jMbkE0tQ6ZzmTji+TjnohySifNwzC0OSlR+fiyBjhaqWK70a7wpZLX5gvohUF6q89SCl g3pcaZybcsClKvblbNTVKIx16mwSlhHYjA5sJqd1ZKwmrTwYo0ZegXGMLVyRGF1DC7YZ 6kqKoA4Fu9dOR/uTmPbfXBTdD87KCJo8srMACR8k+NK6xxW7KVPMonKGci5b+W7+5axX iQUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CIdXHl6zTUW8Kr5HcChUD/FeZBZu5XaOzxDWh/PHLx0=; b=gd82PFulWUlVuvYuGgv6MdWLkATXyqQMouC+zU/RVVpFSXRuz/V4T8XygWdnXqGat+ Mw2rG0lxnAT4C4moy3nltiSC25oLhutaShNblrY04Bpou3CUS/q0ou03aHtCV14mwi5H fBBMA9CzB7ejknoGeJ5RCd5+kwljOkNmtRlqojk4bAX1zjmRZuW8txiZDrFx1pfxZWKi rmCa0C7eSGKO33z3JLgGPfJl87I0iHWFFZOpMm1bEJjbQPOjhQa4eP3Cuv/Gk8ruhVoN TiY3U/mQwMB/2IBij0BizZCE/0IUaUh7QrJ+figA9P3dwsGHLqhjlktEorTPoRQ7F5ss AyhA== X-Gm-Message-State: APjAAAUil3dZtlLu8OIaiF9+MhgJ13ZR+tquXxhuwzHfwwL2WpZraL+v 39z88zr05iyx5L/nECfUQQubhuap X-Google-Smtp-Source: APXvYqzxjIkg684mFco1kyL6kF34OS9qRsAZE9z2q+rk+z647awMfHE1Ws4m9r8oPO/F+C4uhbFpRw== X-Received: by 2002:a92:3bdc:: with SMTP id n89mr3200566ilh.219.1571099663436; Mon, 14 Oct 2019 17:34:23 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id w5sm2300696ila.75.2019.10.14.17.34.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 17:34:22 -0700 (PDT) In-Reply-To: (Carlos Pita's message of "Sun, 13 Oct 2019 16:39:38 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169340 Archived-At: Carlos Pita writes: > Noam I'd like to get this merged (because my local patch queue is > getting too big :P ) Heh, I know the feeling :) >> I'd still like a deterministic test, though, since this bug is such a pain to reproduce. > > I'm not quite understanding what do you want me to do. I don't think > there is a suite of unit tests to prevent regressions in python.el Well, test/lisp/progmodes/python-tests.el exists, so yes there is? > you can't reasonably expect me to write that entire suite just to get > this minor patch accepted, so I figure you're after another thing > here. Do you want very explicit instructions that ensure > reproducibility of the issue, is that it? Mainly I've been hesitant to apply this patch because I don't understand why it works. It kind of looks like it might just be papering over some subtle problems (similar to fixing a race condition by adding a sleep call). And also the overlap with the Bug#32390 fix made things more confusing; now that I've pushed it, at least that problem is gone. Writing a regression test would be one way of showing where exactly the problem comes from, and would help understand why the solution is correct.