From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#38918: 26.3; EBDB fails to edit (add) tags Date: Tue, 07 Jan 2020 09:37:02 -0800 Message-ID: <87h817uq0x.fsf@ericabrahamsen.net> References: <87d0bzcnmm.fsf@disroot.org> <87zhf3m4pe.fsf@ericabrahamsen.net> <87blri6a9j.fsf@disroot.org> <87r20en36v.fsf@ericabrahamsen.net> <87v9pqgou0.fsf@disroot.org> <8736csz841.fsf@ericabrahamsen.net> <87d0bv1mmb.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120277"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38918@debbugs.gnu.org To: Jorge P. de Morais Neto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 07 18:38:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ioso7-000RHK-Jk for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 18:38:19 +0100 Original-Received: from localhost ([::1]:54062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioso5-0006aD-Ni for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 12:38:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37917) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iosns-0006Qg-62 for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 12:38:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iosnq-0008Nz-PT for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 12:38:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iosnq-0008No-Lm for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 12:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iosnq-0006pL-Jv for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 12:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38918 X-GNU-PR-Package: emacs Original-Received: via spool by 38918-submit@debbugs.gnu.org id=B38918.157841863226150 (code B ref 38918); Tue, 07 Jan 2020 17:38:02 +0000 Original-Received: (at 38918) by debbugs.gnu.org; 7 Jan 2020 17:37:12 +0000 Original-Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosn1-0006nf-SI for submit@debbugs.gnu.org; Tue, 07 Jan 2020 12:37:12 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:44098 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosn0-0006nN-PR for 38918@debbugs.gnu.org; Tue, 07 Jan 2020 12:37:11 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 3EF00FA080; Tue, 7 Jan 2020 17:37:03 +0000 (UTC) In-Reply-To: <87d0bv1mmb.fsf@disroot.org> (Jorge P. de Morais Neto's message of "Tue, 07 Jan 2020 09:23:24 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174325 Archived-At: Jorge P. de Morais Neto writes: > Em [2020-01-06 seg 11:40:30-0800], Eric Abrahamsen escreveu: > >> Oh, sorry, these two were actually the same problem, and all should be >> fixed now. I've done a 0.6.12 release -- would you update when it's >> available and check that this fixes everything? Though I'm not sure >> if it will address your other error. Let's get this closed out first. > > Yes, with EBDB 0.6.12 I can insert and edit tags, and I can edit them > with both "e" and "E". The error message when, in the extended > customize interface ("E"), I hit "[Apply]" and then "[Accept]", also > seems to have been fixed. There is still one quirk: when I insert a > tags field on a record that already has a tags field, EBDB overwrites > the old field and, when it asks for the tags, it does not offer the > previous ones as default. It would be more user-friendly if EBDB either > offered the previous tags as default, or simply signaled an error with a > short and clear message. Yes, this isn't ideal; there's no indication of which fields are "singletons" and which aren't. I think you're right that inserting a new field should essentially behave like editing the old one -- actually maybe that's all that needs to happen. That plus a message afterwards. I'll take a look. > And two feature requests: > > 1. Undo. So far I have never suffered much for the lack of undo (it is > only an inconvenience) and of course I leave it up to you to > prioritize this feature, but it would be useful, though clearly not > as useful as 2: I've thought about this in the past. Each record has a "cache" object that stores metadata and computed strings for the record, and this would be natural place to store undo information. A dumb implementation could store entire copies of the record as it is edited, and allow you to switch them out. Alternately, the vCard specs provide for a versioning system for individual properties (https://tools.ietf.org/html/rfc6350#section-7), maybe I could adapt that once I've gone and figured out how it works. > 2. Compatibility with other contacts formats. I would like to import my > Gmail contacts and complete my transition away from G$$gle spyware. This is definitely on the roadmap, and taking me too long. Presumably you'd export your Gmail contacts as a vCard file? Or something else? I'm in the middle of writing a vCard parser, which is actually a separate library from EBDB (so other software can use it), but will be used in EBDB code. Anyway, if we're talking about importing vCards, that's on the way. > Should I open two bug reports for these two feature requests? For the undo feature, please -- it's not high priority but it would be good to keep track of. I've already got Github issues open for the other request. Thanks, Eric