* bug#40151: 28.0.50; Remove Date header from message-draft-headers
@ 2020-03-20 17:11 Eric Abrahamsen
2020-03-20 17:23 ` Lars Ingebrigtsen
2020-03-20 19:40 ` James Cloos
0 siblings, 2 replies; 11+ messages in thread
From: Eric Abrahamsen @ 2020-03-20 17:11 UTC (permalink / raw)
To: 40151
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
It was noted on gnus.general that it's weird to have the Date header as
part of the default value of `message-draft-headers'. Having it in there
means that a Date header is generated (and fixed) when a message is
first saved or delayed, not when it is sent. In the case of delayed
messages, in particular, it's weird that the eventually-sent message can
have a Date header days or weeks in the past.
Is there any interest in changing the default value?
Eric
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: message-draft-headers.diff --]
[-- Type: text/x-patch, Size: 583 bytes --]
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index f1ace0eeb2..eb9c79d66c 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -215,9 +215,9 @@ message-required-headers
:link '(custom-manual "(message)Message Headers")
:type '(repeat sexp))
-(defcustom message-draft-headers '(References From Date)
+(defcustom message-draft-headers '(References From)
"Headers to be generated when saving a draft message."
- :version "22.1"
+ :version "28.1"
:group 'message-news
:group 'message-headers
:link '(custom-manual "(message)Message Headers")
^ permalink raw reply related [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:11 bug#40151: 28.0.50; Remove Date header from message-draft-headers Eric Abrahamsen
@ 2020-03-20 17:23 ` Lars Ingebrigtsen
2020-03-20 17:31 ` Eric Abrahamsen
2020-03-20 19:40 ` James Cloos
1 sibling, 1 reply; 11+ messages in thread
From: Lars Ingebrigtsen @ 2020-03-20 17:23 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 40151
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> It was noted on gnus.general that it's weird to have the Date header as
> part of the default value of `message-draft-headers'. Having it in there
> means that a Date header is generated (and fixed) when a message is
> first saved or delayed, not when it is sent. In the case of delayed
> messages, in particular, it's weird that the eventually-sent message can
> have a Date header days or weeks in the past.
>
> Is there any interest in changing the default value?
Sure; makes sense to me.
Perhaps it should be documented in the "postpone" command(s), too.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:23 ` Lars Ingebrigtsen
@ 2020-03-20 17:31 ` Eric Abrahamsen
2020-03-20 17:44 ` Lars Ingebrigtsen
0 siblings, 1 reply; 11+ messages in thread
From: Eric Abrahamsen @ 2020-03-20 17:31 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 40151
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> It was noted on gnus.general that it's weird to have the Date header as
>> part of the default value of `message-draft-headers'. Having it in there
>> means that a Date header is generated (and fixed) when a message is
>> first saved or delayed, not when it is sent. In the case of delayed
>> messages, in particular, it's weird that the eventually-sent message can
>> have a Date header days or weeks in the past.
>>
>> Is there any interest in changing the default value?
>
> Sure; makes sense to me.
>
> Perhaps it should be documented in the "postpone" command(s), too.
You mean in the `gnus-delay-article' docstring? I didn't see anything
apropos of "postpone".
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:31 ` Eric Abrahamsen
@ 2020-03-20 17:44 ` Lars Ingebrigtsen
2020-03-20 17:55 ` Eric Abrahamsen
0 siblings, 1 reply; 11+ messages in thread
From: Lars Ingebrigtsen @ 2020-03-20 17:44 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 40151
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> You mean in the `gnus-delay-article' docstring? I didn't see anything
> apropos of "postpone".
No, but it should perhaps say something. Or at least point to
message-draft-headers...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:44 ` Lars Ingebrigtsen
@ 2020-03-20 17:55 ` Eric Abrahamsen
2020-03-20 18:20 ` Lars Ingebrigtsen
2020-03-23 8:09 ` Peter Münster
0 siblings, 2 replies; 11+ messages in thread
From: Eric Abrahamsen @ 2020-03-20 17:55 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 40151
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> You mean in the `gnus-delay-article' docstring? I didn't see anything
>> apropos of "postpone".
>
> No, but it should perhaps say something. Or at least point to
> message-draft-headers...
How's this look?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-the-Date-header-from-message-draft-headers.patch --]
[-- Type: text/x-patch, Size: 1822 bytes --]
From 951338269aa6b866b06ab59a2f10cb09f41f390a Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Fri, 20 Mar 2020 10:53:49 -0700
Subject: [PATCH] Remove the Date header from message-draft-headers
* lisp/gnus/message.el (message-draft-headers): The Date header should
reflect when the message is sent, not when it was saved or delayed.
---
lisp/gnus/gnus-delay.el | 6 +++++-
lisp/gnus/message.el | 4 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/lisp/gnus/gnus-delay.el b/lisp/gnus/gnus-delay.el
index 8dae4ef5c1..589ec6f807 100644
--- a/lisp/gnus/gnus-delay.el
+++ b/lisp/gnus/gnus-delay.el
@@ -75,7 +75,11 @@ gnus-delay-article
variable `gnus-delay-default-hour', minute and second are zero.
* hh:mm for a specific time. Use 24h format. If it is later than this
- time, then the deadline is tomorrow, else today."
+ time, then the deadline is tomorrow, else today.
+
+The value of `message-draft-headers' determines which headers are
+generate when the article is delayed. Remaining headers are
+generate when the article is sent."
(interactive
(list (read-string
"Target date (YYYY-MM-DD), time (hh:mm), or length of delay (units in [mhdwMY]): "
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index f1ace0eeb2..eb9c79d66c 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -215,9 +215,9 @@ message-required-headers
:link '(custom-manual "(message)Message Headers")
:type '(repeat sexp))
-(defcustom message-draft-headers '(References From Date)
+(defcustom message-draft-headers '(References From)
"Headers to be generated when saving a draft message."
- :version "22.1"
+ :version "28.1"
:group 'message-news
:group 'message-headers
:link '(custom-manual "(message)Message Headers")
--
2.25.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:55 ` Eric Abrahamsen
@ 2020-03-20 18:20 ` Lars Ingebrigtsen
2020-03-20 18:41 ` Eric Abrahamsen
2020-03-23 8:09 ` Peter Münster
1 sibling, 1 reply; 11+ messages in thread
From: Lars Ingebrigtsen @ 2020-03-20 18:20 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 40151
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> How's this look?
[...]
> +The value of `message-draft-headers' determines which headers are
> +generate when the article is delayed. Remaining headers are
^d
> +generate when the article is sent."
^d
Otherwise -- looks good to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 11+ messages in thread* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 18:20 ` Lars Ingebrigtsen
@ 2020-03-20 18:41 ` Eric Abrahamsen
0 siblings, 0 replies; 11+ messages in thread
From: Eric Abrahamsen @ 2020-03-20 18:41 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 40151-done
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> How's this look?
>
> [...]
>
>> +The value of `message-draft-headers' determines which headers are
>> +generate when the article is delayed. Remaining headers are
> ^d
>
>> +generate when the article is sent."
> ^d
A weird typo to make twice...
> Otherwise -- looks good to me.
Done, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:55 ` Eric Abrahamsen
2020-03-20 18:20 ` Lars Ingebrigtsen
@ 2020-03-23 8:09 ` Peter Münster
2020-03-23 8:35 ` Robert Pluim
1 sibling, 1 reply; 11+ messages in thread
From: Peter Münster @ 2020-03-23 8:09 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 40151, Lars Ingebrigtsen
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
On Fri, Mar 20 2020, Eric Abrahamsen wrote:
> - :version "22.1"
> + :version "28.1"
Why waiting for 28.1?
27.1 is not yet released.
--
Peter
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-23 8:09 ` Peter Münster
@ 2020-03-23 8:35 ` Robert Pluim
0 siblings, 0 replies; 11+ messages in thread
From: Robert Pluim @ 2020-03-23 8:35 UTC (permalink / raw)
To: Peter Münster; +Cc: Eric Abrahamsen, 40151, Lars Ingebrigtsen
>>>>> On Mon, 23 Mar 2020 09:09:00 +0100, Peter Münster <pmlists@free.fr> said:
Peter> On Fri, Mar 20 2020, Eric Abrahamsen wrote:
>> - :version "22.1"
>> + :version "28.1"
Peter> Why waiting for 28.1?
Peter> 27.1 is not yet released.
27.1 is in pre-release, which means no new features, bugfixes and doc
fixes only. I realise itʼs a small change, but who here hasn't
released software with 'just one last change' and gotten burnt?
Robert
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 17:11 bug#40151: 28.0.50; Remove Date header from message-draft-headers Eric Abrahamsen
2020-03-20 17:23 ` Lars Ingebrigtsen
@ 2020-03-20 19:40 ` James Cloos
2020-03-20 20:57 ` Eric Abrahamsen
1 sibling, 1 reply; 11+ messages in thread
From: James Cloos @ 2020-03-20 19:40 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 40151
there should be an easy way to avoid this change. on a per message basis.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 0x997A9F17ED7DAEA6
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#40151: 28.0.50; Remove Date header from message-draft-headers
2020-03-20 19:40 ` James Cloos
@ 2020-03-20 20:57 ` Eric Abrahamsen
0 siblings, 0 replies; 11+ messages in thread
From: Eric Abrahamsen @ 2020-03-20 20:57 UTC (permalink / raw)
To: James Cloos; +Cc: 40151
James Cloos <cloos@jhcloos.com> writes:
> there should be an easy way to avoid this change. on a per message basis.
Providing some per-message mechanism is beyond the scope of this change,
and I think would have to be tackled separately, but if you think this
change is bad and should be reverted, I'd be happy to hear why, and
discuss it. I probably should have left the report up for a while before
pushing it.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-03-23 8:35 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-20 17:11 bug#40151: 28.0.50; Remove Date header from message-draft-headers Eric Abrahamsen
2020-03-20 17:23 ` Lars Ingebrigtsen
2020-03-20 17:31 ` Eric Abrahamsen
2020-03-20 17:44 ` Lars Ingebrigtsen
2020-03-20 17:55 ` Eric Abrahamsen
2020-03-20 18:20 ` Lars Ingebrigtsen
2020-03-20 18:41 ` Eric Abrahamsen
2020-03-23 8:09 ` Peter Münster
2020-03-23 8:35 ` Robert Pluim
2020-03-20 19:40 ` James Cloos
2020-03-20 20:57 ` Eric Abrahamsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).