From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#41133: 28.0.50; Respect browse-url user options in shr/eww Date: Fri, 08 May 2020 09:18:43 +0200 Message-ID: <87h7wqlwrw.fsf@gnu.org> References: <87wo5njkbq.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: lars ingebrigtsen , 41133@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 08 09:20:33 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWxJ9-000Oc5-JD for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 May 2020 09:20:31 +0200 Original-Received: from localhost ([::1]:33008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWxJ8-0006Cc-M9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 May 2020 03:20:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWxHj-0005ju-7Z for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 03:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWxHi-0004HX-UT for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 03:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWxHi-0006qm-Ql for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 03:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 May 2020 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41133-submit@debbugs.gnu.org id=B41133.158892233726309 (code B ref 41133); Fri, 08 May 2020 07:19:02 +0000 Original-Received: (at 41133) by debbugs.gnu.org; 8 May 2020 07:18:57 +0000 Original-Received: from localhost ([127.0.0.1]:44519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWxHd-0006qH-Ge for submit@debbugs.gnu.org; Fri, 08 May 2020 03:18:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWxHb-0006q2-N1 for 41133@debbugs.gnu.org; Fri, 08 May 2020 03:18:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40926) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWxHW-0003di-2n; Fri, 08 May 2020 03:18:50 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:49585) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jWxHS-0004sD-V9; Fri, 08 May 2020 03:18:49 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 30A5C27C0054; Fri, 8 May 2020 03:18:46 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 08 May 2020 03:18:46 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedugdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnheptd elieffkeeuffduueeffefhiedtjeeutdeuveegfffgtdejleekheegkeetkeevnecukfhp pedufeegrdduudelrddvgedrudelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgse hfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: from jiffyarch (j289989.servers.jiffybox.net [134.119.24.195]) by mail.messagingengine.com (Postfix) with ESMTPA id 085B330661F0; Fri, 8 May 2020 03:18:44 -0400 (EDT) In-Reply-To: <87wo5njkbq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 08 May 2020 02:18:17 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179913 Archived-At: "Basil L. Contovounesios" writes: > X-Debbugs-Cc: Lars Ingebrigtsen , Tassilo Horn > Severity: wishlist > Tags: patch > > The commands shr-browse-url and eww-follow-link currently pass mailto > URLs directly to browse-url-mail, which doesn't respect the user options > browse-url-handlers and browse-url-mailto-function. > > Can't/shouldn't the commands call browse-url instead? > WDYT of the attached patch that does this? Looks good to me (I just looked at the parts calling browse-url), and I think it won't change any behavior unless the user customizes browse-url-handlers to catch mailto links with his own function instead of the default one in browse-url-default-handlers (which in turn just calls browse-url-mailto-function). BTW: I didn't know about function-put. Should that be preferred to put? I've tested that put/get also work with #'function, so where's the difference? Bye, Tassilo