From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Date: Tue, 09 Jun 2020 12:55:25 +0100 Message-ID: <87h7vkihci.fsf@tcd.ie> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="7294"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "41766@debbugs.gnu.org" <41766@debbugs.gnu.org>, Dmitry Gutov , Juri Linkov To: Simon Lang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 09 13:56:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jicrU-0001kw-7a for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 13:56:12 +0200 Original-Received: from localhost ([::1]:41436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jicrT-0004A9-4E for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 07:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jicrK-00049k-Pg for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 07:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jicrK-0000lp-G5 for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 07:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jicrK-0006VB-Fd for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 07:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jun 2020 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41766 X-GNU-PR-Package: emacs Original-Received: via spool by 41766-submit@debbugs.gnu.org id=B41766.159170373524946 (code B ref 41766); Tue, 09 Jun 2020 11:56:02 +0000 Original-Received: (at 41766) by debbugs.gnu.org; 9 Jun 2020 11:55:35 +0000 Original-Received: from localhost ([127.0.0.1]:59168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jicqt-0006UI-07 for submit@debbugs.gnu.org; Tue, 09 Jun 2020 07:55:35 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:51019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jicqs-0006U6-18 for 41766@debbugs.gnu.org; Tue, 09 Jun 2020 07:55:34 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id l17so2565377wmj.0 for <41766@debbugs.gnu.org>; Tue, 09 Jun 2020 04:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XYFYMjP6JfEr/2dtJJw4WjPL8gg5QXQF680jz28iCuE=; b=dtp4BRDiZZ6hcbPI7SbwkWRGuO+tHVCuchwpCw9f7sxdi5n5kpBFnHI5UdwU6fSvGf 24rmh3hbAKONXyYLHwk5HNU5LbqSp0PQqbrmvIdmp39BptMGwVZGc/ygPxgKjjKxbhRo S4WOZujM4QYnKoub0nqb5RDdAM+Lk2KH74utLPSlmH8KP7xlc+hVhcuf99Nfb4h9VbU1 9ycIvvpmVCu2B5ljVlaQrPPpSKP2GMXMqiCP0t0lb2vwIJnGg8i1okicSAaB3Un28RVw 4bLjQahZw4zHaMVlYEATyqvDWVEK3Z3Mz1r4I5SSjh/kSd6ng048Ad1gbousE7TxxXr6 QnFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XYFYMjP6JfEr/2dtJJw4WjPL8gg5QXQF680jz28iCuE=; b=o8r/eVk0NX0m5ODnpFaCcEhkG2jgjROJ34JfcItUtaAxVRseNgU3Gja4t4I8BoZdUc BVnCZNTwQVqfo1fyBj8S7ncmJ8lRHVsjUFnQLWzZMVmmQuEQdGgxDIJFwupb/U8ppOew iUv42mNlsR1q1xSXCYlInC2VsY3Tdnvc+OXbyK35C9NTM3NUQX1eqpDHEBWb1OpPTRRm HTBLxL4OOS2dGwmdsMyTUxgljb2QaXajBJELHRBYxg1xiLwjrvXMlRQOvE1VTYtTLeOX dMUXL+E7H3xDck8pZhTxcS2Y+FsbEI9VGYXE2xrezUU6fmwJaQlIG2sR1iY8LFzWoldC 4zmg== X-Gm-Message-State: AOAM533f2ATT0ogU8Ot1s+dBsFGFRqAPlttEc1G/zD4RJk18A+fVPIfw drUaGBsmY0FOoyg4jheJoxp61A== X-Google-Smtp-Source: ABdhPJw7zfjtJDc2B7zRwcIz32E3b4qOQRWKWb5PlCpy8SpiURoITZ+hHUTFmS5WZmPXc4KlpOEvfQ== X-Received: by 2002:a1c:4c8:: with SMTP id 191mr3564749wme.14.1591703728141; Tue, 09 Jun 2020 04:55:28 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id u4sm2657011wmb.48.2020.06.09.04.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 04:55:27 -0700 (PDT) In-Reply-To: (Simon Lang's message of "Tue, 9 Jun 2020 07:58:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181768 Archived-At: Simon Lang writes: > From bc9b736ff20a03e831bc5110283ccf9241127773 Mon Sep 17 00:00:00 2001 > From: Simon Lang > Date: Mon, 8 Jun 2020 20:47:08 +0100 > Subject: [PATCH] Make regexp used to highlight grep matches customizable > > * lisp/progmodes/grep.el > --- > lisp/progmodes/grep.el | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el > index 7731be5965..3f0c99f6dc 100644 > --- a/lisp/progmodes/grep.el > +++ b/lisp/progmodes/grep.el > @@ -100,6 +100,9 @@ To change the default value, use \\[customize] or call the function > :set #'grep-apply-setting > :version "22.1") > > +(defcustom grep-match-regexp "\033\\[0?1;31m\\(.*?\\)\033\\[[0-9]*m" > + "Regex definition to identify grep markers to highlight matches.") Nit: How about "Regular expression matching grep markers to highlight." Every defcustom also needs: :type 'regexp :version "28.1" as well as possibly being announced in etc/NEWS. I wonder, though: the default value matches some quite obscure codes which aren't (and maybe shouldn't be) documented, so is a defcustom really suitable for this? Or would a defvar suffice? (I don't have strong feelings either way.) Thanks, -- Basil