From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Date: Sun, 21 Jun 2020 13:25:31 +0100 Message-ID: <87h7v4ip1g.fsf@tcd.ie> References: <87sgeo7ixe.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115338"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41977@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 21 14:26:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmz39-000Tu9-Oh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 14:26:15 +0200 Original-Received: from localhost ([::1]:43684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmz38-0004tc-Py for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 08:26:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmz2x-0004tV-DO for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 08:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmz2w-0008UJ-7c for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 08:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmz2w-0008Vi-33 for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 08:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41977-submit@debbugs.gnu.org id=B41977.159274234232683 (code B ref 41977); Sun, 21 Jun 2020 12:26:02 +0000 Original-Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 12:25:42 +0000 Original-Received: from localhost ([127.0.0.1]:59332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmz2c-0008V4-Hh for submit@debbugs.gnu.org; Sun, 21 Jun 2020 08:25:42 -0400 Original-Received: from mail-qk1-f172.google.com ([209.85.222.172]:45365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmz2a-0008Un-4U for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 08:25:41 -0400 Original-Received: by mail-qk1-f172.google.com with SMTP id q8so13162126qkm.12 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mFtcZIOB1j8o25ZD1ECcpbdqFhvQ3oo0xE/pEYTNb1E=; b=SUeS+Bo43hUUf2eFYzeaFDfkEF7dZ+9qTTz4wuuD7dhwhnz28WqLrqgM3J+sNl1B7b 7Nyiv9d5Oz5L45jSlPJjqSx9hb/vLYnunLMs4ZlCnWnOWqAM29uW0IljzD0kVJcWlmFP FCJ8oXoeFrBd7jYFW5i75lfMK0gJj8fz65iUVkZvMgw1urs3J005ay0puf9RmBJqVOGI BdYYANik1uzwRvhxJF1ZClX1y5r6IVe8CnnrS7DsfYGN2YjQdaHV1sGzdLwNv8gw7xTd BMLHvUag6y5HSU/ZabpXria9/MXBL3E/6xcrQHQ1GuQss5mLrhf9Y6d3vi2UihE4oEEo EgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mFtcZIOB1j8o25ZD1ECcpbdqFhvQ3oo0xE/pEYTNb1E=; b=oIivchsfMZtutUmAflRoCnhzy0fYHe6Oo1xNjzGPJ38vKcuCs9Yem6MYwtk4rVKv56 6AJXHmc6OGXW01t6gbkz0c+EhfZtOQGrddIf1HGc5ph3JRcF0nrZ+8AaDf1oy359qZG0 etbROxPNYLN5puIIjzHVL4zUw7KNWTIWD2rPzv6NZFUYY8B8GxjH0r7Wwvw84w/oWKls Ss8pmiTQFtHtFKB/9yQnQez2qqrPwJlFMW/KSz51IRZ+MqAMiJ4NbmSUwHqKs2OOOD4G XZkSGn3cT/51RB3L2Dmpt5agcBJLXvNtqVP6o6YiI+Vc6tIVxGefrA8z6okNKDXzPF2Q u1Jw== X-Gm-Message-State: AOAM530DjXEWS/a2zOAg4sV3Q+XaxwHThYJDNDt5L+MuCznSBakCIxqH 1bstxB9F5jZpgRZ7gs3XHH8YmbvOYug= X-Google-Smtp-Source: ABdhPJzLMM17aAoaO4pwXJQJ0LJWov58I3taOvUQm17AbhhC8Ri0Rr0xycISMRUYLTtLtFIsCarbQA== X-Received: by 2002:a37:f505:: with SMTP id l5mr11260258qkk.118.1592742334420; Sun, 21 Jun 2020 05:25:34 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id 59sm10517573qtf.41.2020.06.21.05.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 05:25:33 -0700 (PDT) In-Reply-To: <87sgeo7ixe.fsf@thornhill.no> (Theodor Thornhill's message of "Sun, 21 Jun 2020 11:33:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182236 Archived-At: Theodor Thornhill writes: > From 4b3f83a4ea36252f7f7552b58529688f6b4c3c9f Mon Sep 17 00:00:00 2001 > From: Theodor Thornhill > Date: Sun, 21 Jun 2020 13:09:42 +0200 > Subject: [PATCH] project.el - eval-when-compile eshell > > * lisp/progmodes/project.el: eval-when-compile Eshell so we can use > 'eshell-buffer-name' in 'project-eshell' Since eshell-buffer-name is a variable, eval-when-compile is not the right thing to do here. Instead, there should be a (defvar eshell-buffer-name) inside project-eshell declaring the symbol as special. Right? Thanks, -- Basil