From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Date: Mon, 22 Jun 2020 00:02:25 +0100 Message-ID: <87h7v46n0e.fsf@tcd.ie> References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> <87lfkg48lr.fsf@thornhill.no> <87y2og8fs9.fsf@tcd.ie> <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="6869"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Theodor Thornhill , 41977@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 22 01:03:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jn8zc-0001fD-K5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 01:03:16 +0200 Original-Received: from localhost ([::1]:55844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn8zb-0000NV-Hl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 19:03:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn8zO-0000Kh-Hs for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 19:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jn8zO-0004YW-5j for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 19:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jn8zN-00062W-US for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 19:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 23:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41977-submit@debbugs.gnu.org id=B41977.159278055723188 (code B ref 41977); Sun, 21 Jun 2020 23:03:01 +0000 Original-Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 23:02:37 +0000 Original-Received: from localhost ([127.0.0.1]:32804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn8yy-00061w-Uf for submit@debbugs.gnu.org; Sun, 21 Jun 2020 19:02:37 -0400 Original-Received: from mail-wr1-f66.google.com ([209.85.221.66]:44370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn8yv-00061h-2Q for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 19:02:35 -0400 Original-Received: by mail-wr1-f66.google.com with SMTP id b6so14800172wrs.11 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 16:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BYXru6zKI3xoeq8Blnro2zZor51NPf6i0xtagKnVZ84=; b=FwejegVxhgKIBMDjHEsn06zBz2OTUkaencgewf8kCe6HRFAFqRLFwcmVBJmk0Dorpt Peelzol1nRIn5zsTQ7HXWKsmXnP7HghYZxi97wZ7zCZ+ezG28+hcqkChlpH5wRhH/FQi 5bwmfBFZi1t7LxR5S/NHkFR0A+1YeIti4L54UOGIMQSKPUpwZ5LzIPsq8cJ6VBo1OcEZ Cw11NwNYis+XVGUCWn1a9y12VI0LBpis3DKRpsVT7NJPH7D0smmJ1FjBkPOiNxWKbe0Q 46+mNVomkRNIJAQL9EW6cM9ATkJmFky1pdeVYzFlbutqzZyDdxjlhbCtkKX9usSHtGNE T8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BYXru6zKI3xoeq8Blnro2zZor51NPf6i0xtagKnVZ84=; b=HO13/hSp0NFDn3bulwLzewNKIDPlZGUE/i9/f24YDzFGykBEROHECGk6zN1CvxjYzh FGOEssEwpeCJZpHFnfw/lcjBosWnCYSryTZ5LfJGeNop2EjLF/z8llfj6EZqEf2LLCjU Bwhky5AeBPHet9nplN4op6Hf6F/DuTXlXSlnC7Lmd4vhLZ81UdirHk0CnhJHZwcr2goN GqsY7+KsEfBy76/8ZXWwTfb1o81mWam2ffp5FPoGYZOFmj/LV39JZ0PjHNV/nPcrz5+I xa2woSjzx0Hhz/U6fDUpSS/1npdgPgzCkx3U+Z6Yv86Hhfd59AbjL/LbjdXjdy2vVwCS ti1Q== X-Gm-Message-State: AOAM533u/fSig9Dq8hrXkUZMtySwiwTmRB6kpNhXgik+Rv6Bo9+n9mN2 XT5wpveZcz6cGUyc+7J8Oglv7w== X-Google-Smtp-Source: ABdhPJwVfSGADfVmlEafnabacvdQ0c++Vfqdum6I2gusXTbaGR2wLbFH45kYdsK4BnKR8C0/47HUhQ== X-Received: by 2002:a5d:45cb:: with SMTP id b11mr15294963wrs.235.1592780547108; Sun, 21 Jun 2020 16:02:27 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id b143sm14637614wme.20.2020.06.21.16.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 16:02:26 -0700 (PDT) In-Reply-To: <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru> (Dmitry Gutov's message of "Mon, 22 Jun 2020 01:52:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182260 Archived-At: Dmitry Gutov writes: > On 21.06.2020 20:55, Basil L. Contovounesios wrote: >>> You are absolutely correct, and TIL - thanks:) >>> >>> Below is another patch doing this. Works fine in emacs -Q >> Thanks, LGTM. > > Thanks all! > > Pushed (after rephrasing the commit message in the imperative mood). In the future it should also be rephrased to include a reference to the bug#number. ;) (Sorry, I didn't notice either.) Thanks, -- Basil