From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Tue, 30 Jun 2020 01:58:54 +0300 Organization: LINKOV.NET Message-ID: <87h7utjx75.fsf@mail.linkov.net> References: <87r1ulxk48.fsf@mail.linkov.net> <7164426e-8c37-8839-64da-563cfa829b53@yandex.ru> <87mu50j5cu.fsf@mail.linkov.net> <87y2oh8fdv.fsf@mail.linkov.net> <87366ohw5z.fsf@mail.linkov.net> <878sge7jls.fsf@mail.linkov.net> <7e136435-7123-fa42-e4a8-66b82e6595da@yandex.ru> <87pn9pxris.fsf@mail.linkov.net> <83d05ottnw.fsf@gnu.org> <0b42f540-f779-446b-4411-8dae3a50d09d@yandex.ru> <837dvwtrv1.fsf@gnu.org> <835zbgtqps.fsf@gnu.org> <625de669-0715-1467-0bd1-84328b4bee5f@yandex.ru> <83wo3ws4g8.fsf@gnu.org> <83tuyzs2np.fsf@gnu.org> <87h7uuj1v3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="58669"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41821@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 30 01:06:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jq2rB-000FA3-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Jun 2020 01:06:33 +0200 Original-Received: from localhost ([::1]:37172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jq2rA-0005nM-BI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jun 2020 19:06:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jq2pj-0004Fe-11 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 19:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jq2pi-0002gl-Li for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 19:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jq2pi-0003KS-GA for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 19:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2020 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.159347188912766 (code B ref 41821); Mon, 29 Jun 2020 23:05:02 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 29 Jun 2020 23:04:49 +0000 Original-Received: from localhost ([127.0.0.1]:49737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq2pV-0003Jp-6T for submit@debbugs.gnu.org; Mon, 29 Jun 2020 19:04:49 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq2pO-0003JM-Sy for 41821@debbugs.gnu.org; Mon, 29 Jun 2020 19:04:43 -0400 X-Originating-IP: 91.129.96.187 Original-Received: from mail.gandi.net (m91-129-96-187.cust.tele2.ee [91.129.96.187]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C5D4E40004; Mon, 29 Jun 2020 23:04:35 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Mon, 29 Jun 2020 01:37:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182547 Archived-At: >> So analogously, vc.el is one of back-ends of project.el, so in vc.el >> there should be such line for using project functions: >> (require 'project) > > Not really. > > project-vc (which is the project backend) resides in project.el. > > It calls to some VC functions, but VC itself needs no awareness of > project.el. I see that project.el calls some functions from preloaded vc-hooks.el and some autoloaded functions from vc.el. According to this design, this feature should be implemented the same way. In 'vc-root-diff' command: (read-directory-name "Directory for VC root-diff: " nil (when (featurep 'project) (project-vc-known-roots))) Note the same prefix 'project-vc' for vc backend of project.el. Then 'project-vc-known-roots' in project.el be like this: (defun project-vc-known-roots () "Return a list of known vc roots." (seq-filter #'project-try-vc (project-known-project-roots))) Also every command that visits a directory in vc could register their dir in the project list when project.el is loaded, for example: (defun vc-dir (dir &optional backend) ... (when (featurep 'project) ;; Add current vc project dir to project list (let ((default-directory dir)) (project-current t)))