From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description Date: Sat, 11 Jul 2020 21:15:57 +0200 Message-ID: <87h7udzwuq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32276"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 42325@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 11 21:17:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1juKzl-0008Ir-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jul 2020 21:17:09 +0200 Original-Received: from localhost ([::1]:49990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juKzk-0005xz-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jul 2020 15:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juKze-0005xs-AF for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juKze-0004Iu-1P for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1juKzd-00005N-To for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2020 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.159449496632717 (code B ref -1); Sat, 11 Jul 2020 19:17:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Jul 2020 19:16:06 +0000 Original-Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juKyk-0008Vd-9J for submit@debbugs.gnu.org; Sat, 11 Jul 2020 15:16:06 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:36156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juKyh-0008VK-18 for submit@debbugs.gnu.org; Sat, 11 Jul 2020 15:16:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juKyg-0005Pz-Q4 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:16:02 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:52270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juKye-0004Fh-E2 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:16:02 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id q15so9376818wmj.2 for ; Sat, 11 Jul 2020 12:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=VIFtNlHPU4KxI7d7NjsrsWn8mRnzRjbAuJR934JGWEc=; b=pw6hP7Rf1kVg+MkDNm64JUBQ1X9qgX2y6c3OdxMSKrf1ZBH4/BAA8RV1/JdGXHGKrB x8fPg5JYJs0zl3Yolw3BTDv5T8OIrqtxBBaJhfJA+m1dnK0qQRs4/xFX/RiRwSOL2ofT DgBTBDdkFP4hpgirBLvVtS7uKgXMLqHSi4mpB57q+lEO4t3J9Nf9FxA5MnQQXA7fYKcJ XySGCnQ+TWHVTLZ+VR+BS3tqzIpaPkLizaV/EBNVl9M9Y7z60R4TeM06tWMNu+Sq/Vib Pyhq5HQhgj9FvxGh2FNYKZqHcZ6oWlRfimX0GwJ95hhv86Zxg+nhzQcpBlON8ermreed f/iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=VIFtNlHPU4KxI7d7NjsrsWn8mRnzRjbAuJR934JGWEc=; b=bpDcR8GeX+KaomBMUxPtwV200CBzyVs1sHxEHXrJ2dBzW7U7TOwdocR4SSp2qoNVPq Uq5Ku11lbWGuSNwGx3bptSWw+BhqC1IiEXN07CBG0SWPtWTOVj2JPwYuy1QZqbhRNsoh H6vvdNb9xfsixMcUIefTCqVKbTWJ9Kcf99peZrOjBYOa4Fd5HRKj2uom+APFQwxZPIyE kwpvkiFv5hufOmK42jpeomnJqu471aug0rKFaPSUGoXvpovnc88YnkJW4unyPqZH3hCf m3YsFxE/r1ZRTlo16MbsbOxeq4AXIQ6WDwsfC5MCvTcZPgkEvD807X9PRtLauPFcKt+3 82xA== X-Gm-Message-State: AOAM531qpKrPGbjseaMQJ77e4ABflVOaX5c6Mr9XaXV9lHh5P+Du3cW4 WHNWM29ZPqnCtQjicdJfHGgH74u/FhE= X-Google-Smtp-Source: ABdhPJxsmR1gxE1l/8mbod8IWY6ICwuhWKFBYSlRUZbxeBJ+edUt6zcgOPL9aZBHVjB3HtfswML73w== X-Received: by 2002:a1c:80d3:: with SMTP id b202mr11473117wmd.111.1594494958286; Sat, 11 Jul 2020 12:15:58 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:252:7910:9149:82b1:6f24:5186]) by smtp.gmail.com with ESMTPSA id 207sm16974701wme.13.2020.07.11.12.15.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2020 12:15:57 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=orontee@gmail.com; helo=mail-wm1-x32b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182927 Archived-At: --=-=-= Content-Type: text/plain; format=flowed When one call describe-mode from *Bookmark List* buffer, the displayed documentation for the Bookmark Menu major mode displays an incomplete hard-coded keymap: The useful key / (bookmark-bmenu-search) isn't listed. I propose to rely on derived-mode-make-docstring to put the mode's keymap in mode docstring and to remove the currently hardcoded keymap description. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-incomplete-keymap-description.patch >From e45b340980c9f347f4a2f0615006617bafd93260 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Sat, 11 Jul 2020 20:55:59 +0200 Subject: [PATCH] Fix incomplete keymap description * lisp/bookmark.el (bookmark-bmenu-mode): Rely on derived-mode-make-docstring to put the mode's keymap in mode docstring --- lisp/bookmark.el | 31 +------------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 5bb1698171..cf8d6e3241 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1745,36 +1745,7 @@ bookmark-bmenu-mode "Major mode for editing a list of bookmarks. Each line describes one of the bookmarks in Emacs. Letters do not insert themselves; instead, they are commands. -Bookmark names preceded by a \"*\" have annotations. -\\ -\\[bookmark-bmenu-mark] -- mark bookmark to be displayed. -\\[bookmark-bmenu-select] -- select bookmark of line point is on. - Also show bookmarks marked using m in other windows. -\\[bookmark-bmenu-toggle-filenames] -- toggle displaying of filenames (they may obscure long bookmark names). -\\[bookmark-bmenu-locate] -- display (in minibuffer) location of this bookmark. -\\[bookmark-bmenu-1-window] -- select this bookmark in full-frame window. -\\[bookmark-bmenu-2-window] -- select this bookmark in one window, - together with bookmark selected before this one in another window. -\\[bookmark-bmenu-this-window] -- select this bookmark in place of the bookmark menu buffer. -\\[bookmark-bmenu-other-window] -- select this bookmark in another window, - so the bookmark menu bookmark remains visible in its window. -\\[bookmark-bmenu-other-frame] -- select this bookmark in another frame. -\\[bookmark-bmenu-switch-other-window] -- switch the other window to this bookmark. -\\[bookmark-bmenu-rename] -- rename this bookmark (prompts for new name). -\\[bookmark-bmenu-relocate] -- relocate this bookmark's file (prompts for new file). -\\[bookmark-bmenu-delete] -- mark this bookmark to be deleted, and move down. -\\[bookmark-bmenu-delete-backwards] -- mark this bookmark to be deleted, and move up. -\\[bookmark-bmenu-execute-deletions] -- delete bookmarks marked with `\\[bookmark-bmenu-delete]'. -\\[bookmark-bmenu-save] -- save the current bookmark list in the default file. - With a prefix arg, prompts for a file to save in. -\\[bookmark-bmenu-load] -- load in a file of bookmarks (prompts for file.) -\\[bookmark-bmenu-unmark] -- remove all kinds of marks from current line. - With prefix argument, also move up one line. -\\[bookmark-bmenu-backup-unmark] -- back up a line and remove marks. -\\[bookmark-bmenu-show-annotation] -- show the annotation, if it exists, for the current bookmark - in another buffer. -\\[bookmark-bmenu-show-all-annotations] -- show the annotations of all bookmarks in another buffer. -\\[bookmark-bmenu-edit-annotation] -- edit the annotation for the current bookmark." +Bookmark names preceded by a \"*\" have annotations." (setq truncate-lines t) (setq buffer-read-only t)) -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed In GNU Emacs 28.0.50 (build 22, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-06-30 built on carbon Repository revision: bc8089a3fa11161428c51439fd3b26fd6583345d Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Recent messages: mouse-2, RET: find function's definition uncompressing emacsbug.el.gz...done Note: file is write protected Mark set Mark saved where search started Mark set scroll-down-command: Beginning of buffer [8 times] Quit Type "q" in help window to restore its previous buffer. Finding changes in ~/Sources/emacs/... Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: fr_FR.UTF-8 value of $LC_TIME: fr_FR.UTF-8 value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode semantic-idle-scheduler-mode semantic-mru-bookmark-mode) S))) vc-parent-buffer: *vc-dir* highlight-changes-visible-mode: t show-paren-mode: t shell-dirtrack-mode: t minions-mode: t semantic-mode: t desktop-save-mode: t save-place-mode: t electric-pair-mode: t icomplete-mode: t global-so-long-mode: t global-auto-revert-mode: t auto-insert-mode: t text-scale-mode: t tooltip-mode: t global-eldoc-mode: t electric-layout-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow emacsbug sendmail log-view log-edit pcvs-util add-log eieio-opt speedbar dframe help-fns radix-tree smerge-mode diff dabbrev tramp-cache hl-line calc-map calc-stat calc-vec calc-ext misearch multi-isearch mule-util calc-menu calc-aent calc calc-loaddefs calc-macs flow-fill etags fileloop sort gnus-cite smiley shr-color color mm-archive mail-extr gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 epa-file gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-cache whitespace sh-script smie executable rst generic bug-reference flyspell ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox goto-addr org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir gnus-sum url url-proxy url-privacy url-expand url-methods url-history mailcap shr url-cookie url-domsuf svg xml dom ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m semantic/wisent/python semantic/wisent/python-wy semantic/wisent semantic/wisent/wisent rx vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs eglot array jsonrpc ert debug backtrace xref flymake-proc flymake thingatpt warnings compile pcase url-util project imenu python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp conf-mode semantic/bovine/make semantic/decorate/include semantic/db-find semantic/db-ref semantic/decorate/mode semantic/decorate pulse semantic/dep semantic/bovine/make-by semantic/bovine display-line-numbers hilit-chg make-mode yasnippet-snippets yasnippet dired-aux paren vc-dir ewoc vc vc-dispatcher bash-completion shell cl-extra help-mode avoid minions carbon-custom cus-edit cus-start cus-load gnus-demon nntp gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc parse-time iso8601 gnus-spec gnus-win nnoo gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit gnus-dired dired-x dired dired-loaddefs org-capture org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color org-list org-faces org-entities time-date noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs advice skeleton find-file vc-git diff-mode easy-mmode semantic/mru-bookmark ring semantic/db-mode semantic/idle semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn semantic/db eieio-base semantic/format ezimage semantic/tag-ls semantic/find semantic/ctxt semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local find-func cedet ispell desktop frameset server bookmark text-property-search pp saveplace elec-pair edmacro kmacro icomplete so-long autorevert filenotify autoinsert cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs generic-x face-remap proof-site proof-autoloads info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 716231 86353) (symbols 48 44640 61) (strings 32 173896 12445) (string-bytes 1 6166036) (vectors 16 75398) (vector-slots 8 1825868 200660) (floats 8 485 330) (intervals 56 25773 1448) (buffers 992 162)) -- Matthias --=-=-=--