From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Date: Thu, 01 Oct 2020 01:55:13 +0200 Message-ID: <87h7reyg4e.fsf@gnus.org> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> <20200930183343.dmmyg2l6yzmfhkyl@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36807"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , Michael Albinus , 43714@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 01:56:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNlxB-0009RI-K9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 01:56:09 +0200 Original-Received: from localhost ([::1]:38710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNlxA-0002WY-N1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 19:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNlx4-0002U5-NI for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 19:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNlx4-0005Pw-Du for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 19:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNlx4-0003Mf-CI for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 19:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160151013212882 (code B ref 43714); Wed, 30 Sep 2020 23:56:02 +0000 Original-Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 23:55:32 +0000 Original-Received: from localhost ([127.0.0.1]:33372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNlwZ-0003Li-Nq for submit@debbugs.gnu.org; Wed, 30 Sep 2020 19:55:31 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNlwW-0003LP-BT for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 19:55:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QVaf6bd+FDxDcmFCHYOgqbPKSXonA+ScH4BHrqiFxKg=; b=bW1e9n0+YZ5mJ27P55icqsWMko 2JMcrKLBmlJFZVNYSaTfNAIwYpbQsBVR6H+MBSfgcv56MAOFdTM+Im/Ovn21Z2Ev4EzwyFojUTn1G BgPO8VwKtRJfyF8If7V+BVr0B66m6NEwsGQnQui5xaY9A4Qup/1cli3LiY9s3Zzwnofc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNlwJ-0007aa-Cv; Thu, 01 Oct 2020 01:55:21 +0200 X-Now-Playing: LCD Soundsystem's _Someone Great_: "Us V Them (Any Color U Like Remix by Windsurf)" In-Reply-To: <20200930183343.dmmyg2l6yzmfhkyl@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 14:33:44 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189439 Archived-At: Boruch Baum writes: > Attached is a new version of the patch, with the 'save-match-data' > restored. Thanks again, Glenn. Now applied to Emacs 28 (with some changes). As far as I can see, it's just a refactoring of auto-revert-buffers? Normally, we don't do pure refactorings like this (because it makes code archaeology more difficult), but this one seemed pretty nice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no