bug#44083: 27.0.50; tcl-mode: Wrong indentation

bug#44083: 27.0.50; tcl-mode: Wrong indentation

[Benjamin Riefenstahl]

[-- Attachment #1: Type: text/plain, Size: 25 bytes --]

Consider this Tcl file:


[-- Attachment #2: test.tcl --]
[-- Type: text/plain, Size: 37 bytes --]

test {
    proc p {} {
    }
    p
}

[-- Attachment #3: Type: text/plain, Size: 3188 bytes --]


Save as a file, open, mark-whole-buffer, indent-region.

Observed: The line containing just the letter "p" is moved to position
0.

Expected: The line stays correctly indented.

Tested both on branches master and emacs-27.

-----

In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2020-10-19 built on arrian
Repository revision: a93dceda3fdcca18b51cb96461e1b8a4fc61bfd7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
user-error: Beginning of history; no preceding item

Configured using:
 'configure 'CFLAGS=-O0 -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Tcl

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config
gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq
byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tcl
easymenu comint ansi-color ring tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 48201 9044)
 (symbols 48 6425 1)
 (strings 32 16665 1687)
 (string-bytes 1 542948)
 (vectors 16 10476)
 (vector-slots 8 133441 9944)
 (floats 8 20 34)
 (intervals 56 186 0)
 (buffers 1000 12))

bug#44083: What I have found.

[Tom Turkey]

I have tried the tcl.el released with versions 26.3 and 27.1. The 26.3 
version works for me.

The changes 'diff' shows that seem to matter are:

The new defun tcl-beginning-of-defun-function (&optional arg)

and its companion

         defun tcl-end-of-defun-function ()

It would appear that this was introduced prior to the 27. release as I 
have another tcl.el from a release that appears to be between these two. 
(It would be nice if a comment indicated the last change release.)

I hope this helps. I would rather not have to switch tcl.el every update.

In Agape

Tom

bug#44083: patch available to close this bug

[Anticrisis]

This bug is fixed by the patch here, message 26:

    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44834#26