From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only Date: Tue, 17 Nov 2020 22:55:50 +0000 Message-ID: <87h7pnk2yx.fsf@gmail.com> References: <875z68p5mr.fsf@tcd.ie> <87v9e8i3yz.fsf@tcd.ie> <838sb4w3i7.fsf@gnu.org> <87zh3ifjrq.fsf@mail.linkov.net> <87tutqi8yv.fsf@tcd.ie> <87pn4b68p1.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44629@debbugs.gnu.org, Juri Linkov To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 17 23:57:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kf9uR-00034k-Me for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Nov 2020 23:57:11 +0100 Original-Received: from localhost ([::1]:37074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf9uQ-0005VY-Os for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Nov 2020 17:57:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf9uJ-0005VC-17 for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 17:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf9uI-0001Gk-FP for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 17:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kf9uI-0004ri-E3 for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 17:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44629 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44629-submit@debbugs.gnu.org id=B44629.160565376218616 (code B ref 44629); Tue, 17 Nov 2020 22:57:02 +0000 Original-Received: (at 44629) by debbugs.gnu.org; 17 Nov 2020 22:56:02 +0000 Original-Received: from localhost ([127.0.0.1]:33330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf9tJ-0004qB-Tk for submit@debbugs.gnu.org; Tue, 17 Nov 2020 17:56:02 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:54957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf9tH-0004po-MS for 44629@debbugs.gnu.org; Tue, 17 Nov 2020 17:56:01 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id d142so396290wmd.4 for <44629@debbugs.gnu.org>; Tue, 17 Nov 2020 14:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=XL2o2VESXESstBrdleiTz9DraB2Nfl4rFgsSszNfGl0=; b=N59lZ9zBsF6o3Ed0wMKf9cQc3EThmgnAMvTuOpjLgRuv5cMRL7jUB8mq8IvNpz4oUV P/SwehemNxbuf9jubBWh5lDBz4fxVIycD8p7D6MYK1YQCU1tmzU/4YqVa9RaToCFH7H1 3sAQYHmYW0AV5IQdPesGefKgxh1hSqf5/wM+8v0sUAUP1tORR5ui85WYq/1iHkgdtW03 t0qrBBWaqJu3T6GRc5CrRlXEI0OGxGW2Q92AUvMg8IRW58X8yJs10DcaArDfrqMl52ZS dXAYVOzOdUcjvDqY3Kx+voY9G4/pGzx6Yg96n6lJZMBBwA8vddroINRZ/+YFJ6UJby0d m4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=XL2o2VESXESstBrdleiTz9DraB2Nfl4rFgsSszNfGl0=; b=RsoVWkjsIcNYBEaQTl/ih2HnAYSc7ZXisdPMJ4xWFsRabq36NyEXx9wYLyJ8DbXv0o 1xZAsJDYo5Jvm2EumpPu88jMPYxarnhCVJMCaZ6DRxzVH+b8CW9mL4txs3T0u5mQ6m2d cU/7WzZ8inKEQGMQjPD398uyr5mWIczOUMBzIV32fc4KqKAnuDv7c0H214OmVsc+aZPj vpvn1nb8bP7ROu45bkj94/9v1e6OOXN1rs262wc8UG0WtkEiDFhRZPNBX1okAglnh/kW XxMBBxTsvnr7j2MCN+yHkyMG6b3aNGPR8MnJgaE3pGUfeFKmPimy3MdxJs1/ruIPQGT/ 5VCg== X-Gm-Message-State: AOAM533Rxpfxv9FlAVf7LXsydNqwj9LdG8/AW7YJaQHbcxdtgAT4JkGS /6iL3uuayqBJ/PnEED7rmzHZJdu1jvY= X-Google-Smtp-Source: ABdhPJznaqGOnOfIiH5BPoarEiHKAOP1kWBfMDXP37q9u4POY0//7EArwFrHfd+COz74TJXdVyWdtg== X-Received: by 2002:a7b:c391:: with SMTP id s17mr1353387wmj.66.1605653753162; Tue, 17 Nov 2020 14:55:53 -0800 (PST) Original-Received: from krug ([89.180.145.179]) by smtp.gmail.com with ESMTPSA id i6sm275847wma.42.2020.11.17.14.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 14:55:52 -0800 (PST) In-Reply-To: <87pn4b68p1.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 17 Nov 2020 20:15:54 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193591 Archived-At: "Basil L. Contovounesios" writes: >> This doesn't change the fact that jsonrpc.el's use of `read-only-mode`=20 >> should probably be replaced by a simple setting of buffer-read-only, >> but it could avoid the change to eglot when it calls `gfm-view-mode`. >> Though maybe that change could be there, too. > > See my thoughts above on why Eglot needn't be changed in this regard. They make sense. > How's the attached patch for view.el and jsonrpc.el? Looks good, and the mini-refactoring in jsonrpc.el is also welcome. IMO, this doesn't need to be called out in NEWS. But let's hear from Lars. Jo=C3=A3o