From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Andrea G. Monaco" Newsgroups: gmane.emacs.bugs Subject: bug#45941: 28.0.50; rmail doesn't set modified flag when changing 'unseen' flag Date: Sun, 17 Jan 2021 18:55:59 +0100 Message-ID: <87h7nfbg7k.fsf@autistici.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16004"; mail-complaints-to="usenet@ciao.gmane.io" To: 45941@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 17 18:57:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1CIy-0003y3-Gs for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jan 2021 18:57:36 +0100 Original-Received: from localhost ([::1]:36366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1CIw-000395-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jan 2021 12:57:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1CIS-00038b-BZ for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2021 12:57:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34080) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1CIQ-0000qP-Oo for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2021 12:57:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1CIQ-0000df-Lg for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2021 12:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Andrea G. Monaco" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jan 2021 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45941 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16109061782396 (code B ref -1); Sun, 17 Jan 2021 17:57:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Jan 2021 17:56:18 +0000 Original-Received: from localhost ([127.0.0.1]:45626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1CHh-0000cZ-JP for submit@debbugs.gnu.org; Sun, 17 Jan 2021 12:56:17 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1CHf-0000cS-Oj for submit@debbugs.gnu.org; Sun, 17 Jan 2021 12:56:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1CHf-0002yp-6C for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2021 12:56:15 -0500 Original-Received: from latitanza.investici.org ([2001:888:2000:56::19]:31681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1CHc-0000YV-Mk for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2021 12:56:14 -0500 Original-Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4DJjJd0N5Dz8shb for ; Sun, 17 Jan 2021 17:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1610906161; bh=kQNfyV1uNjGdlpDjVGvC4SlSfqE3q1tCmHNYc2Qf7H8=; h=From:To:Subject:Date:From; b=hdBaOgHQ6NX2y6Y6hgiY4L3YYsM6Y1K/mP4PqZyrkrEb7DOvQ9MPO0Zoe5CP/c6/a qunp3SIzHdMFB+fk5TeG9DEaZ+lJyUjqG7v1uX+YiHUG4ws+fL8L40k0lFXfTfdAFW jbB6/Q/knOWbb0usGcQZ+laWkTqye96o1DykaHSc= Original-Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: andrea.monaco@autistici.org) by localhost (Postfix) with ESMTPSA id 4DJjJc6JjPz8shY for ; Sun, 17 Jan 2021 17:56:00 +0000 (UTC) Received-SPF: pass client-ip=2001:888:2000:56::19; envelope-from=andrea.monaco@autistici.org; helo=latitanza.investici.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198061 Archived-At: Hello, when I read a message for the first time in rmail, the unseen flag gets cleared, but this does not set the modified flag of the buffer: therefore the buffer can't be saved, nor Emacs offers to save it when I close the program, and information about read messages gets usually lost. These are the relevant lines in rmail.el, inside rmail-show-message-1: ;; Mark the message as seen, but preserve buffer modified flag. (let ((modiff (buffer-modified-p))) (rmail-set-attribute rmail-unseen-attr-index nil) (unless modiff (restore-buffer-modified-p modiff))) I'd prefer no special treatment of 'unseen' flag modification, so that it set the modified flag. I think that some users might prefer the current behavior, so we could add a variable, maybe named rmail-unseen-change-set-modified, to customize this. Warmly, Andrea Monaco In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-12-01 built on agm Repository revision: 90a543e630012cc58c175d5bf3ffd42bb156c6b6 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 Important settings: value of $LC_MONETARY: it_IT.UTF-8 value of $LC_NUMERIC: it_IT.UTF-8 value of $LC_TIME: it_IT.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: RMAIL Summary Minor modes in effect: display-time-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail shr-color color eieio-opt cl-extra speedbar ezimage dframe find-func shortdoc help-fns radix-tree help-mode misearch multi-isearch rmailsum shr kinsoku svg xml dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap qp rmailmm message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs cl-loaddefs cl-lib password-cache json subr-x map seq byte-opt gv bytecomp byte-compile cconv rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 191396 51037) (symbols 48 8932 2) (strings 32 128911 15394) (string-bytes 1 12255982) (vectors 16 118062) (vector-slots 8 1212654 84005) (floats 8 190 282) (intervals 56 5799 1278) (buffers 984 16))